Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make Travis commit linting more robust #23397

Closed
wants to merge 3 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 10, 2018

Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: nodejs#23307 (comment)
@Trott Trott added the wip Issues and PRs that are still a work in progress. label Oct 10, 2018
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed wip Issues and PRs that are still a work in progress. labels Oct 10, 2018
@Trott
Copy link
Member Author

Trott commented Oct 10, 2018

Looks ready-to-go. Light CI should be sufficient. 👍 here to fast-track.

@Trott Trott added the tools Issues and PRs related to the tools directory. label Oct 10, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 10, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: nodejs#23307 (comment)

PR-URL: nodejs#23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@Trott
Copy link
Member Author

Trott commented Oct 10, 2018

Landed in a1edecc

@Trott Trott closed this Oct 10, 2018
targos pushed a commit that referenced this pull request Oct 10, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

PR-URL: #23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

PR-URL: #23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

PR-URL: #23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

PR-URL: #23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
@Trott Trott deleted the travis-commit-range branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants