Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x backport] async_hooks: add missing async_hooks destroys in AsyncReset #23404

Closed
wants to merge 1 commit into from

Commits on Oct 10, 2018

  1. async_hooks: add missing async_hooks destroys in AsyncReset

    This adds missing async_hooks destroy calls for sockets (in
    _http_agent.js) and HTTP parsers. We need to emit a destroy in
    AsyncWrap#AsyncReset before assigning a new async_id when the instance
    has already been in use and is being recycled, because in that case, we
    have already emitted an init for the "old" async_id.
    
    This also removes a duplicated init call for HTTP parser: Each time a
    new parser was created, AsyncReset was being called via the C++ Parser
    class constructor (super constructor AsyncWrap) and also via
    Parser::Reinitialize.
    
    PR-URL: nodejs#23272
    Fixes: nodejs#19859
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    basti1302 committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    c650dfb View commit details
    Browse the repository at this point in the history