Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-require-symlink on Windows #23691

Merged
merged 1 commit into from Oct 23, 2018
Merged

test: fix test-require-symlink on Windows #23691

merged 1 commit into from Oct 23, 2018

Commits on Oct 23, 2018

  1. test: fix test-require-symlink on Windows 

    Creating directory symlinks on Windows require 'dir' parameter to be
provided.

Fixes: nodejs#23596

PR-URL: nodejs#23691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bzoz @refack
    bzoz authored and refack committed Oct 23, 2018
    Copy the full SHA
    d1d5924 View commit details
    Browse the repository at this point in the history