Back-port v8 changes for ppc64, Aix platform (Node 8 backport) #23718
Conversation
(Only changes to src/base/debug/stack_trace_posix.cc included) Original commit message: Fixes to V8 GN build process on aix platform src/base/debug/stack_trace_posix.cc: suppressed unused function warnings for functions DemangleSymbols, OutputPointer(in order to compile with -Werror flag) test/cctest/test-isolate-independent-builtins.cc: corrections to make ByteInText test case compatible with aix. (affects aix only) Change-Id: I49e45e63545404c77aaed3f51b26557f6f03455e Reviewed-on: https://chromium-review.googlesource.com/927484 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#52071}
deps/v8/gypfiles/standalone.gypi: pass -Wno-nonnull-compare, -Wno-address, -Wno-unused-function to gcc on AIX in order to compile with -Werror flag
Original commit message: ppc64, aix: Pass CallFrequency object by const reference to avoid value copy error. Bug: v8:8193 GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 Change-Id: I0d4efca4da03ef82651325e15ddf2160022bc8de Reviewed-on: https://chromium-review.googlesource.com/1228633 Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56275}
nodejs-github-bot
added
v8 engine
…to GCC on Aix (not required to build with gcc 4.8.5).
|
@mhdawson Removed the unnecessary gcc flags from the PR |
…est project; Suppress unused function warnings in deps/v8/src/compiler/store-store-elimination.cc, deps/v8/src/conversions.cc in order to compile with newer (>4.8.5) gcc on Aix.
|
@mhdawson Uploaded the v8/testing/gtest.gyp patch, PTAL |
|
@V-for-Vasili I think this needs to be update so that we just have the final commits which should land. I believe we should have: deps: cherry-pick 6bc4bfe from V8 upstream and then 1 commit for My understanding is that because of the checkypicks we'll end up landing as multiple commits and by getting this PR into that shape we'll be able to ensure they land correctly. Otherwise the final content of all of the commits taken together looks good so I'll approve once the commits are refactored into the right shape. If you want/need any help doing that just let me know. |
Back-port v8 changes for ppc64, Aix platform
Changes included:
ppc64, aix: Pass CallFrequency object by const reference to avoid value copy error.
Bug: v8:8193
GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976
V8 Revision: d2e0166ded485df126c765b9196f7edd1ce50f82
Link: https://chromium-review.googlesource.com/c/v8/v8/+/1228633
ppc64, aix: Fixes to V8 GN build process on aix platform
(Only changes to src/base/debug/stack_trace_posix.cc included)
V8 Revision: 6bc4bfea655723b6e71280e71a3dae07c37d7b44
Link: https://chromium-review.googlesource.com/c/v8/v8/+/927484