Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove reference to sslv3 in tls.md #23745

Closed
wants to merge 1 commit into from
Closed

doc: remove reference to sslv3 in tls.md #23745

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 19, 2018

Issue #9822 mentioned some no longer supported SSLv3 references in the tls.md docs. The references were removed since but there's one that still lingered.

Fixes: #9822

Checklist

@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1290/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Oct 19, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 19, 2018
@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2018

Please 👍 to fast-track

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 19, 2018
@danbev
Copy link
Contributor

danbev commented Oct 22, 2018

Landed in d2fcd1d.

@danbev danbev closed this Oct 22, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 22, 2018
@jasnell @danbev
doc: remove reference to sslv3 in tls.md
d2fcd1d 
PR-URL: nodejs#23745
Fixes: nodejs#9822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danbev
Copy link
Contributor

danbev commented Oct 22, 2018

Landed in d2fcd1d.

jasnell added a commit that referenced this pull request Oct 22, 2018
@jasnell
doc: remove reference to sslv3 in tls.md
3f292bf 
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@jasnell @MylesBorins
doc: remove reference to sslv3 in tls.md
f8bd7c0 
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@jasnell @MylesBorins
doc: remove reference to sslv3 in tls.md
af41f6b 
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: remove reference to sslv3 in tls.md
e2d2ce6 
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: remove reference to sslv3 in tls.md
e72f326 
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jasnell @MylesBorins
doc: remove reference to sslv3 in tls.md
5d5f85e 
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jasnell @nodejs-github-bot @danbev @lpinca @BridgeAR @trivikr @MylesBorins