Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document that addMembership must be called once in a cluster #23746

Closed
wants to merge 5 commits into from
Closed

doc: document that addMembership must be called once in a cluster #23746

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
08c277c
doc: document that addMembership must be called once in a cluster
jasnell Oct 19, 2018
6a75be5
[Squash] nits
jasnell Oct 19, 2018
1763ea1
[Squash] nits
jasnell Oct 19, 2018
771a5e0
[Squash] nit
vsemozhetbyt Oct 19, 2018
9e8e181
[Squash] nit
vsemozhetbyt Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions doc/api/dgram.md
View file
Open in desktop
Expand Up @@ -95,6 +95,24 @@ Tells the kernel to join a multicast group at the given `multicastAddress` and
one interface and will add membership to it. To add membership to every
available interface, call `addMembership` multiple times, once per interface.

When sharing a UDP socket across multiple `cluster` workers, the
`socket.addMembership()` function must only be called *only once* or an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one too many occurrences of the word only.

FWIW, I'd avoid the italics here too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to make any edits you'd like

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the new github feature to make suggestions that add a commit by accepting the suggestion :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not mistaken, any Collaborator can assign themselves to a PR and accept an own proposed change. This can alleviate nit addressing for the PR author, but also can be felt like a bit arbitrarily thing. But if a PR author declares concent, this seems OK.

`EADDRINUSE` error will occur:

```js
const cluster = require('cluster');
const dgram = require('dgram');
if (cluster.isMaster) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is failing because of indentation issues on this line and the next two lines.

cluster.fork(); // Works ok
cluster.fork(); // Fails with EADDRINUSE
} else {
const s = dgram.createSocket('udp4');
s.bind(1234, () => {
s.addMembership('224.0.0.114');
});
}
```

### socket.address()
<!-- YAML
added: v0.1.99
Expand Down