Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use more explicit return type in Sign::SignFinal() #23779

Closed
wants to merge 2 commits into from
Closed

src: use more explicit return type in Sign::SignFinal() #23779

wants to merge 2 commits into from

Commits on Oct 20, 2018

  1. src: use more explicit return type in Sign::SignFinal() 

    Using the non-indexed variant of `std::get<>` broke Travis CI.
Also, this allows us to be a bit more concise when returning
from `SignFinal()` due to some error condition.

Refs: nodejs#23427
    @addaleax
    addaleax committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    b004648 View commit details
    Browse the repository at this point in the history

  2. fixup! src: use more explicit return type in Sign::SignFinal()

    @addaleax
    addaleax committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    a765e78 View commit details
    Browse the repository at this point in the history