Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix syntax in doc/api/path.md #23864

Closed
wants to merge 2 commits into from
Closed

doc: fix syntax in doc/api/path.md #23864

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56a458d
doc: fix syntax in doc/api/path.md
ZYSzys Oct 25, 2018
644b975
doc: simplify path.basename() on POSIX and Windows
ZYSzys Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/api/path.md
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@ paths are being used.

For example, using the `path.basename()` function with the Windows file path
`C:\temp\myfile.html`, will yield different results when running on POSIX than
when run on Windows:
when running on Windows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're in here, how about we take this opportunity to simplify the text? It's needlessly complex. It can probably be joined with the preceding paragraph too. How about just this?:

So using `path.basename()` might yield different results on POSIX and Windows:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm willing to do this.


On POSIX:

Expand Down