Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use "constants" string instead of creating new one #23894

Merged
merged 1 commit into from Oct 30, 2018
Merged

src: use "constants" string instead of creating new one #23894

merged 1 commit into from Oct 30, 2018

Commits on Oct 30, 2018

  1. src: use "constants" string instead of creating new one 

    Using the same "constants" string in c++.

PR-URL: nodejs#23894
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    @oyyd @refack
    oyyd authored and refack committed Oct 30, 2018
    Copy the full SHA
    2cab511 View commit details
    Browse the repository at this point in the history