Release proposal: v11.1.0 #23922
Merged
Release proposal: v11.1.0 #23922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #23787 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #23684 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Remove trailing " \n" from `process.versions.openssl`. d3d6cd3 was incorrectly printing this trailer, but because the target buffer size was claimed to be the length of the version string, the trailer was truncated off. 9ed4646 corrected the target buffer size, but then the trailer started to appear in process.versions. Added a test to check for regressions. PR-URL: #23678 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
PR-URL: #23771 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #23768 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #23734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #23794 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Moving @phillipj to emeriti as he has not been an active collaborator for a long time, and will not have the opportunity to do so in the near future. PR-URL: #23790 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063 Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Refs: #23414 (comment) PR-URL: #23804 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Introduced use of smart pointers instead of MallocedBuffer to manage memory allocated in the cares library. PR-URL: #23628 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Picking a path according to a boolean is essentially free, compared to the cost of a function call. Also, remove an unnecessary `TryCatch`. PR-URL: #23782 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
During key generation, the default dsa_builtin_paramgen will reset modulusLength to 512. But in dsa_builtin_paramgen2 this does not happen, leading to lockup in FIPS mode. PR-URL: #23732 Refs: #23430 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code duplication in SecureContext::Initialize. PR-URL: #23687 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit fixes test-tls-set-secure-context.js. The test was making one long lasting HTTP connection, followed by a number of shorter lived connections. However, it was possible that the connections were not received in the desired order. This commit ensures that the long lasting connection is established before making any other connections. PR-URL: #23811 Fixes: #23807 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #23605 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
The convertProtocols() function now throws a range error when the byte length of a protocol is too long to fit in a Buffer. Also added a test case in test/parallel/test-tls-basic-validations.js to cover this. PR-URL: #23606 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #23588 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Improve performance by providing JS with the raw ingridients for the read data, i.e. an `ArrayBuffer` + offset + length fields, instead of creating `Buffer` instances in C++ land. PR-URL: #23797 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23800 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This change adds test cases to call the function returned by end-of-stream and asserts that callbacks are not called when the stream is ended, or prematurely closed. PR-URL: #23751 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
`Set-Cookie` is a response header, replace it with `Cookie`. PR-URL: #23707 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Building node against versions of the dependencies that differ from the ones we vendor will result in a non ABI compatible version of Node.js This patch adds a note to make it explicit that if individuals build node against different versions of a dependency they should make a custom NODE_MODULE_VERSION. PR-URL: #22237 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The section of the README currently labeled "Release Team" isn't about the team much and is very much about the keys. Rename it "Release Keys" so that it's purpose matches it's name. PR-URL: #23927 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Previously only V8 options supported both dashes in them (making them equivalent), but now Node.js also supports both styles so the note can be removed. PR-URL: #23903 Refs: #18592 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
We removed the mailing list from the README and other places quite some time ago. Core devs don't monitor it much. However, it is still linked in a couple places in the docs directory. Remove those links. PR-URL: #23932 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23963 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
It can't be idiomatic if it's not in general use and therefore hasn't been picked up by users. It's not even in browsers yet. "Idiomatic" use is an emergent property that comes from observed use and this feature is so new (to browsers and Node) that it can't possibly be. In general I don't think it's the place of the Node API docs to observe what emerges as idiomatic Node.js. It also can't be a recommended feature (if that was the intent of the language) because it's marked experimental. For now, it's just a feature, nothing more. Recommendations and/or observations about it being 'idiomatic' can come later. PR-URL: #23885 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #23972 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #23970 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This previously leaked memory in the ‘success’ case. PR-URL: #23893 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #23491 Duplicate test instructions were present in pull-requests.md Merged the instructions in BUILDING.md and provided a link from pull-requests.md PR-URL: #23949 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #23706 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #23957 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Copy-edit for clarity and brevity. PR-URL: #23966 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Per branding guidelines from the Foundation, use Node.js and not Node. PR-URL: #23967 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #23967 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
force-pushed
the
v11.1.0-proposal
branch
from
3dfd630
to
af6d262
Compare
|
OK, thank you @richardlau and @refack. I removed the commits that were from those PRs. I also cherry-picked a few more doc and test fixes from master. I can't run CI because it's shutting down. Here is a test release build: https://ci-release.nodejs.org/job/iojs+release/3889/ |
|
ci-release on arm7 is ✔️ |
|
Rebuild failed CI: https://ci.nodejs.org/job/node-test-commit-linux-containered/8272/ |
targos
added a commit
that referenced
this pull request
Nov 2, 2018
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 2, 2018
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-11-02, Version 11.1.0 (Current), @targos
Notable changes
Commits
2c2e2b53ab] - benchmark: fix bench-mkdirp to use recursive option (Klaus Meinhardt) #23699787e13b41c] - build: expose more openssl categories for addons (Jonathan Cardoso Machado) #23344b8f3bb107e] - build: add lint-py which uses flake8 (cclauss) #2195235c3c4ba68] - build: allow for overwriting of use_openssl_def (Shelley Vohr) #237635c35d0db47] - build,meta: switch to gcc-4.9 on travis (Refael Ackermann) #23778141aec9564] - crypto: add SET_INTEGER_CONSANT macro (Daniel Bevenius) #236874112a10abe] - crypto: strip unwanted space from openssl version (Sam Roberts) #236782cc4f5c923] - deps: patch V8 to 7.0.276.32 (Michaël Zasso) #238510312d8b2cd] - deps: fix shim forv8::Value::IntegerValue()(Anna Henningsen) #238989011db426e] - (SEMVER-MINOR) deps: move more deprecations to V8_DEPRECATED (Anna Henningsen) #23414e5b51cc496] - (SEMVER-MINOR) deps: icu 63.1 bump (CLDR 34) (Steven R. Loomis) #23715ab58439916] - deps: icu: apply workaround patch (Steven R. Loomis) #237643b66a8d893] - deps: fix wrong default for v8 handle zapping (Refael Ackermann) #2380126510fbd8e] - doc: add branding to style guide (Rich Trott) #2396733053ec8d7] - doc: use Node.js instead of Node (Rich Trott) #23967ec009f620c] - doc: revise BUILDING.md (Rich Trott) #23966da494ef889] - doc: clarify fd behaviour with {read,write}File (Sakthipriyan Vairamani (thefourtheye)) #23706539e1233b0] - doc: moved test instructions to BUILDING.md (Kamat, Trivikram) #23949cc65fee1d3] - doc: fix typographical issues (Denis McDonald) #23970ee6b0395f5] - doc: sort markdown refs in errors (Sam Roberts) #23972ee299c7ef1] - doc: remove "idiomatic choice" from queueMicrotask (Rod Vagg) #23885147e5d5792] - doc: document HPE_HEADER_OVERFLOW error (Sam Roberts) #2396324c6a02930] - doc: add documentation for http.IncomingMessage$complete (James M Snell) #2391482ee6c3e47] - doc: remove mailing list (Rich Trott) #2393299fffff6e0] - doc: remove notice of dashes in V8 options (Denys Otrishko) #239038b5339da14] - doc: rename README section for Release Keys (Rich Trott) #23927676875195b] - doc: add note about ABI compatibility (Myles Borins) #22237f01a806276] - doc: add optional callback to socket.end() (Ajido) #2393764c205d9bc] - doc: make example more clarified in cluster.md (ZYSzys) #23931748dbf9778] - doc: simplify valid security issue descriptions (Rich Trott) #23881e241398ef6] - doc: simplify path.basename() on POSIX and Windows (ZYSzys) #2386449b32af5ab] - doc: document nullptr comparisons in style guide (Anna Henningsen) #238050ba49fec12] - doc: remove problematic example from README (Rich Trott) #23817d808d27120] - doc: use Cookie in request.setHeader() examples (Luigi Pinca) #237071baba9b061] - doc: NODE_EXTRA_CA_CERTS is ignored if setuid root (Ben Noordhuis) #23770dd5afbe05f] - doc: add review suggestions to require() (erickwendel) #23605db113a24e0] - doc: document and warn if the ICU version is too old (Steven R. Loomis) #23766c30de85ca5] - doc: move @phillipj to emeriti (Phillip Johnsen) #2379084fdb1cc0e] - doc: add note about removeListener order (James M Snell) #23762f4c4b2b41b] - doc: document ACL limitation for fs.access on Windows (James M Snell) #2377283b776c864] - doc: document that addMembership must be called once in a cluster (James M Snell) #237461851cf4f83] - doc, test: document and test vm timeout escapes (James M Snell) #23743b4b101fed6] - (SEMVER-MINOR) fs: default open/openSync flags argument to 'r' (Ben Noordhuis) #237671c5ffb3ec5] - (SEMVER-MINOR) lib: add escapeCodeTimeout as an option to createInterface (Raoof) #197801cda41b7da] - lib: migrate from process.binding('config') to getOptions() (Vladimir Ilic) #2358822cd53791a] - lib: trigger uncaught exception handler for microtasks (Gus Caplan) #2379497496f0fd9] - n-api: make per-Context-ness ofnapi\_envexplicit (Anna Henningsen) #236893e512f1897] - os: fix memory leak inuserInfo()(Anna Henningsen) #2389302f13abde3] - repl: support top-level for-await-of (Shelley Vohr) #2384186cf01404c] - repl: migrate from process.binding('config') to getOptions() (Jose Bucio) #236844a79b2568f] - src: improve StreamBase write throughput (Anna Henningsen) #23843dcaf72311b] - src: minor refactor to node_errors.h (Anna Henningsen) #23879fef17b716d] - src: avoid extraPersistentinDefaultTriggerAsyncIdScope(Anna Henningsen) #23844ce106df728] - src: use maybe version v8::Function::Call (Ouyang Yadong) #238261bdbf8765d] - src: reduce duplication in tcp_wrap Connect (Daniel Bevenius) #237539fbe91a061] - src: refactor deprecated v8::String::NewFromTwoByte call (Romain Lanz) #2380348ed81fad2] - src: improve StreamBase read throughput (Anna Henningsen) #23797a6fe2caaae] - src: simplifyTimerFunctionCall()innode\_perf.cc(Anna Henningsen) #2378230be5cbdb0] - src: memory management using smart pointer (Uttam Pawar) #23628df05ddfd72] - src: refactor deprecated v8::Function::Call call (Romain Lanz) #238047bbc072529] - stream: do not error async iterators on destroy(null) (Matteo Collina) #239015ce3b6d7a4] - stream: ended streams should resolve the async iteration (Matteo Collina) #23901aaddf97d9b] - stream: async iteration should work with destroyed stream (Matteo Collina) #23785871e32789a] - test: fixed error message in test-buffer-read (Arvind Pandey) #23957ed10a91e83] - test: add test-benchmark-http2 (Rich Trott) #2386322bbece323] - test: fix regression when compiled with FIPS (Adam Majer) #2387122caa26c69] - test: fix strictEqual() argument order (Loic) #23829572ea60378] - test: verifyperformance.timerify()works w/ non-Node Contexts (Anna Henningsen) #237840f00ac9c7a] - test: mark test-vm-timeout-* known issue tests flaky (James M Snell) #23743a80452a1ab] - test: add test-benchmark-napi (Emily Marigold Klassen) #23585086ee5e57f] - test: increase coverage of internal/stream/end-of-stream (Tyler Vann-Campbell) #23751ee8fa528e2] - test: fix strictEqual() arguments order (Nolan Rigo) #2380083ddd3e7d0] - test: fix flaky test (cjihrig) #238111521d8991d] - test: fix invalid modulesLength for DSA keygen (Adam Majer) #23732dfecf85ded] - test: fix test-require-symlink on Windows (Bartosz Sosnowski) #23691ddd9ccf1d8] - test: fix strictEqual() argument order (Romain Lanz) #23768a666d3ea24] - test: fix strictEqual() arguments order (Thomas GENTILHOMME) #23771fa1373fc74] - test: fix assertion arguments order (Elian Gutierrez) #23787167e99b9a1] - timers: fix priority queue removeAt fn (Anatoli Papirovski) #2387009f25af16f] - tls: throw if protocol too long (Andre Jodat-Danbrani) #2360645a20a8d78] - tools: update ESLint to 5.8.0 (cjihrig) #23904c20eb4f2bd] - (SEMVER-MINOR) tools, icu: actually failover if there are multiple URLs (Steven R. Loomis) #23715b07cb4810c] - zlib: do not leak on destroy (Mathias Buus) #23734