Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code property added for rangeError #23968

Closed
wants to merge 1 commit into from
Closed

code property added for rangeError #23968

wants to merge 1 commit into from
+13 −5

Conversation

mritunjayz
Copy link
Contributor

Checklist

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 30, 2018
@Trott
Copy link
Member

Trott commented Oct 31, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18257/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2018
@AyushG3112
Copy link
Contributor

Typo in commit message: rangrError -> RangeError

@mritunjayz mritunjayz changed the title code property added for rangrError code property added for rangeError Oct 31, 2018
@Trott
Copy link
Member

Trott commented Oct 31, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18267/

@mritunjayz
Copy link
Contributor Author

mritunjayz commented Nov 1, 2018 •
edited

1 failing test ? @Trott

@Trott
Copy link
Member

Trott commented Nov 2, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18286/

@Trott
Copy link
Member

Trott commented Nov 2, 2018

Landed in a6e836a

@Trott Trott closed this Nov 2, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 2, 2018
@mritunjayz @Trott
test: add property for RangeError in test-buffer-copy
a6e836a 
PR-URL: nodejs#23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 2, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Nov 2, 2018
@mritunjayz @targos
test: add property for RangeError in test-buffer-copy
dccf4a6 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@mritunjayz @MylesBorins
test: add property for RangeError in test-buffer-copy
a15de48 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@mritunjayz @MylesBorins
test: add property for RangeError in test-buffer-copy
ce83d60 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@mritunjayz @rvagg
test: add property for RangeError in test-buffer-copy
6ae07a9 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@mritunjayz @rvagg
test: add property for RangeError in test-buffer-copy
5177cee 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@mritunjayz @MylesBorins
test: add property for RangeError in test-buffer-copy
0ed9aaa 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@mritunjayz @MylesBorins
test: add property for RangeError in test-buffer-copy
1d6dd96 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mritunjayz @Trott @AyushG3112 @jasnell @lpinca @cjihrig @trivikr @MylesBorins @nodejs-github-bot