test: update test case in test-net-internal.js

[leeight]

Add test code for makeSyncWrite, which improve
test/parallel/test-net-internal.js test coverage to 100%

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[lpinca]

CI: https://ci.nodejs.org/job/node-test-pull-request/18740/

[danbev]

Re-run of failing node-test-commit-windows-fanned.
Re-run of failing node-test-commit-custom-suites-freestyle

[leeight]

@danbev The testcase crashed on windows, so i skip it.

[danbev]

Re-run of CI: https://ci.nodejs.org/job/node-test-pull-request/18898/.

[leeight]

@danbev Travis CI failed due to

https://api.github.com/repos/nodejs/node/commits/ae69291115e6f8641956346b094d4cbc0cdea134
/home/travis/.npm/_npx/4528/lib/node_modules/core-validate-commit/bin/cmd.js:145
      if (err) throw err
               ^
Error: Invalid api format
    at new Parser (/home/travis/.npm/_npx/4528/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-base/index.js:23:15)
    at new Parser (/home/travis/.npm/_npx/4528/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-node/index.js:15:5)
    at ValidateCommit.lint (/home/travis/.npm/_npx/4528/lib/node_modules/core-validate-commit/lib/index.js:49:22)
    at load (/home/travis/.npm/_npx/4528/lib/node_modules/core-validate-commit/bin/cmd.js:146:9)
    at IncomingMessage.res.on (/home/travis/.npm/_npx/4528/lib/node_modules/core-validate-commit/bin/cmd.js:77:9)
    at IncomingMessage.emit (events.js:187:15)
    at endReadableNT (_stream_readable.js:1098:12)
    at process.internalTickCallback (internal/process/next_tick.js:72:19)
The command "if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST}; fi" exited with 1.

[danbev]

@leeight Would you be able to rebase this PR? Doing should take care of the issue we are seeing with Travis. Thanks

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/19116/

[BridgeAR]

This tests internal APIs by directly accessing it. It should be possible to write the test with public facing APIs only. This is a Windows specific code, so it can only be triggered there and we do not run our regular coverage on Windows either. I don't think this should land as is.

[gireeshpunathil]

ping @leeight - can you address the review comments?

[HarshithaKP]

I will pick this up.

[HarshithaKP]

#31851 removed the api isLegalPort. Part of that, the test was removed it looks like - because the test was testing that API.

[jasnell]

Closing due to lack of continued activity. Can reopen if someone wishes to pick this up again