Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x backport] doc: sort markdown refs in errors #24678

Closed

Commits on Nov 29, 2018

  1. build: configure default v8_optimized_debug

    Under the assumption that debugging is more often focused on node core
    source. This setting compiles V8 with only partial optimizations,
    DCHECKS, and debug symbols, so it is still very much debuggable,
    but it is much faster.
    
    It does disable SLOW_DCHECKS, but at the advice of the V8 team, those
    are more important for deep V8 debugging.
    
    Override is configurable with `./configure --v8-non-optimized-debug`.
    
    PR-URL: nodejs#23704
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    refack authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    24dd67f View commit details
    Browse the repository at this point in the history
  2. deps,v8: fix gypfile bug

    PR-URL: nodejs#23704
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    refack authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    c9ecaef View commit details
    Browse the repository at this point in the history
  3. build: add -Werror=undefined-inline to clang builds

    PR-URL: nodejs#23961
    Refs: nodejs#23954
    Refs: nodejs#23910
    Refs: nodejs#23880
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    refack authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    a1b5643 View commit details
    Browse the repository at this point in the history
  4. src: fix fully-static & large-pages combination

    Fixes: nodejs#23906
    Refs: nodejs#22079
    
    This change to ld.implicit.script moves libc static code to
    .lpstub area and avoids the issue detailed in 23906
    
    Quick performance comparision on web-tooling shows 3%
    improvement for the combination over fully-static
    
    cycles                       376,235,487,455  390,007,877,315
    instructions                 700,341,146,973  714,773,201,182
    itlb_misses_walk_completed        20,654,246       28,908,381
    itlb_misses_walk_completed_4k     19,884,666       28,865,118
    itlb_misses_walk_completed_2m_4m     769,391           43,251
    Score                                   9.13             8.86
    
    PR-URL: nodejs#23964
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    suresh-srinivas authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    6f249bc View commit details
    Browse the repository at this point in the history
  5. build: make benchmark/napi all prereq order-only

    This commit makes the all prerequisites order-only to prevent this
    target's rules to be executed every time which is currently the case as
    the all target is a phony target and will be executed every time.
    
    PR-URL: nodejs#23951
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    danbev authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    cc72b2a View commit details
    Browse the repository at this point in the history
  6. doc: add types and their corresponding return values

    This commit supplements some types and their corresponding return
    values in docs, including `AsyncResource`, `DiffieHellman`,
    `ECDH`, `https.Server`, `repl.REPLServer`.
    
    PR-URL: nodejs#23998
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    oyyd authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    9be73ea View commit details
    Browse the repository at this point in the history
  7. doc: improve BUILDING.md

    PR-URL: nodejs#23976
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Jagannath Bhat authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    f1f1ae4 View commit details
    Browse the repository at this point in the history
  8. doc: improve COLLABORATOR_GUIDE

    PR-URL: nodejs#23977
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Jagannath Bhat authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    00c0539 View commit details
    Browse the repository at this point in the history
  9. test: fix test-fs-watch-system-limit

    On some systems the default inotify limits might be too high for the
    test to actually fail. Detect and skip the test in such environments.
    
    PR-URL: nodejs#23986
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ofrobots authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    0ca3646 View commit details
    Browse the repository at this point in the history
  10. child_process: handle undefined/null for fork() args

    PR-URL: nodejs#22416
    Fixes: nodejs#20749
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    shobhitchittora authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    db4f92d View commit details
    Browse the repository at this point in the history
  11. test: add property for RangeError in test-buffer-copy

    PR-URL: nodejs#23968
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    mritunjayz authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    0ed9aaa View commit details
    Browse the repository at this point in the history
  12. test: fix strictEqual arguments order

    PR-URL: nodejs#23956
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Westixy authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    e0902c8 View commit details
    Browse the repository at this point in the history
  13. test: assert that invalidcmd throws error code

    Update invalidcmd test case in test-child-process-spawn-typeerror to
    assert on specific expected error code.
    
    PR-URL: nodejs#23942
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jeromecovington authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    3c314d1 View commit details
    Browse the repository at this point in the history
  14. tools: update alternative docs versions

    Add `11.x` and mark `10.x` as `lts`.
    
    PR-URL: nodejs#23980
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    richardlau authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    add267b View commit details
    Browse the repository at this point in the history
  15. doc: revise CHANGELOG.md text

    Make the text shorter and clearer.
    
    PR-URL: nodejs#23988
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    559ce1c View commit details
    Browse the repository at this point in the history
  16. doc: simplify CODE_OF_CONDUCT.md

    PR-URL: nodejs#23989
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    1956800 View commit details
    Browse the repository at this point in the history
  17. doc: revise COLLABORATOR_GUIDE.md

    Simplify text/content.
    
    PR-URL: nodejs#23990
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    e8e5926 View commit details
    Browse the repository at this point in the history
  18. doc: address bits of proof reading work

    PR-URL: nodejs#23978
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Jagannath Bhat authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    0c923cf View commit details
    Browse the repository at this point in the history
  19. doc: fix dublication in net.createServer() docs

    PR-URL: nodejs#24026
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    prog1dev authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    579bcd1 View commit details
    Browse the repository at this point in the history
  20. deps: cherry-pick 2987946 from upstream V8

    Original commit message:
    
        Stop manual unescaping of script source data when preprocessing logs.
    
        It appears that the fields are already being unescaped elsewhere,
        perhaps by the JSON writer. So if we unescape when adding the source
        filename and contents, unescaping will happen again later and plain
        backslashes will be interpreted as escape codes.
    
        Bug: v8:6240
        Change-Id: Ic66b9017ae685d6dd12944ee8d254991e26fbd32
        Reviewed-on: https://chromium-review.googlesource.com/1186625
        Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
        Commit-Queue: Bret Sepulveda <bsep@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#55401}
    
    Refs: v8/v8@2987946
    
    PR-URL: nodejs#24555
    Fixes: nodejs#20891
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
    refack authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    24a5c56 View commit details
    Browse the repository at this point in the history
  21. build: only check REPLACEME & DEP...X for releases

    PR-URL: nodejs#24575
    Refs: nodejs#24551
    Refs: nodejs#12958
    Refs: nodejs#12957
    Refs: nodejs#8325
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    rvagg authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    d9e10fb View commit details
    Browse the repository at this point in the history
  22. test: increase --stack_size test-async-wrap-pop

    Currently, when building with --debug
    test-async-wrap-pop-id-during-load fails on macosx with the following
    error:
    
    $ out/Debug/node test/parallel/test-async-wrap-pop-id-during-load.js
    assert.js:86
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: EXIT CODE: 1, STDERR:
    internal/bootstrap/loaders.js:275
          const script = new ContextifyScript(
                         ^
    
    RangeError: Maximum call stack size exceeded
        at NativeModule.compile (internal/bootstrap/loaders.js:275:22)
        at NativeModule.require (internal/bootstrap/loaders.js:168:18)
        at assert.js:31:43
        at NativeModule.compile (internal/bootstrap/loaders.js:299:7)
        at NativeModule.require (internal/bootstrap/loaders.js:168:18)
        at internal/process/main_thread_only.js:23:16
        at NativeModule.compile (internal/bootstrap/loaders.js:299:7)
        at Function.NativeModule.require
          (internal/bootstrap/loaders.js:168:18)
        at startup (internal/bootstrap/node.js:58:38)
        at bootstrapNodeJSCore (internal/bootstrap/node.js:878:3)
    
        at Object.<anonymous>
           (/node/test/parallel/test-async-wrap-pop-id-during-load.js:21:8)
        at Module._compile (internal/modules/cjs/loader.js:707:30)
        at Object.Module._extensions..js
          (internal/modules/cjs/loader.js:718:10)
        at Module.load (internal/modules/cjs/loader.js:605:32)
        at tryModuleLoad (internal/modules/cjs/loader.js:544:12)
        at Function.Module._load (internal/modules/cjs/loader.js:536:3)
        at Function.Module.runMain (internal/modules/cjs/loader.js:760:12)
        at startup (internal/bootstrap/node.js:308:19)
        at bootstrapNodeJSCore (internal/bootstrap/node.js:878:3)
    
    This commit suggests increasing the stack_size to 80.
    
    Refs: nodejs#20940
    PR-URL: nodejs#23996
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    danbev authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    17eaf1b View commit details
    Browse the repository at this point in the history
  23. fs: handle result of access binding directly in fs.existsSync

    Instead of throwing errors in fs.accessSync and then catching it,
    handle the result from the binding directly in fs.existsSync.
    
    Note that the argument validation errors still needs to be caught
    until we properly deprecate the don't-thrown-on-invalid-arguments
    behavior.
    
    PR-URL: nodejs#24015
    Fixes: nodejs#24008
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    joyeecheung authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    00badcb View commit details
    Browse the repository at this point in the history
  24. n-api: add missing handle scopes

    Currently when building with --debug
    test/addons-napi/test_threadsafe_function will error:
    
    $  out/Debug/node test/addons-napi/test_threadsafe_function/test.js
    FATAL ERROR: v8::HandleScope::CreateHandle()
      Cannot create a handle without a HandleScope
     1: 0x10004e287 node::DumpBacktrace(__sFILE*) [node/out/Debug/node]
     2: 0x1000cd37b node::Abort() [/node/out/Debug/node]
     3: 0x1000cd69f node::OnFatalError(char const*, char const*)
        [/node/out/Debug/node]
     4: 0x1004df0b1 v8::Utils::ReportApiFailure(char const*, char const*)
        [/nodejs/node/out/Debug/node]
     5: 0x100a8c0a9 v8::internal::HandleScope::Extend(
            v8::internal::Isolate*)
        [/node/out/Debug/node]
     6: 0x1004e4229 v8::EmbedderDataFor(v8::Context*,
                                        int, bool,
                                        char const*)
        [/node/out/Debug/node]
     7: 0x1004e43fa v8::Context::SlowGetAlignedPointerFromEmbedderData(int)
        [/node/out/Debug/node]
     8: 0x10001c26b v8::Context::GetAlignedPointerFromEmbedderData(int)
        [/node/out/Debug/node]
     9: 0x1000144ea node::Environment::GetCurrent(v8::Local<v8::Context>)
        [/node/out/Debug/node]
    10: 0x1000f49e2 napi_env__::node_env() const
        [/node/out/Debug/node]
    11: 0x1000f9885
        (anonymous namespace)::v8impl::ThreadSafeFunction::
            CloseHandlesAndMaybeDelete(bool)
        [/node/out/Debug/node]
    12: 0x1000fb34f (anonymous namespace)::v8impl::ThreadSafeFunction::
            DispatchOne()
        [/node/out/Debug/node]
    13: 0x1000fb129
        (anonymous namespace)::v8impl::ThreadSafeFunction::
            IdleCb(uv_idle_s*)
        [/node/out/Debug/node]
    14: 0x1011a1b69 uv__run_idle
        [/node/out/Debug/node]
    15: 0x101198179 uv_run
        [/node/out/Debug/node]
    16: 0x1000dfca1
        node::Start(...)
        [/node/out/Debug/node]
    17: 0x1000dae50 node::Start(...)
        [/node/out/Debug/node]
    18: 0x1000da56f node::Start(int, char**)
        [/node/out/Debug/node]
    19: 0x10141112e main
        [/node/out/Debug/node]
    20: 0x100001034 start
        [/node/out/Debug/node]
    Abort trap: 6
    
    This commit adds two HandleScope's, one to CloseHandlesAndMaybeDelete
    and one to the lambda.
    
    SlowGetAlignedPointerFromEmbedderData will only be called for debug
    builds:
    https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733
    /include/v8.h#L10440-L10447
    
    PR-URL: nodejs#24011
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    danbev authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    06844e8 View commit details
    Browse the repository at this point in the history
  25. repl: use promise#finally

    PR-URL: nodejs#23971
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    starkwang authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    e5177e9 View commit details
    Browse the repository at this point in the history
  26. doc: edit man page for superfluous "node" usage

    Rather than ponder "node" vs. "Node.js", remove the descriptor so it's
    just "command-line options" rather than "node command-line options" or
    "Node.js command-line options".
    
    PR-URL: nodejs#24029
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    7f0c3bb View commit details
    Browse the repository at this point in the history
  27. doc: add SECURITY.md to readme.md

    This adds a SECURITY.md file and links to the security document per the
    request of @https://github.com/Trott at a recent SF Node meetup.
    
    PR-URL: nodejs#24031
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    warnerp18 authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    4fb93d1 View commit details
    Browse the repository at this point in the history
  28. doc: fix socket.connecting description

    In particular, this value is `true` and not `false`
    between calling `connect()` and the operation finishing.
    
    PR-URL: nodejs#24066
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    40c3752 View commit details
    Browse the repository at this point in the history
  29. tools: add script to lint first PR commit message

    Decouple first commit in pull request linting from Travis by using
    the GitHub API to work out the first commit.
    
    The shell script obtains the pull request number in one of the
    following ways:
     1) supplied on the command line (use this to test against any PR)
     2) derived from the HEAD commit via the GitHub API
    
    PR-URL: nodejs#24030
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    0ad9103 View commit details
    Browse the repository at this point in the history
  30. doc: correct link to test coverage command

    PR-URL: nodejs#24049
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mritunjayz authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    f6a48d6 View commit details
    Browse the repository at this point in the history
  31. doc: add missing comma in net documentation

    PR-URL: nodejs#24074
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    aebd6d9 View commit details
    Browse the repository at this point in the history
  32. build: do not lint on non-PR Travis builds

    Do not run any linting at all when `TRAVIS_PULL_REQUEST` is `false`.
    This would otherwise break Travis CI for `master` and release branches.
    
    Refs: nodejs#24030
    
    PR-URL: nodejs#24076
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    9b55b90 View commit details
    Browse the repository at this point in the history
  33. build: fix Travis non-PR builds

    Don't return non-zero if TRAVIS_PULL_REQUEST == "false".
    
    PR-URL: nodejs#24093
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    b09f94c View commit details
    Browse the repository at this point in the history
  34. doc: add table of contents to release guide

    Also move Announce step to after technical stuff.
    
    PR-URL: nodejs#24042
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    a23ab00 View commit details
    Browse the repository at this point in the history
  35. doc: streamline CONTRIBUTING.md

    PR-URL: nodejs#24010
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    3afde80 View commit details
    Browse the repository at this point in the history
  36. meta,doc: ping community about new release

    PR-URL: nodejs#24064
    Refs: http://logs.libuv.org/node-build/2018-11-03#16:44:59.388
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    refack authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    a93a1df View commit details
    Browse the repository at this point in the history
  37. lib: move module exports proxy into a separate method

    Also added the comment in f074612 to make
    NativeModule.prototype.compile() more readable.
    
    PR-URL: nodejs#24057
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    joyeecheung authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    4cb822e View commit details
    Browse the repository at this point in the history
  38. net: net.Server.listen() avoid operations on null when fail

    When `net.Server` fails to create a new handle, an error shall be
    emitted in the next tick. Therefore, we make `net.Server.listen()`
    directly  return to avoid following operations on `null`
    `this._handle`.
    
    Fixes: nodejs#23917
    
    PR-URL: nodejs#23920
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    oyyd authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    cc82efa View commit details
    Browse the repository at this point in the history
  39. lib:fix grammar error and make it clearer for comments

    1) Should be passive voice instead of `can overridden`.
    2) Change the order of the two sentences to make it more clear about
    'What can be overridden' instead of 'Can be overridden'.
    
    PR-URL: nodejs#23799
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MaleDong authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    bb4c086 View commit details
    Browse the repository at this point in the history
  40. test: add crypto check to test-benchmark-http2

    Currently, this test will fail when configured --without-ssl. This
    commit adds a crypto check to have this test skipped when configured
    without crypto support.
    
    PR-URL: nodejs#24096
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    danbev authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    d30e573 View commit details
    Browse the repository at this point in the history
  41. doc: fix minor text issues in stream.md

    Implement several minor grammar, punctuation, and style fixes in
    stream.md.
    
    PR-URL: nodejs#24116
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    290796f View commit details
    Browse the repository at this point in the history
  42. doc: inspector security warning for changing host

    Refs: nodejs#23444
    Refs: nodejs#21774
    
    PR-URL: nodejs#23640
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    ChALkeR authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    a77dc9a View commit details
    Browse the repository at this point in the history
  43. vm: clarify timeout option in vm

    This updates the documentation
    to clarify how to use `timeout`
    in the vm module.
    
    PR-URL: nodejs#23512
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    vdeturckheim authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    3999710 View commit details
    Browse the repository at this point in the history
  44. doc: implement minor text fixes to path.md

    posix -> POSIX
    platform specific -> platform-specific
    
    PR-URL: nodejs#24118
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    45a3278 View commit details
    Browse the repository at this point in the history
  45. deps: remove old c-ares configure files

    Remove leftover files that were added in commit 58e4eda from 2013
    to help with standalone builds of the c-ares fork that we maintained
    at the time.
    
    PR-URL: nodejs#23854
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    bnoordhuis authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    4eaab7c View commit details
    Browse the repository at this point in the history
  46. deps: upgrade to c-ares v1.15.0

    Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
    fec0 prefix") should no longer be necessary, c-ares now blacklists such
    addresses itself.
    
    PR-URL: nodejs#23854
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    bnoordhuis authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    209b1d5 View commit details
    Browse the repository at this point in the history
  47. deps: c-ares float, version number patch

    Not yet upstream.
    
    Refs: c-ares/c-ares#229
    
    PR-URL: nodejs#23854
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    bnoordhuis authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    d89bae8 View commit details
    Browse the repository at this point in the history
  48. build,meta: don't fail Travis for commit message

    PR-URL: nodejs#23739
    Fixes: nodejs#23737
    Refs: nodejs#22452
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    refack authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    61458c4 View commit details
    Browse the repository at this point in the history
  49. doc: add shisama to collaborators

    PR-URL: nodejs#24136
    Fixes: nodejs#23850
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Masashi Hirano authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    f80423b View commit details
    Browse the repository at this point in the history
  50. build: use latest node on travis

    PR-URL: nodejs#24198
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    cjihrig authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    2983df8 View commit details
    Browse the repository at this point in the history
  51. doc: add psmarshall to collaborators

    PR-URL: nodejs#24170
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    psmarshall authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    d242a66 View commit details
    Browse the repository at this point in the history
  52. test: disable color formating for test-internal-errors.js

    PR-URL: nodejs#24204
    Fixes: nodejs#24193
    Refs: nodejs#19723
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    refack authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    f20bf8c View commit details
    Browse the repository at this point in the history
  53. doc: update System Errors documentation

    Simplify text. Add explanation that `code` is the most stable way to
    identify an error, in contrast with `message` which is subject to change
    between patch-level versions of Node.js. Synchronize list of properties
    with text. Order properties alphabetically.
    
    PR-URL: nodejs#24090
    Fixes: nodejs#23975
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    3102bce View commit details
    Browse the repository at this point in the history
  54. doc: add text about error.code stability

    Fixes: nodejs#23975
    
    PR-URL: nodejs#24090
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    c4e34cc View commit details
    Browse the repository at this point in the history
  55. doc: wrap GOVERNANCE.md at 80 characters

    This is in preparation for a markdown lint rule requiring lines to be
    wrapped at 80 characters.
    
    PR-URL: nodejs#24094
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    0e121bf View commit details
    Browse the repository at this point in the history
  56. tools: enable 80-char line length markdown linting

    PR-URL: nodejs#24094
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    2015712 View commit details
    Browse the repository at this point in the history
  57. doc: fix linting errors

    PR-URL: nodejs#24229
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    cjihrig authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    219040d View commit details
    Browse the repository at this point in the history
  58. src: prefer param function check over args length

    PR-URL: nodejs#23835
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    codebytere authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    a273da9 View commit details
    Browse the repository at this point in the history
  59. build: change repo to https protocol in Makefile

    PR-URL: nodejs#24073
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    mritunjayz authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    6936060 View commit details
    Browse the repository at this point in the history
  60. doc: sort markdown refs in errors

    Backport-PR-URL: nodejs#24678
    PR-URL: nodejs#23972
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    sam-github committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    4cc8ec2 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. Configuration menu
    Copy the full SHA
    2a9f701 View commit details
    Browse the repository at this point in the history