Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] doc: sort bottom-of-file markdown links #24682

Closed

Conversation

sam-github
Copy link
Contributor

Backport of #24679

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@sam-github sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v8.x labels Nov 27, 2018
@sam-github sam-github changed the title doc: sort bottom-of-file markdown links [v8.x backport] doc: sort bottom-of-file markdown links Nov 27, 2018
@vsemozhetbyt
Copy link
Contributor

Does this need rebasing?

@sam-github
Copy link
Contributor Author

PTAL

doc/api/cluster.md Outdated Show resolved Hide resolved
doc/api/tls.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With 2 nits.

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@sam-github
Copy link
Contributor Author

@sam-github
Copy link
Contributor Author

@nodejs/lts can you merge this to staging before it collects more conflicts? pls.

rvagg pushed a commit that referenced this pull request Dec 1, 2018
Backport of #24679

PR-URL: #24682
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@rvagg
Copy link
Member

rvagg commented Dec 1, 2018

👍 done ffe1f80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants