Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify order of error in h2 server stream #24685

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 43 additions & 0 deletions test/parallel/test-http2-error-order.js
@@ -0,0 +1,43 @@
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

const assert = require('assert');
const { createServer, connect } = require('http2');

const messages = [];
const expected = [
'Stream:created',
'Stream:error',
'Stream:close',
'Request:error'
];

const server = createServer();

server.on('stream', (stream) => {
messages.push('Stream:created');
stream
.on('close', () => messages.push('Stream:close'))
.on('error', (err) => messages.push('Stream:error'))
.respondWithFile('dont exist');
});

server.listen(8000);
MylesBorins marked this conversation as resolved.
Show resolved Hide resolved

const client = connect('http://localhost:8000');
const req = client.request();

req.on('response', common.mustNotCall());

req.on('error', () => {
messages.push('Request:error');
client.close();
});

client.on('close', () => {
MylesBorins marked this conversation as resolved.
Show resolved Hide resolved
assert.deepStrictEqual(messages, expected);
server.close();
});