Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_parser: fix error return in Finish() #24738

Closed
wants to merge 3 commits into from
Closed

http_parser: fix error return in Finish() #24738

wants to merge 3 commits into from

Commits on Nov 30, 2018

  1. http: fix error return in Finish() 

    `http_parser_execute(..., nullptr, 0)` returns either `0` or `1`. The
expectation is that no error must be returned if it is `0`, and if
it is `1` - a `Error` object must be returned back to user.

The introduction of `llhttp` and the refactor that happened during it
accidentally removed the error-returning code. This commit reverts it
back to its original state.

Fix: nodejs#24585
    @indutny
    indutny committed Nov 30, 2018
    Copy the full SHA
    95bd7b2 View commit details
    Browse the repository at this point in the history

  2. test: add test

    @indutny
    indutny committed Nov 30, 2018
    Copy the full SHA
    12f9b6a View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2018

  1. fix nit

    @indutny
    indutny committed Dec 2, 2018
    Copy the full SHA
    dc7beec View commit details
    Browse the repository at this point in the history