doc: fix http.createServer for versions before v9.6.0 #24856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Trott
requested changes
Dec 5, 2018
There was a problem hiding this comment.
Hi, @aautio! Welcome, and thanks for the pull request!
You don't want to remove this documentation from the master branch. It is correct on master! This change needs to be targeted at the v8.x-staging branch instead. Would you mind doing that? You'll probably need to close this and open a new PR (I think).
Trott
reviewed
Dec 5, 2018
| The `requestListener` is a function which is automatically | ||
| added to the [`'request'`][] event. | ||
|
|
||
| ## http.createServer([options][, requestListener]) |
There was a problem hiding this comment.
On 8.x-staging, you'll need to remove this stuff too. This function signature doesn't work on 8.x, which is what this doc change is fixing.
|
@Trott thanks for the quick feedback! I'll switch branch and submit a new pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24105
Checklist