Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-cli-node-options flaky on arm #25032

Closed
wants to merge 1 commit into from
Closed

test: mark test-cli-node-options flaky on arm #25032

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 14, 2018

Collaborators, 馃憤 here to fast-track.

Refs: #25028

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 14, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1942/pipeline

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19507/

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19519/

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018 •
edited

ARM failure was a different pair of tests that I believe is infra-related. Affected host as been taken offline. Rebuild: https://ci.nodejs.org/job/node-test-commit-arm/20816/ 鉁旓笍

Rest of CI is good, so if that passes, this can land.

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

Landed in adf5083

@Trott Trott closed this Dec 14, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@Trott
test: mark test-cli-node-options flaky on arm
adf5083 
Refs: nodejs#25028

PR-URL: nodejs#25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@Trott @BethGriggs
test: mark test-cli-node-options flaky on arm
9bd4267 
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: mark test-cli-node-options flaky on arm
f0e8843 
Refs: nodejs#25028

PR-URL: nodejs#25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 29, 2019
@Trott @MylesBorins
test: mark test-cli-node-options flaky on arm
03e2a82 
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@codebytere codebytere mentioned this pull request Jan 29, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@Trott @codebytere
test: mark test-cli-node-options flaky on arm
2d6e145 
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@Trott @codebytere
test: mark test-cli-node-options flaky on arm
adb5d4f 
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@beevelop beevelop mentioned this pull request Jan 29, 2019
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: mark test-cli-node-options flaky on arm
d4b6643 
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2019
Merged
@Trott Trott deleted the arm-flaky-options branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @nodejs-github-bot @watilde @cjihrig @gireeshpunathil @MylesBorins