Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.x] http: fix regression of binary upgrade response body #25036

Closed
wants to merge 1 commit into from
Closed

[v6.x] http: fix regression of binary upgrade response body #25036

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

See: #24958

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1943/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. v6.x labels Dec 14, 2018
@mcollina
Copy link
Member Author

cc @MylesBorins @nodejs/lts

@mcollina
Copy link
Member Author

mcollina commented Dec 14, 2018 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/19514/ ✔️

@mcollina mcollina changed the title http: fix regression of binary upgrade response body [v6.x] http: fix regression of binary upgrade response body Dec 14, 2018
@lpinca
Copy link
Member

lpinca commented Dec 14, 2018

I think both this and #25037 can be cherry-picked from #25039 once merged no?

@lpinca
Copy link
Member

lpinca commented Dec 14, 2018

Ignore the above comment (#24958 (comment))

@Trott Trott mentioned this pull request Dec 14, 2018
Closed
MylesBorins
MylesBorins approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
8af2553 
See: #24958

PR-URL: #25036
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Member

landed in 8af2553

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
8a3e0c0 
See: #24958

PR-URL: #25036
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2018
Merged
This was referenced Dec 26, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcollina @nodejs-github-bot @lpinca @MylesBorins