Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] update the http.request.setTimeout docs to be accurate #25123

Closed
wants to merge 2 commits into from
Closed

[v8.x] update the http.request.setTimeout docs to be accurate #25123

wants to merge 2 commits into from

Commits on Dec 18, 2018

  1. deps: cherry-pick 525b396 from V8 upstream 

    Original commit message:

    [cpu-profiler] Fix a leak caused by re-logging existing functions.

    Don't re-log all existing functions during StartProcessorIfNotStarted().
    They will already be in the CodeMap attached to the ProfileGenerator and
    re-logging them causes leaks. See the linked bug for more details.

    Bug: v8:8253
    Change-Id: Ibb1a1ab2431c588e8c3a3a9ff714767cdf61a88e
    Reviewed-on: https://chromium-review.googlesource.com/1256763
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56336}

Refs: v8/v8@525b396

PR-URL: nodejs#25041
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @psmarshall @MylesBorins
    psmarshall authored and MylesBorins committed Dec 18, 2018
    Copy the full SHA
    ae24aaf View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. doc: update the http.request.setTimeout docs to be accurate 

    Refs: nodejs#8895
    @jbunton-atlassian
    jbunton-atlassian committed Dec 19, 2018
    Copy the full SHA
    fc173b3 View commit details
    Browse the repository at this point in the history