Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11.6.0 proposal #25175

Merged
merged 59 commits into from Dec 26, 2018
Merged

v11.6.0 proposal #25175

merged 59 commits into from Dec 26, 2018

Commits on Dec 21, 2018

  1. deps: cherry-pick http_parser_set_max_header_size

    This commit adds http_parser_set_max_header_size() to the
    http-parser for overriding the compile time maximum HTTP
    header size.
    
    PR-URL: #24811
    Fixes: #24692
    Refs: nodejs/http-parser#453
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    cjihrig authored and MylesBorins committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    0057af2 View commit details
    Browse the repository at this point in the history
  2. src: add kUInteger parsing

    This commit adds support for uint64_t option parsing.
    
    PR-URL: #24811
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    mcollina authored and MylesBorins committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    c80ac7f View commit details
    Browse the repository at this point in the history
  3. cli: add --max-http-header-size flag

    Allow the maximum size of HTTP headers to be overridden from
    the command line.
    
    co-authored-by: Matteo Collina <hello@matteocollina.com>
    PR-URL: #24811
    Fixes: #24692
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    2 people authored and MylesBorins committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    edd8bd0 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2018

  1. lib: remove unused NativeModule/NativeModule wraps

    We now compile the native modules in C++ so these are no longer
    used.
    
    PR-URL: #24904
    Refs:https://github.com/joyeecheung/node/commit/
    bd765d6
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    joyeecheung authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    0cde1a4 View commit details
    Browse the repository at this point in the history
  2. src: remove internalBinding('config').warningFile

    Instead use `require('internal/options')` lazily. Also refactor the
    call site a bit so that the option is queried only once since it's
    synchronous anyway.
    
    PR-URL: #24959
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joyeecheung authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    7f34c76 View commit details
    Browse the repository at this point in the history
  3. lib: refactor argument validation using validateString

    PR-URL: #24960
    Refs: #22101
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ZYSzys authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    96bdd47 View commit details
    Browse the repository at this point in the history
  4. child_process: spawn ignores options in case args is undefined

    spawn method ignores 3-d argument 'options' in case
    the second one 'args' equals to 'undefined'.
    
    Fixes: #24912
    
    PR-URL: #24913
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    eduardbme authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    7b2eefc View commit details
    Browse the repository at this point in the history
  5. perf_hooks: make GC tracking state per-Environment

    Otherwise this is global state that may be subject to race
    conditions e.g. when running `perf_hooks` inside of Worker threads.
    
    Tracking the GC type is removed entirely since the variable was unused.
    
    PR-URL: #25053
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    85a1369 View commit details
    Browse the repository at this point in the history
  6. vm: simplify Script constructor options validation

    This commit combines two related if statements into an
    if-else statement.
    
    PR-URL: #25054
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    74e08c0 View commit details
    Browse the repository at this point in the history
  7. src: mark some global state as const

    Mark some global variables as `const` or `constexpr`.
    
    PR-URL: #25052
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    09a99c6 View commit details
    Browse the repository at this point in the history
  8. tools: enable no-useless-constructor lint rule

    This commit enables ESLint's no-useless-constructor rule. Note
    that the documentation examples that only include constructor
    calls were left in tact.
    
    PR-URL: #25055
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    ed3303b View commit details
    Browse the repository at this point in the history
  9. test: merge test with unnecessary child process

    Test didn't require child process creation. While this test has not been
    unstable, child process creation is slower and can be flaky in ci, so
    test directly for the segfault regression.
    
    PR-URL: #25025
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    sam-github authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    30b6155 View commit details
    Browse the repository at this point in the history
  10. build: add a space to clarify skipping crypto msg

    This commit adds a space to the message that is displayed for tests that
    are skipped when node was built --without-ssl. For example, this is what
    is currently displayed:
    "release test-https-agent-additional-optionsSkipping as node was
    compiled without crypto support"
    
    After this change this will be:
    "release test-https-agent-additional-options: Skipping as node was
    compiled without crypto support"
    
    PR-URL: #25011
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    danbev authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    4513516 View commit details
    Browse the repository at this point in the history
  11. doc,lib,test: capitalize comment sentences

    This activates the eslint capitalize comment rule for comments
    above 50 characters.
    
    PR-URL: #24996
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    2516e9c View commit details
    Browse the repository at this point in the history
  12. tls: re-define max supported version as 1.2

    Several secureProtocol strings allow any supported TLS version as the
    maximum, but our maximum supported protocol version is TLSv1.2 even if
    someone configures a build against an OpenSSL that supports TLSv1.3.
    
    Fixes: #24658
    
    PR-URL: #25024
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    sam-github authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    e340b8f View commit details
    Browse the repository at this point in the history
  13. src: extract common Bind method

    `TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of
    functionality, so a common `Bind` was extracted to remove duplication.
    
    PR-URL: #22315
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    maclover7 authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    a4505c6 View commit details
    Browse the repository at this point in the history
  14. test: remove magic numbers in test-gc-http-client-onerror

    Remove magic numbers (500, 10, 100) from the test. Instead, detect when
    GC has started and stop sending requests at that point.
    
    On my laptop, this results in 16 or 20 requests per run instead of 500.
    
    Fixes: #23089
    
    PR-URL: #24943
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    9ad6bc2 View commit details
    Browse the repository at this point in the history
  15. process: move environment variable proxy code into node_env_var.cc

    Instead of exposing all the NamedPropertyHandlerConfiguration()
    parameters in node_internals, simply expose a CreateEnvVarProxy()
    method that returns a Local<Value> that implements process.env,
    and mark all the property handlers static in node_env_var.cc.
    This makes the code more encapsulated.
    
    PR-URL: #25067
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    3f82144 View commit details
    Browse the repository at this point in the history
  16. doc: revise "Breaking Changes" section of Collaborator Guide

    Simplify material about TSC approval for breaking changes. Omit
    extraneous material explaining that purely additive changes are not
    breaking changes.
    
    PR-URL: #25071
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    4561e2c View commit details
    Browse the repository at this point in the history
  17. tools: make apilinks building more robust

    1. Move the apilinks.json file into out/doc so it gets cleaned when
      running `make docclean`
    2. When the apilinks.json generated is empty, throw a specific error
      so it's easier to understand what's wrong
    3. Write to a file passed through CLI arguments instead writing to
      stdout in apilinks.js so the build process is more robust in
      the case of a bad binary
    
    PR-URL: #25019
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    a5bccc2 View commit details
    Browse the repository at this point in the history
  18. test: test internal/util/types in vm

    PR-URL: #25056
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ZYSzys authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    5eb5d1d View commit details
    Browse the repository at this point in the history
  19. assert: inspect getters

    While asserting two objects the descriptor is not taken into account.
    Therefore getters will be triggered as such. This makes sure they
    are also highlighted in the error message instead of potentially
    looking identical while the return value of the getter is actually
    different.
    
    PR-URL: #25004
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    BridgeAR authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    a9ab28d View commit details
    Browse the repository at this point in the history
  20. test: add missing tmpdir.refresh() in recently-added test

    Without `tmpdir.refresh()`, the test fails in some situations. This was
    missed because using `test.py` will almost always result in a leftover
    tmpdir lying around that makes the `refresh()` not needed.
    
    Refs: #24913 (comment)
    
    PR-URL: #25098
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Trott authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    3e1fe19 View commit details
    Browse the repository at this point in the history
  21. src: schedule destroy hooks in BeforeExit early during bootstrap

    Instead of doing it in the `internalBinding('async_wrap')`
    initialization whose first call is uncertain depending on how
    the native modules are loaded in JS land during bootstrap.
    
    PR-URL: #25020
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    joyeecheung authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    6f3b421 View commit details
    Browse the repository at this point in the history
  22. test: add signal check to test-esm-cjs-main

    PR-URL: #25073
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    1f45b23 View commit details
    Browse the repository at this point in the history
  23. worker: fix nullptr deref after MessagePort deser failure

    This would previously always have crashed when deserializing
    a `MessagePort` fails, because there was always at least one
    `nullptr` entry in the vector.
    
    PR-URL: #25076
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    addaleax authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    4f28da8 View commit details
    Browse the repository at this point in the history
  24. deps: upgrade to libuv 1.24.1

    PR-URL: #25078
    Fixes: #24521
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    cjihrig authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    155d1d5 View commit details
    Browse the repository at this point in the history
  25. test: verify input flags

    This makes sure all required flags are passed through to the test.
    If that's not the case an error is thrown to inform the user what
    flag is missing.
    
    PR-URL: #24876
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    8279826 View commit details
    Browse the repository at this point in the history
  26. test: remove obsolete eslint comments

    The surrounding code was updated, making these eslint-disable
    comments obsolete.
    
    PR-URL: #25088
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    d09e333 View commit details
    Browse the repository at this point in the history
  27. events: simplify stack compare function

    This simplifies the `longestSeqContainedIn()` logic by checking for
    the first identical occurance of at least three frames instead of
    the longest one.
    It also removes an unused argument.
    
    PR-URL: #24744
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    d1a98a8 View commit details
    Browse the repository at this point in the history
  28. src: handle empty Maybe in uv binding initialize

    This can fail when terminating a Worker that loads
    the `uv` binding at the same time.
    
    Refs: #25061 (comment)
    Fixes: #25134
    PR-URL: #25079
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    c6388ed View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2018

  1. vm: reuse validateString of internal/validators

    PR-URL: #25074
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    ZYSzys authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    7df59f8 View commit details
    Browse the repository at this point in the history
  2. src: mark options parsers as const

    These do not change their contents after being constructed.
    
    PR-URL: #25065
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    fd0361b View commit details
    Browse the repository at this point in the history
  3. src: port GetLoadedLibraries for freebsd

    the dl_iterate_phdr and its associated data structure in Linux
    are fully available in freebsd as well, so opening it up for
    freebsd means just opening up the platform specific identifiers.
    
    Refs: #24825
    
    PR-URL: #25106
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    gireeshpunathil authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    54e42f0 View commit details
    Browse the repository at this point in the history
  4. lib: switch to object spread where possible

    Use the object spread notation instead of using Object.assign.
    It is not only easier to read it is also faster as of V8 6.8.
    
    PR-URL: #25104
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    2fc43fb View commit details
    Browse the repository at this point in the history
  5. http: add maxHeaderSize property

    This commit exposes the value of --max-http-header-size
    as a property of the http module.
    
    PR-URL: #24860
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    ae50f48 View commit details
    Browse the repository at this point in the history
  6. os: use uv_os_gethostname() in hostname()

    This commit changes the C++ implementation of os.hostname()
    to use uv_os_gethostname().
    
    PR-URL: #25111
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    add566e View commit details
    Browse the repository at this point in the history
  7. src: use std::vector for setting up process.execPath

    Use `std::vector` as an RAII-style alternative to allocating
    and deleting raw memory storage.
    
    PR-URL: #25069
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    b801b03 View commit details
    Browse the repository at this point in the history
  8. build: correct fi indentation in Makefile

    PR-URL: #25107
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    danbev authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    9b38bbf View commit details
    Browse the repository at this point in the history
  9. tools: update certdata.txt

    This is the certdata.txt[0] from NSS 3.41, released on 2018-12-03.
    
    This is the version of NSS that will ship in Firefox 65 on 2018-12-11.
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_41_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: #25113
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    sam-github authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    9b941da View commit details
    Browse the repository at this point in the history
  10. crypto: update root certificates

    Update the list of root certificates in src/node_root_certs.h with
    tools/mk-ca-bundle.pl.
    
    Certificates added:
    - GlobalSign Root CA - R6
    - OISTE WISeKey Global Root GC CA
    - GTS Root R1
    - GTS Root R2
    - GTS Root R3
    - GTS Root R4
    - UCA Global G2 Root
    - UCA Extended Validation Root
    - Certigna Root CA
    
    Certificates removed:
    - Visa eCommerce Root
    - TÜRKTRUST Elektronik Sertifika Hizmet Sağlayıcısı H5
    - Certplus Root CA G1
    - Certplus Root CA G2
    - OpenTrust Root CA G1
    - OpenTrust Root CA G2
    - OpenTrust Root CA G3
    
    PR-URL: #25113
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    sam-github authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    6f6f339 View commit details
    Browse the repository at this point in the history
  11. doc: describe root cert update process

    PR-URL: #25113
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    sam-github authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    4ca0951 View commit details
    Browse the repository at this point in the history
  12. doc: revise "Breaking Changes and Deprecations"

    Revise the "Breaking Changes and Deprecations" section of the
    Collaborator Guide. Simplify the text. Remove redundant text. The
    "Deprecations" section is thorough and linked to from this section.
    
    PR-URL: #25116
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Trott authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    6a690ee View commit details
    Browse the repository at this point in the history
  13. test: remove unnecessary eslint-disable comments

    PR-URL: #25119
    Refs: https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    175f7b6 View commit details
    Browse the repository at this point in the history
  14. tools: report unused disable-directives for ESLint

    Refs: https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives
    
    PR-URL: #25119
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    073a512 View commit details
    Browse the repository at this point in the history
  15. lib: make internal API warning more direct

    Before:
    These APIs are exposed only for testing and are not tracked by any
    versioning system or deprecation process.
    
    After:
    These APIs are for internal testing only. Do not use them.
    
    PR-URL: #25125
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    b3f45da View commit details
    Browse the repository at this point in the history
  16. test: add hasCrypto check to common flags check

    Currently, if node is configured --without-ssl there will be a number of
    test errors related to crypto flags:
    
    Error: Test has to be started with the flag: '--tls-v1.1'
    
    This commit adds a hasCrypto check to the flags checking similar to what
    is done for --without-intl.
    
    PR-URL: #25147
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    danbev authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    a28cae0 View commit details
    Browse the repository at this point in the history
  17. test: remove Files: comment processing from Python test runner

    We don't use any Files: comments in our tests so remove the Python code
    for it from test/testpy/__init__.py.
    
    PR-URL: #25183
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    db54531 View commit details
    Browse the repository at this point in the history
  18. buffer: simplify code

    This refactors some code for simplicity. It also removes a call
    indirection used in the buffers custom inspect function.
    
    PR-URL: #25151
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    c6bfa66 View commit details
    Browse the repository at this point in the history
  19. src: add DCHECK macros

    This adds check statements for debugging and refactors the code
    accordingly.
    
    PR-URL: #24359
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    kiyomizumia authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    c9f809e View commit details
    Browse the repository at this point in the history
  20. doc: fix links in test/common/README.md

    PR-URL: #25172
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    vsemozhetbyt authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    b78d487 View commit details
    Browse the repository at this point in the history
  21. crypto: add key object API

    This commit makes multiple important changes:
    
    1. A new key object API is introduced. The KeyObject class itself is
       not exposed to users, instead, several new APIs can be used to
       construct key objects: createSecretKey, createPrivateKey and
       createPublicKey. The new API also allows to convert between
       different key formats, and even though the API itself is not
       compatible to the WebCrypto standard in any way, it makes
       interoperability much simpler.
    
    2. Key objects can be used instead of the raw key material in all
       relevant crypto APIs.
    
    3. The handling of asymmetric keys has been unified and greatly
       improved. Node.js now fully supports both PEM-encoded and
       DER-encoded public and private keys.
    
    4. Conversions between buffers and strings have been moved to native
       code for sensitive data such as symmetric keys due to security
       considerations such as zeroing temporary buffers.
    
    5. For compatibility with older versions of the crypto API, this
       change allows to specify Buffers and strings as the "passphrase"
       option when reading or writing an encoded key. Note that this
       can result in unexpected behavior if the password contains a
       null byte.
    
    PR-URL: #24234
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    3b53df0 View commit details
    Browse the repository at this point in the history
  22. crypto: always accept certificates as public keys

    PR-URL: #24234
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    e6c1e8d View commit details
    Browse the repository at this point in the history
  23. tools: alphabetize IGNORED_SUITES in tools/test.py

    PR-URL: #25182
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    c7fa132 View commit details
    Browse the repository at this point in the history
  24. test: mark test-trace-events-api-worker-disabled flaky

    Refs: #24305
    
    PR-URL: #25197
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    6557ea1 View commit details
    Browse the repository at this point in the history
  25. tools: update ESLint to 5.11.0

    Update ESLint to 5.11.0.
    
    PR-URL: #25191
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    cjihrig authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    8ab0a48 View commit details
    Browse the repository at this point in the history
  26. test: fix test-tls-session-timeout

    Tests in pummel seem to break often and stay broken because they don't
    get run in CI. In preparation for running pummel tests in CI once a day,
    this fixes test-tls-session-timeout. `key` and `cert` are now the
    contents of the relevant files and not the paths.
    
    PR-URL: #25188
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    45d4851 View commit details
    Browse the repository at this point in the history
  27. deps: upgrade npm to 6.5.0

    PR-URL: #24734
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Audrey Eschright authored and MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    e855018 View commit details
    Browse the repository at this point in the history
  28. 2018-12-26, Version 11.6.0 (Current)

    Notable Changes:
    
    * cli:
      - add --max-http-header-size flag (cjihrig)
        #24811
    * crypto:
      - always accept certificates as public keys (Tobias Nießen)
        #24234
      - add key object API (Tobias Nießen) [#24234](#24234)
      - update root certificates (Sam Roberts)
        #25113
    * deps:
      - upgrade to libuv 1.24.1 (cjihrig)
        #25078
      - upgrade npm to 6.5.0 (Audrey Eschright)
        #24734
    * http:
      - add maxHeaderSize property (cjihrig)
        #24860
    
    PR-URL: #25175
    MylesBorins committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    968e901 View commit details
    Browse the repository at this point in the history