src: remove redefinition of DCHECK_LT #25206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 71bc7e1, the DCHECK_LT macro is defined unconditionally in util.h, making the definition in inspector/node_string.h generate a compiler warning. This commit removes the redefinition.
nodejs-github-bot
added
the
c++
benjamingr
approved these changes
Dec 25, 2018
lpinca
approved these changes
Dec 25, 2018
|
This is no longer needed since #25207 landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 71bc7e1, the
DCHECK_LTmacro is defined unconditionally inutil.h, making the definition ininspector/node_string.hgenerate a compiler warning. This commit removes the redefinition.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes