Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-repl-envvars #25226

Closed
wants to merge 1 commit into from

Commits on Dec 26, 2018

  1. test: fix test-repl-envvars

    In 180f865, the test was changed
    so that the `env` argument of `createInternalRepl()` also contained
    external environment variables, because keeping them can be necessary
    for spawning processes on some systems.
    
    However, this test does not spawn new processes, and relies on the
    fact that the environment variables it tests are not already set
    (and fails otherwise); therefore, reverting to the original state
    should fix this.
    
    Fixes: nodejs#21451
    Fixes: nodejs/build#1377
    Refs: nodejs#25219
    addaleax committed Dec 26, 2018
    Copy the full SHA
    1f02e58 View commit details
    Browse the repository at this point in the history