v11.7.0 proposal #25537
Merged
v11.7.0 proposal #25537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 180f865, the test was changed so that the `env` argument of `createInternalRepl()` also contained external environment variables, because keeping them can be necessary for spawning processes on some systems. However, this test does not spawn new processes, and relies on the fact that the environment variables it tests are not already set (and fails otherwise); therefore, reverting to the original state should fix this. Fixes: nodejs#21451 Fixes: nodejs/build#1377 Refs: nodejs#25219 PR-URL: nodejs#25226 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#25216 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove unused `name` argument that is different from a subsequent `name` argument in a different but nearby function. This was mildly confusing to me at first, so hopefully this change clarifies things for others reading the test. PR-URL: nodejs#25117 Reviewed-By: James M Snell <jasnell@gmail.com>
'close' event isn't emitted on a TLS connection if it's been written to (but 'end' and 'finish' events are). PR-URL: nodejs#25026 Fixes: nodejs#24984 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Instead of using an undocumented underscore-prefixed property to configure the writable stream instance to not encode strings as buffers, use the public API which is an options property passed to the constructor. Refs: nodejs#445 PR-URL: nodejs#25201 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
We were previously reading from the wrong offset, namely the one into the final results array, not the one for the AAAA results itself, which could have lead to reading uninitialized or out-of-bounds data. Also, adjust the test accordingly; TTL values are not modified by c-ares, but are only exposed for a subset of all DNS record types. PR-URL: nodejs#25187 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This would otherwise be reported as a memory leak by automated tools. PR-URL: nodejs#25180 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
During the time between nodejs#24234 being opened and it landing, a V8 update occurred that deprecated several APIs. This commit fixes the following compiler warnings: ../src/node_crypto.cc:3342:11: warning: 'Set' is deprecated: Use maybe version ../src/node_crypto.cc:3345:13: warning: 'GetFunction' is deprecated: Use maybe version PR-URL: nodejs#25205 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Revise the "Breaking Changes to Internal Elements" section of COLLABORATOR_GUIDE.md. Simplify wording, shorten sentences, and remove redundant material. PR-URL: nodejs#25190 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
PR-URL: nodejs#25207 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit adds a DCHECK macro for consistency with the other DCHECK_* macros. PR-URL: nodejs#25207 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Set encoding on the stderr/stdout streams instead of calling data.toString(). Don't assume the complete expected messages arrive in a single event. PR-URL: nodejs#25169 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This adds support for inspect to distinguish regular expression subclasses and ones with null prototype from "normal" regular expressions. PR-URL: nodejs#25192 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
So far we do not test all data types for subclasses and this extends the existing tests for WeakSet, WeakMap and BigInt64Array. PR-URL: nodejs#25192 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#25149 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Simplify code by using return value of Object.defineProperty directly. PR-URL: nodejs#25162 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Link to the cli docs for --tls-cipher-list, and link to and mention that NODE_OPTIONS can also be used. PR-URL: nodejs#25174 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: nodejs#25174 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in nodejs#25007 Mart these as flaky in AIX until that is resolved. Refs: nodejs#25047 Refs: nodejs#25029 PR-URL: nodejs#25126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This commit simplifies the calling of normalizeSpawnArguments() and normalizeExecArguments(). Specifically, this commit replaces apply() and the use of arguments with a normal function call. PR-URL: nodejs#25194 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The OCSP info from parsing the TLS ClientHello has not been used since 550c263, remove it. See: nodejs#1464 PR-URL: nodejs#25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
"wrapped" argument is the caller's "socket", not its "wrap", and its referred to as "socket" in the comments, so call it that. PR-URL: nodejs#25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
session ID was named session in C++ and key in JS, Name them after what they are, as the 'newSession' event docs do. PR-URL: nodejs#25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Its confusing to call a js class with a handle a "Wrap", usually it's the C++ handle that is called a Wrap (tcp_wrap, tls_wrap, ...). Its derived from Socket, and makes a JS stream look like a Socket, so call it that. Also, remove use of lib/_stream_wrap.js so it can be deprecated some time. PR-URL: nodejs#25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Split test-whatwg-encoding-textdecoder.js into: - `test-whatwg-encoding-custom-textdecoder.js` which tests Node.js-specific behaviors - `test-whatwg-encoding-custom-textdecoder-api-invalid-label.js` which is a customized version of the WPT counterpart - `test-whatwg-encoding-custom-api-basics.js` which is the part of `test-whatwg-encoding-api-basics.js` that can be run without ICU - `test-whatwg-encoding-api-basics.js` which can be replaced with WPT later. PR-URL: nodejs#25155 Reviewed-By: James M Snell <jasnell@gmail.com>
Split `test-whatwg-encoding-textdecoder-fatal.js` into - `test-whatwg-encoding-custom-textdecoder-fatal.js` which is a customized version of the WPT that tests for Node.js-specific error codes. - `test-whatwg-encoding-custom-textdecoder-invalid-arg` which tests `ERR_INVALID_ARG_TYPE` PR-URL: nodejs#25155 Reviewed-By: James M Snell <jasnell@gmail.com>
Split the following tests: - `test-whatwg-encoding-textdecoder-utf16-surrogates.js` - `test-whatwg-encoding-textdecoder-ignorebom.js` - `test-whatwg-encoding-textdecoder-streaming.js` Each into two files: one that can be run without ICU and one that has to be run with ICU. The latter can be replaced with WPT later. PR-URL: nodejs#25155 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#25155 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#25155 Reviewed-By: James M Snell <jasnell@gmail.com>
This removes the `internalBinding('uv')` call from the normal
bootstrap for now, and avoids building `errmap` by default which
expands to a lot of calls into V8.
PR-URL: nodejs#25143
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
There has been no argument about #22478, so I kept that commit. |
|
CITGM looked fine, the CI was green (running the CI again after the last change should not be necessary). Running the V8 CI again before publishing this as release: https://ci.nodejs.org/job/node-test-commit-v8-linux/2018/ |
BridgeAR
force-pushed
the
v11.7.0-proposal
branch
from
03f3361
to
b408aa5
Compare
|
A single V8 test failed continuously: v8tests.mjsunit/wasm/jsapi-harness It seemed like it also failed on v11.6.1 (see https://ci.nodejs.org/job/node-test-commit-v8-linux/2020/testReport/) so I do not consider this blocking but we should have a closer look at that again. |
Notable Changes
* compression / zlib:
* Added brotli support (Anna Henningsen and Zach Vacura)
nodejs#24938
* console:
* Added `inspectOptions` option (Ruben Bridgewater)
nodejs#24978
* crypto:
* Always accept private keys as public keys (Tobias Nießen)
nodejs#25217
* deps:
* Upgrade npm to v6.5.0 (Jordan Harband)
nodejs#25234
* fs:
* Use internalBinding('fs') internally instead of
process.binding('fs') (Masashi Hirano)
nodejs#22478
* http(s):
* Support overriding http\\s.globalAgent (Roy Sommer)
nodejs#25170
* util:
* Inspect ArrayBuffers contents closely (Ruben Bridgewater)
nodejs#25006
* worker:
* Expose workers by default and remove `--experimental-worker` flag
(Anna Henningsen) nodejs#25361
PR-URL: nodejs#25537
BridgeAR
force-pushed
the
v11.7.0-proposal
branch
from
b408aa5
to
6b7b827
Compare
|
I added #25361 as notable change. |
PR-URL: nodejs#25537
|
why wasn't #22478 simply rebased off staging? Not blocking on that but confused on why it needs to exist on the release line. |
|
Can we at least remove the |
|
Was just reviewing CITGM results and it seems like the node-report failure is legitimate. |
|
it's --> #25258 specifically d718625 Can confirm that reverting the above commit fixes node-reports's test suite /cc @gabrielf @addaleax @rnchamberlain @richardlau |
|
@MylesBorins is it only in |
|
@targos looking into that right now. Trying to make a reproduction but it looks like the failure is related to a native module. here's where I'm at right now with a test // node-report
if (process.argv[2] === 'child') {
const api = require('../api');
api.setEvents('signal');
} else {
const assert = require('assert');
const spawn = require('child_process').spawn;
const child = spawn(process.execPath, [__filename, 'child']);
child.on('exit', (code) => {
assert.strictEqual(code, 0, `process exited with code: ${code}`);
});
}if we don't setEvents('signal') the below failure does not happen. edit: here is the SetEvents method https://github.com/nodejs/node-report/blob/master/src/module.cc#L103-L134 |
|
It would be great if #25562 could make it into the release. |
BridgeAR
added a commit
that referenced
this pull request
Jan 18, 2019
Notable Changes
* compression / zlib:
* Added brotli support (Anna Henningsen and Zach Vacura)
#24938
* console:
* Added `inspectOptions` option (Ruben Bridgewater)
#24978
* crypto:
* Always accept private keys as public keys (Tobias Nießen)
#25217
* deps:
* Upgrade npm to v6.5.0 (Jordan Harband)
#25234
* fs:
* Use internalBinding('fs') internally instead of
process.binding('fs') (Masashi Hirano)
#22478
* http(s):
* Support overriding http\\s.globalAgent (Roy Sommer)
#25170
* util:
* Inspect ArrayBuffers contents closely (Ruben Bridgewater)
#25006
* worker:
* Expose workers by default and remove `--experimental-worker` flag
(Anna Henningsen) #25361
PR-URL: #25537
|
I could not remove the mentioned commit anymore as I had a signed tag for the release before. I just released this as is and I am preparing a patch release now. |
BridgeAR
added a commit
to BridgeAR/nodejs.org
that referenced
this pull request
Jan 18, 2019
BridgeAR
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jan 18, 2019
|
Please remove both commits from the offending pr |
|
@MylesBorins @BridgeAR I’m sorry this bug slipped through – I’ve opened #25577 to address the issue. I’d prefer it if we could fix the bug directly, rather than first reverting the commits in question altogether? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-01-17, Version 11.7.0 (Current), @BridgeAR
#22478 is included because of #25446. This should probably not cause any issues due to being on the white list but I would like other collaborators to weight in if we should remove that commit or not (@addaleax you expressed some concerns in the original PR, so please also check again). @nodejs/tsc PTAL.
There is another semver-major commit which is followed by a patch commit that reverts the actual breaking change but that commit is required to allow further backporting.
Notable Changes
inspectOptionsoption (Ruben Bridgewater) #24978Commits
e09dd0c5f0] - assert: makeactualandexpectedgetters (Ruben Bridgewater) #25250516f75fda8] - benchmark: fix net-wrap-js-stream-passthrough (Rich Trott) #252739a627a4694] - (SEMVER-MINOR) benchmark,test: add brotli (Anna Henningsen) #24938eacc1518cc] - buffer: move Buffer prototype wiring into internal/buffer.js (Joyee Cheung) #25292255f017ea0] - buffer: move initialization of buffer prototype into node.js (Joyee Cheung) #2529268014fbc22] - buffer: inspect extra properties (Ruben Bridgewater) #251501d4940888d] - buffer: refactor checks for SlowBuffer creation (P. Mike) #252667dc4c3be03] - buffer: fix crash for invalid index types (Anna Henningsen) #25154a4f50a62d5] - build: set-blibpath:for AIX (Richard Lau) #2544707ffa3f189] - build: add check for empty openssl-fips flag (Daniel Bevenius) #25391a2cc4bad0e] - build: fix Windows shared lib build (Richard Lau) #25166736349c7e3] - build,test: failcoveragetarget if tests fail (Refael Ackermann) #2543256e7e4f0cd] - child_process: simplify argument handling (cjihrig) #25194272ddb1765] - console: improve inspectOptions validation (cjihrig) #2509065d485b880] - (SEMVER-MINOR) console: addinspectOptionsoption (Ruben Bridgewater) #2497857323e8048] - console: move the inspector console wrapping in a separate file (Joyee Cheung) #24709b549058cc4] - console: split console into global.js and constructor.js (Joyee Cheung) #247094052aec321] - console: lazy load process.stderr and process.stdout (Joyee Cheung) #245347f5bb9d3bf] - console: bind methods from the prototype chain in Console (Joyee Cheung) #24047b2b0645805] - console: create the global console from Console constructor (Joyee Cheung) #25420561c2689ef] - console: use spread notation instead of Object.assign (Ruben Bridgewater) #2514963fbd00834] - coverage: pass cwd to path.resolve() in setup (cjihrig) #25289daca3188af] - coverage: use process._rawDebug() during setup (cjihrig) #25289eaaaa0d479] - (SEMVER-MINOR) crypto: always accept private keys as public keys (Tobias Nießen) #2521732e45b20da] - crypto: fix key object wrapping in sync keygen (Tobias Nießen) #25326bc6f4bc0c5] - crypto: add crypto/keys to cannotUseCache (Daniel Bevenius) #25237f3ebc391a3] - crypto: fix zero byte allocation assertion failure (Tobias Nießen) #25248e1d4f4384a] - deps: cherry-pick d9fbfeb from upstream V8 (Alexey Kozyatinskiy) #2533191015918d8] - deps: upgrade npm to v6.5.0 (Jordan Harband) #2523411c01a6a69] - (SEMVER-MINOR) deps: add brotli (Hackzzila) #24938f2abe7bf76] - deps: V8: backport 3e010af (Ruben Bridgewater) #25101201cf97fcb] - deps: V8: backport bf84766 (Ruben Bridgewater) #25101ec87b6c994] - (SEMVER-MINOR) deps,tools: update license-builder.sh and LICENSE (Hackzzila) #249385b4fab1a40] - dns: fix TTL value for AAAA replies toresolveAny()(Anna Henningsen) #25187edab2d61fd] - doc: revert incorrect change on readable._read (Matteo Collina) #254422172dbfce4] - doc: add TLSSocket.isSessionReused() docs (Sam Roberts) #254237123167e31] - doc: improve Sign/Verify examples and docs (Sam Roberts) #254529a61a7abb3] - doc: fix section order in vm.md (Vse Mozhet Byt) #253742b0c8538ef] - doc: fix sorting in buffer.md (Vse Mozhet Byt) #25477f8bb544bfb] - doc: fixnapi\_open\_callback\_scopedescription (Philipp Renoth) #25366b67c4b4f99] - doc: document that stream.on('close') was changed in Node 10 (Matteo Collina) #254133db7a9ffba] - doc: fix, unify, formalize, and amplify vm.md (Vse Mozhet Byt) #25422ebd202736c] - doc: fix the path to postMessage() (Mitar) #25332177635b320] - doc: updateos.networkInterfaces()example (jvelezpo) #2541767782613bb] - doc: make sure that calls to .read() are looped (Matteo Collina) #25375f58b5300cd] - doc: wrap and punctuate YAML description text (Sam Roberts) #254198380bd46a0] - doc: add history to http.request.setTimeout() (James Bunton) #251218bc1651249] - doc: add clarification for exception behaviour (Michael Dawson) #25339f3d86391d9] - doc: clarify timing of socket.connecting (Sam Roberts) #253337d46437c45] - doc: update benchmark doc (Kazushi Kitaya) #25367071f84e80a] - doc: use lowercase for zlib (Rich Trott) #253717d1d26191d] - doc: fix heading in cpp style guide (Kazushi Kitaya) #25303354fba1b26] - doc: fix process.stdin example (Anna Henningsen) #253441e20c5e440] - doc: make modules.md more accurate (Vse Mozhet Byt) #25357f8dcbba563] - doc: fs.mkdir('/') throws EPERM on Windows (Corey Farrell) #25340b9b2ba22ec] - doc: document key encryption options (Tobias Nießen) #23632f5008fd1ef] - doc: simplify DEP0119 wording (cjihrig) #252761c5a99797b] - (SEMVER-MINOR) doc: add documentation for brotli support (Anna Henningsen) #24938be45469744] - doc: edit and simplify util.inspect() docs (cjihrig) #251958a701c3fce] - doc: include license for src/large_pages in LICENSE (Ujjwal Sharma) #25246e6da77b12c] - doc: describe TLS session resumption (Sam Roberts) #251743af173df00] - doc: link and expand --tls-cipher-list docs (Sam Roberts) #2517439b3fd1b61] - doc: revise "Breaking Changes to Internal Elements" (Rich Trott) #251902c50bcda8a] - doc: fix NAPI typo (Philipp Renoth) #252161697604ae0] - doc,worker: revise worker_threads.md (Rich Trott) #25402dd0381fe4e] - (SEMVER-MAJOR) fs: make process.binding('fs') internal (Masashi Hirano) #22478ca7adcafda] - fs: extract start and end check into checkPosition (ZYSzys) #2526426f2eb8b12] - http2: add test case for goaway (Anto Aravinth) #24054445ba9f283] - inspector: move process.binding to internalBinding (Beni von Cheni) #249318cc97571a4] - Revert "inspector: move process.binding to internalBinding" (Joyee Cheung) #254464794cf601e] - inspector: move process.binding to internalBinding (Beni von Cheni) #249313061cb50df] - inspector, test: verify reported console message (Eugene Ostroukhov) #254556528ce6176] - lib: expose all type checks from the internal types module (Ruben Bridgewater) #25149207612c723] - lib: remove internalBinding('config').pendingDeprecation (Joyee Cheung) #24962d8ba520622] - lib: remove unused NativeModule/NativeModule wraps (Joyee Cheung) #2490487a58beed7] - lib: remove duplicated noop function (ZYSzys) #24770d7d772b2f8] - Revert "lib: remove duplicated noop function" (Joyee Cheung) #2544642a7eaf9d4] - Revert "lib: remove unused NativeModule/NativeModule wraps" (Joyee Cheung) #25446b48865f03f] - lib: move lib/console.js to lib/internal/console/constructor.js (Joyee Cheung) #247093350230e20] - lib: remove internalutil.\_extends()usage (Ruben Bridgewater) #2510573c3a3d5ed] - (SEMVER-MAJOR) lib: make the global console [[Prototype]] an empty object (Joyee Cheung) #235098d0c638583] - (SEMVER-MINOR) lib: support overriding http\s.globalAgent (Roy Sommer) #25170217bb0e5f0] - lib: simplify several debug() calls (cjihrig) #25241e14f8646e2] - lib,test: remove lib/internal/test/unicode.js (Rich Trott) #25298c13e5be740] - net: use decodeStrings public API for writable stream (Rich Trott) #252019ac8d41925] - net: check for close on stream, not parent (David Halls) #25026f4fa04e170] - os: add fallback for undefined CPUs (Minwoo Jung) #25493840ec230f1] - os: improve networkInterfaces() performance (Brian White) #25410d197105476] - os: move process.binding('os') to internalBinding (briete) #25087f64e5ec148] - Revert "os: move process.binding('os') to internalBinding" (Joyee Cheung) #2544655d185f0dd] - os: move process.binding('os') to internalBinding (briete) #2508742fc754477] - process: register the inspector async hooks in bootstrap/node.js (Joyee Cheung) #2544302f1e64155] - process: refactor coverage setup during bootstrap (Joyee Cheung) #25398422a063ca4] - process: allow StartExecution() to take a main script ID (Joyee Cheung) #25474d7a07d887a] - process: move C++ process events into node_process_events.cc (Joyee Cheung) #2539759b5e771b5] - process: move --help and --bash-completeion handling to startExecution (Joyee Cheung) #252622bd743717b] - process: move process.features initialization into node.js (Joyee Cheung) #25239127439db1c] - process: make tick callback and promise rejection callback more robust (Joyee Cheung) #252005b1a987f81] - process: move worker bootstrap code into worker_thread_only.js (Joyee Cheung) #25199020a9ab4ff] - process: split worker IO into internal/worker/io.js (Joyee Cheung) #251991c4d7ebeea] - process: move eval and exception bootstrap ito process/execution.js (Joyee Cheung) #251997be4a39d9b] - process: make internal/queue_microtask.js more self-contained (Joyee Cheung) #251896b5c962a0a] - process: move child process IPC setup condition into node.js (Joyee Cheung) #25130e93dd4dad6] - process: move POSIX credential accessors into node_credentials.cc (Joyee Cheung) #250660e2fbe4ff4] - process: specialize building and storage of process.config (Joyee Cheung) #2481618052364ce] - process: provide dummy stdio for non-console Windows apps (Anna Henningsen) #206401ccaf9a8f1] - repl: indicate if errors are thrown or not (Ruben Bridgewater) #25253d4ef9220ad] - src: declare process-related C++ methods in node_process.h (Joyee Cheung) #253977cbbd68c6b] - src: move process object creation into node_process_object.cc (Joyee Cheung) #25397a162251b49] - src: clean upnode::Init()wrt embedder scenarios (Anna Henningsen) #253700095f492af] - src: move InternalMakeCallback and MakeCallback (Joyee Cheung) #25299497a08af55] - src: remove unused isolate variable (Daniel Bevenius) #25368d6b4cb3826] - src: use generic helper for splitting strings (Anna Henningsen) #2536321096f91dd] - src: splitLoadEnvironment()atstartExecution()(Anna Henningsen) #25320a8daccce66] - src: move per-process global variables into node::per_process (Joyee Cheung) #25302582c34d973] - src: useinternalBinding('config').hasInspectorin JS land (Joyee Cheung) #25291abc4cc2fb8] - src: refactor tickInfo access (Joyee Cheung) #252008abcc76b3a] - src: move process.nextTick and promise setup into node_task_queue.cc (Joyee Cheung) #25163733af61341] - src: move symbols binding into node_symbols.cc (Joyee Cheung) #2516357a0cd4d48] - src: move node::errno_string into node_errors.h/cc (Joyee Cheung) #25396f8ba4880ab] - src: fix compiler warnings (cjihrig) #25165dde71520ba] - src: move more process methods initialization in bootstrap/node.js (Joyee Cheung) #251275fe774104f] - src: dispose of V8 platform inprocess.exit()(Anna Henningsen) #25061e9b4d24eda] - src: move arch, platform and release into node_metadata.cc (Joyee Cheung) #2529343535f56fd] - src: simplify JS Array creation (Anna Henningsen) #25288de6f1f5e4d] - src: initialize ICU version in per_process::metadata.versions (Joyee Cheung) #25115e5b4af43fd] - src: move the declaration of http parser versions into node_metadata.h (Joyee Cheung) #2511564c713a2e7] - src: move GetOpenSSLVersion into node_metadata.cc (Joyee Cheung) #25115b1500d9a7f] - src: pass isMainThread into bootstrap/node.js directly (Joyee Cheung) #25017ee461feaee] - src: always compile and store code cache for native modules (Joyee Cheung) #24950fd913fe365] - src: remove code cache integrity check (Joyee Cheung) #24950d245c4cd50] - src: use NativeModuleLoader to compile all the bootstrappers (Joyee Cheung) #24775d1ff107b51] - src: initializeEnvironmentmembers in class definition (Anna Henningsen) #253695b933565ac] - src: check curve ID existence instead of asn flags (Sam Roberts) #25345807e732832] - src: trace_events: fix race with metadata events (Ali Ijaz Sheikh) #252351e60e0afcb] - src: remove unused method declaration (Ben Noordhuis) #25329f6e341a546] - src: improve ToV8Value() functions (Anna Henningsen) #25288465d02b817] - src: add NAPI_VERSION_EXPERIMENTAL (Michael Dawson) #25319d7186252df] - src: unload addons when environment quits (Gabriel Schulhof) #24861f62e35fd05] - src: fix warning in cares_wrap.cc (cjihrig) #252302f5c8b5041] - src: remove unused variable from string_search.h (Anna Henningsen) #25139e00b326f33] - src: pass along MaybeLocal<> state fromURL::ToObject()(Anna Henningsen) #25141ae86192732] - src: ignore termination exceptions in fatal TryCatch (Anna Henningsen) #25141c9d49d65a4] - src: fulfill Maybe contract in InlineDecoder (Anna Henningsen) #25140dd6667d05e] - src: lazily load internalBinding('uv') and build the errmap lazily (Joyee Cheung) #25143bc66356093] - src: use consistent names for JSStream (Sam Roberts) #2515399a5af65df] - src: introduce DCHECK macro (cjihrig) #25207e2a01ca061] - src: use DCHECK_* macros where possible (cjihrig) #2520773ccfc81c9] - src: fix compiler warnings in node_crypto.cc (cjihrig) #252057365b00929] - src: do not leak NodeTraceStateObserver (Anna Henningsen) #2518037ba20112a] - src,lib: prefer internal/options over process._foo (Anna Henningsen) #250637480864c51] - src,lib: make process.binding('config') internal (Masashi Hirano) #23400577da835d2] - Revert "src,lib: make process.binding('config') internal" (Joyee Cheung) #254460b1a9aaa0e] - test: improve known_issues/test-vm-timeout-escape-queuemicrotask (Rich Trott) #255033afb4813c8] - test: add test for fs.lchmod (ZYSzys) #25439067d38fb07] - test: make test-v8-coverage.js more strict (cjihrig) #25289f6c14bd1e2] - test: rework ephemeralkeyinfo to run in parallel (Sam Roberts) #2540929b89badb5] - test: check for tls renegotiation errors (Sam Roberts) #2543723d41fbf01] - test: fix test-net-connect-econnrefused (again) (Rich Trott) #25438d86a3e8245] - test: remove unnecessary skipIfWorker() (Rich Trott) #2542782fc9a8889] - test: fix module loading error for AIX 7.1 (Richard Lau) #254183f661097d1] - test: improve test coverage of native crypto code (Tobias Nießen) #25400fe9b6ee88b] - test: move require('https') to after crypto check (Daniel Bevenius) #25388b545b4c1e9] - test: fix test-net-connect-econnrefused (Rich Trott) #253890f290e8f62] - test: remove test/pummel/test-http-client-reconnect-bug.js (Rich Trott) #2538758de81faa7] - test: remove duplicate encoding tests in favor of WPT (Joyee Cheung) #25321da34c6c575] - test: use WPT runner to run encoding tests (Joyee Cheung) #253218d8c30599a] - test: support more icu requirements in the WPT status file (Joyee Cheung) #25321d9adceecb6] - test: pull enconding WPT test fixtures (Joyee Cheung) #25321837ca76a0d] - test: refactor test-fs-watch-non-recursive (Rich Trott) #2538665dfeeb9a9] - test: fix test/pummel/test-fs-watch-non-recursive.js (Rich Trott) #25386bdcf8f4784] - test: fix test/pummel/test-fs-watch-file.js (Rich Trott) #25384be16cc9fd6] - test: set umask for tests (Rich Trott) #252293bebcf0180] - test: fix failing assertion (Ruben Bridgewater) #25250201a8d9dc2] - test: refactorcommon.expectWarning()(Ruben Bridgewater) #25251f0202a7604] - test: fix test/pummel/test-fs-largefile.js (Rich Trott) #25372fc22df9552] - test: more tests for internal/util/types (ZYSzys) #25225c826af781f] - test: clean up wasm fixtures (Gus Caplan) #25360c1aa5f0dae] - test: tune test-uv-threadpool-schedule (Rich Trott) #25358f80fbd2c16] - test: remove redundant fchmod test (ZYSzys) #25282ce7bbd2ad9] - test: move test-tls-securepair-client out of pummel (Rich Trott) #252227ac1db2c31] - test: fix test-tls-securepair-client (Rich Trott) #25222239d5ec92c] - test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH (Furqan Shaikh) #25296456f76a48b] - test: remove flag for test-addon-uv-handle-leak (Rich Trott) #25327523872b37f] - test: fix test-benchmark-zlib (Rich Trott) #25365379260e4bd] - test: replace internals with public API (Rich Trott) #25309973b32d3c3] - test: set umask explicitly (Thomas Chung) #25213c10b131ec9] - test: make sure tmpdir is created before using it (Joyee Cheung) #252245a5bc58b4f] - test: remove unused --expose-native-as V8 flag (peterwmwong) #2527561fc3bfd8e] - test: mark test-util-callbackify flaky on AIX (Rich Trott) #25284ee8a4a291d] - test: remove unnecessary test flags (cjihrig) #252774ca4b546ab] - test: removeutil.inherits()usage (ZYSzys) #2524511c9a82f0f] - test: slightly refactor test-child-process-execsync (Denys Otrishko) #2522705d1a536cc] - test: remove try/catch in common.isMainThread (Rich Trott) #25249b0b1414ad7] - test: regression test for uv threadpool congestion (Gireesh Punathil) #23099c7d2dbd5da] - test: add TODO to encoding tests that can be replaced with WPT (Joyee Cheung) #25155b45be671db] - test: rename custom encoding tests that cannot be replaced by WPT (Joyee Cheung) #25155be421823e5] - test: split encoding tests where some cases can be run without ICU (Joyee Cheung) #25155deceb26238] - test: split test-whatwg-encoding-textdecoder-fatal.js (Joyee Cheung) #25155a8f5191eb9] - test: split test-whatwg-encoding-textdecoder.js (Joyee Cheung) #251557e2ae75a6b] - test: mark two tests as flaky in AIX (Gireesh Punathil) #25126e182ca9bdc] - test: add more inspect subclassing tests (Ruben Bridgewater) #2519258af085d9f] - test: refactor stdio handling in test-esm-cjs-main (Richard Lau) #2516991d1aea311] - test: refactor test-esm-namespace.mjs (Rich Trott) #25117b7b1d7eb88] - test: fix test-repl-envvars (Anna Henningsen) #2522695353c7c20] - test,doc: add tests and docs for addon unloading (Anna Henningsen) #24861a29adef252] - test,worker: simplify common.isMainThread (Rich Trott) #25426a6df7278d8] - test,worker: refactor test-worker-cleanup-handles (Rich Trott) #25401453bd18969] - tls: do not confuse TLSSocket and Socket (Sam Roberts) #25153f6b2ea8bb9] - tls: do not confuse session and session ID (Sam Roberts) #25153d5ba121e74] - tls: fix initRead socket argument name (Sam Roberts) #25153acf7802fe3] - tls: remove unused ocsp extension parsing (Sam Roberts) #25153f0409be2a7] - tools: lint for use of internalBinding() (cjihrig) #253952a85cc7cae] - tools: update crypo check rule (cjihrig) #25399dcbf1d9da4] - tools: add openssl-cli to macos-firewall.sh (Daniel Bevenius) #25385ee4c46c72f] - tools: update ESLint to 5.12.0 (cjihrig) #253471be566bd2f] - tools: replace NULL with nullptr (Juan José Arboleda) #25179fee8a11634] - tools: remove custom buffer-constructor lint rule (cjihrig) #25261ee43540aa7] - tools: enable no-buffer-constructor lint rule (cjihrig) #25261e6b5232381] - tools: enable no-useless-catch lint rule (cjihrig) #25236f944a75336] - tools: update ESLint to 5.11.1 (cjihrig) #2523619f1a506ee] - trace_events: move SetupTraceCategoryState into node_trace_events.cc (Joyee Cheung) #251286e716ed1d6] - url: return backslashes from fileURLToPath on win (Kevin Smith) #2534971432c3d06] - util: fixes type in argument type validation error (Ankur Oberoi) #2510346ec26f8aa] - util: remove eslint comments and rename variables (Ruben Bridgewater) #252557ff44105be] - util: remove outdated comment (Ruben Bridgewater) #2525545a8eb6ed3] - util: simpler module namespace code (Ruben Bridgewater) #25255a333272fb0] - util: code cleanup (Ruben Bridgewater) #252557696d1fe84] - util: switch recurseTimes counter (Ruben Bridgewater) #252552e6e4cfaf5] - util: add null prototype support for date (Anto Aravinth) #25144901d3d0959] - (SEMVER-MINOR) util: inspect ArrayBuffers contents as well (Ruben Bridgewater) #250064ca0968918] - util: update comment in util.promisify (Kazushi Kitaya) #2532337976251b5] - util: fix util.inspect with proxied function (Weijia Wang) #2524488e73862ca] - util: simplify code (Kazushi Kitaya) #2516273f3a1c4e6] - util: make inspect aware of RegExp subclasses and null prototype (Ruben Bridgewater) #251927f78137c37] - v8: enable inline WASM in serialization API (Anna Henningsen) #253132df0d14e18] - win, build: fix building addons on Windows (Bartosz Sosnowski) #25108ab7284a01a] - worker: remove--experimental-workerflag (Anna Henningsen) #253619c5db9375f] - worker: improve JS-side debugging (Anna Henningsen) #2531265c136f3de] - worker: partially remove--experimental-workerflag (Anna Henningsen) #254047bb7b9a61f] - worker: set--experimental-workeralways (Anna Henningsen) #25404dd8795f4a0] - worker: enable transferring WASM modules (Anna Henningsen) #253142014eba782] - worker: use engine-provided deleter forSharedArrayBuffers (Anna Henningsen) #253077edf8c7e74] - (SEMVER-MINOR) zlib: add brotli support (Anna Henningsen) #24938e534dcd75e] - zlib: split JS code as prep for non-zlib-backed streams (Anna Henningsen) #24939