Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unused uncaughtException handler #25641

Closed
wants to merge 2 commits into from
Closed

test: remove unused uncaughtException handler #25641

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

This has been unused since cbc3ef6.

Refs: #23053

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2341/pipeline

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Jan 22, 2019
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2019
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20304/

@richardlau richardlau removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2019
mhdawson
mhdawson approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau @addaleax
fixup! test: remove unused uncaughtException handler
5067d20 
Co-Authored-By: addaleax <github@addaleax.net>
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20351/

@addaleax
Copy link
Member Author

Landed in 573ec5b

@addaleax addaleax closed this Jan 27, 2019
@addaleax addaleax deleted the test-tty-stdout-end branch January 27, 2019 19:46
addaleax added a commit that referenced this pull request Jan 27, 2019
@addaleax
test: remove unused uncaughtException handler
573ec5b 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit that referenced this pull request Jan 28, 2019
@addaleax
test: remove unused uncaughtException handler
7d68223 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request Jan 29, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@addaleax @BethGriggs
test: remove unused uncaughtException handler
1eb38b0 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@addaleax @BethGriggs
test: remove unused uncaughtException handler
802661a 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@addaleax @MylesBorins
test: remove unused uncaughtException handler
48505d8 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@addaleax @nodejs-github-bot @Fishrock123 @lpinca @cjihrig @richardlau @mhdawson