Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x-backport] n-api: mark thread-safe function as stable #25648

Closed
wants to merge 2 commits into from
Closed

[v8.x-backport] n-api: mark thread-safe function as stable #25648

wants to merge 2 commits into from

Commits on Mar 4, 2019

  1. n-api: restrict exports by version 

    * Move `napi_get_uv_event_loop` into the `NAPI_VERSION >= 2` section
* Move `napi_open_callback_scope`, `napi_close_callback_scope`,
  `napi_fatal_exception`, `napi_add_env_cleanup_hook`, and
  `napi_remove_env_cleanup_hook` into the `NAPI_VERSION >= 3` section
* Added a missing `added` property to `napi_get_uv_event_loop` in the
  docs
* Added a `napiVersion` property to the docs and updated the parser and
  generator to use it.
* Added usage documentation

PR-URL: nodejs#19962
Backport-PR-URL: nodejs#25648
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @kfarnung
    kfarnung authored and Gabriel Schulhof committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    80fa044 View commit details
    Browse the repository at this point in the history

  2. n-api: mark thread-safe function as stable 

    Fixes: nodejs#24249
PR-URL: nodejs#25556
Backport-PR-URL: nodejs#25633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Gabriel Schulhof committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    ad9c154 View commit details
    Browse the repository at this point in the history