Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] deps: V8: cherry-pick 3cc6919 #25874

Closed
wants to merge 1 commit into from
Closed

[v8.x] deps: V8: cherry-pick 3cc6919 #25874

wants to merge 1 commit into from

Conversation

miladfarca
Copy link
Contributor

Original commit message:

PPC: fix Regex addi overflow

using add insetad of addi when Operand is more than 16 bits long

Change-Id: I7f9452381ed8b321ec71e68d0d90485508b69885
Reviewed-on: https://chromium-review.googlesource.com/c/1430619
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#59049}

Refs: v8/v8@3cc6919

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added v8 engine Issues and PRs related to the V8 dependency. v8.x labels Feb 1, 2019
@miladfarca
Copy link
Contributor Author

V8 version on master already includes this fix, backporting it to v8.x. A separate PR has been created for backporting it to v10.x: #25872

mhdawson
mhdawson approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Feb 1, 2019

V8 CI run: https://ci.nodejs.org/job/node-test-commit-v8-linux/2065/

@richardlau richardlau changed the title deps: V8: cherry-pick 3cc6919 [v8.x] deps: V8: cherry-pick 3cc6919 Feb 1, 2019
@BethGriggs
deps: V8: cherry-pick 3cc6919
547c515 
Original commit message:

    PPC: fix Regex addi overflow

    using add insetad of addi when Operand is more than 16 bits long

    Change-Id: I7f9452381ed8b321ec71e68d0d90485508b69885
    Reviewed-on: https://chromium-review.googlesource.com/c/1430619
    Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
    Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#59049}

Refs: v8/v8@3cc6919
BethGriggs pushed a commit that referenced this pull request Mar 21, 2019
@BethGriggs
deps: V8: cherry-pick 3cc6919
97cc0fc 
Original commit message:

    PPC: fix Regex addi overflow

    using add insetad of addi when Operand is more than 16 bits long

    Change-Id: I7f9452381ed8b321ec71e68d0d90485508b69885
    Reviewed-on: https://chromium-review.googlesource.com/c/1430619
    Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
    Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#59049}

Refs: v8/v8@3cc6919

PR-URL: #25874
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs
Copy link
Member

Landed on v8.x-staging

@BethGriggs BethGriggs closed this Mar 21, 2019
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miladfarca @mhdawson @BethGriggs @richardlau @gdams @nodejs-github-bot