v11.10.0 proposal

.eslintrc.js

@@ -277,24 +277,24 @@ module.exports = {
     'node-core/no-duplicate-requires': 'error',
   },
   globals: {
-    Atomics: false,
-    BigInt: false,
-    BigInt64Array: false,
-    BigUint64Array: false,
-    COUNTER_HTTP_CLIENT_REQUEST: false,
-    COUNTER_HTTP_CLIENT_RESPONSE: false,
-    COUNTER_HTTP_SERVER_REQUEST: false,
-    COUNTER_HTTP_SERVER_RESPONSE: false,
-    COUNTER_NET_SERVER_CONNECTION: false,
-    COUNTER_NET_SERVER_CONNECTION_CLOSE: false,
-    DTRACE_HTTP_CLIENT_REQUEST: false,
-    DTRACE_HTTP_CLIENT_RESPONSE: false,
-    DTRACE_HTTP_SERVER_REQUEST: false,
-    DTRACE_HTTP_SERVER_RESPONSE: false,
-    DTRACE_NET_SERVER_CONNECTION: false,
-    DTRACE_NET_STREAM_END: false,
-    TextEncoder: false,
-    TextDecoder: false,
-    queueMicrotask: false,
+    Atomics: 'readable',
+    BigInt: 'readable',
+    BigInt64Array: 'readable',
+    BigUint64Array: 'readable',
+    COUNTER_HTTP_CLIENT_REQUEST: 'readable',
+    COUNTER_HTTP_CLIENT_RESPONSE: 'readable',
+    COUNTER_HTTP_SERVER_REQUEST: 'readable',
+    COUNTER_HTTP_SERVER_RESPONSE: 'readable',
+    COUNTER_NET_SERVER_CONNECTION: 'readable',
+    COUNTER_NET_SERVER_CONNECTION_CLOSE: 'readable',
+    DTRACE_HTTP_CLIENT_REQUEST: 'readable',
+    DTRACE_HTTP_CLIENT_RESPONSE: 'readable',
+    DTRACE_HTTP_SERVER_REQUEST: 'readable',
+    DTRACE_HTTP_SERVER_RESPONSE: 'readable',
+    DTRACE_NET_SERVER_CONNECTION: 'readable',
+    DTRACE_NET_STREAM_END: 'readable',
+    TextEncoder: 'readable',
+    TextDecoder: 'readable',
+    queueMicrotask: 'readable',
   },
 };

BUILDING.md

@@ -69,9 +69,12 @@ There are three support tiers:
 
 ### Supported platforms
 
-The community does not build or test against end-of-life distributions (EoL).
 For production applications, run Node.js on supported platforms only.
 
+Node.js does not support a platform version if a vendor has expired support
+for it. In other words, Node.js does not support running on End-of-life (EoL)
+platforms. This is true regardless of entries in the table below.
+
 | System       | Support type | Version                         | Architectures    | Notes                         |
 | ------------ | ------------ | ------------------------------- | ---------------- | ----------------------------- |
 | GNU/Linux    | Tier 1       | kernel >= 2.6.32, glibc >= 2.12 | x64, arm         |                               |

CHANGELOG.md

@@ -28,7 +28,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V11.md#11.9.0">11.9.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V11.md#11.10.0">11.10.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V11.md#11.9.0">11.9.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V11.md#11.8.0">11.8.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V11.md#11.7.0">11.7.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V11.md#11.6.0">11.6.0</a><br/>

COLLABORATOR_GUIDE.md

@@ -17,7 +17,7 @@
   - [Breaking Changes](#breaking-changes)
     - [Breaking Changes and Deprecations](#breaking-changes-and-deprecations)
     - [Breaking Changes to Internal Elements](#breaking-changes-to-internal-elements)
-    - [When Breaking Changes Actually Break Things](#when-breaking-changes-actually-break-things)
+    - [Unintended Breaking Changes](#unintended-breaking-changes)
       - [Reverting commits](#reverting-commits)
   - [Introducing New Modules](#introducing-new-modules)
   - [Additions to N-API](#additions-to-n-api)
@@ -276,58 +276,45 @@ an effort to determine the potential impact of the change in the ecosystem. Use
 If a change will cause ecosystem breakage, then it is semver-major. Consider
 providing a Public API in such cases.
 
-#### When Breaking Changes Actually Break Things
+#### Unintended Breaking Changes
 
-* Breaking changes should *never* land in Current or LTS except when:
-  * Resolving critical security issues.
-  * Fixing a critical bug (e.g. fixing a memory leak) requires a breaking
-    change.
-  * There is TSC consensus that the change is required.
-* If a breaking commit does accidentally land in a Current or LTS branch, an
-  attempt to fix the issue will be made before the next release; If no fix is
-  provided then the commit will be reverted.
-
-When any changes are landed on the master branch and it is determined that the
-changes *do* break existing code, a decision may be made to revert those
-changes either temporarily or permanently. However, the decision to revert or
-not can often be based on many complex factors that are not easily codified. It
-is also possible that the breaking commit can be labeled retroactively as a
-semver-major change that will not be backported to Current or LTS branches.
+Sometimes, a change intended to be non-breaking turns out to be a breaking
+change. If such a change lands on the master branch, a Collaborator may revert
+it. As an alternative to reverting, the TSC may apply the semver-major label
+after-the-fact.
 
 ##### Reverting commits
 
-Commits are reverted with `git revert <HASH>`, or `git revert <FROM>..<TO>` for
-multiple commits. Commit metadata and the reason for the revert should be
-appended. Commit message rules about line length and subsystem can be ignored.
-A Pull Request should be raised and approved like any other change.
+Revert commits with `git revert <HASH>` or `git revert <FROM>..<TO>`. The
+generated commit message will not have a subsystem and may violate line length
+rules. That is OK. Append the reason for the revert and any `Refs` or `Fixes`
+metadata. Raise a Pull Request like any other change.
 
 ### Introducing New Modules
 
-Semver-minor commits that introduce new core modules should be treated with
-extra care.
-
-The name of the new core module should not conflict with any existing
-module in the ecosystem unless a written agreement with the owner of those
-modules is reached to transfer ownership.
+Treat commits that introduce new core modules with extra care.
 
-If the new module name is free, a Collaborator should register a placeholder
-in the module registry as soon as possible, linking to the pull request that
-introduces the new core module.
+Check if the module's name conflicts with an existing ecosystem module. If it
+does, choose a different name unless the module owner has agreed in writing to
+transfer it.
 
-Pull requests introducing new core modules:
+If the new module name is free, register a placeholder in the module registry as
+soon as possible. Link to the pull request that introduces the new core module
+in the placeholder's `README`.
 
-* Must be left open for at least one week for review.
-* Must be labeled using the `tsc-review` label.
-* Must have signoff from at least two TSC members.
+For pull requests introducing new core modules:
 
-New core modules must be landed with a [Stability Index][] of Experimental,
-and must remain Experimental until a semver-major release.
+* Allow at least one week for review.
+* Label with the `tsc-review` label.
+* Land only after sign-off from at least two TSC members.
+* Land with a [Stability Index][] of Experimental. The module must remain
+  Experimental until a semver-major release.
 
 ### Additions to N-API
 
-N-API provides an ABI stable API that we will have to support in future
-versions without the usual option to modify or remove existing APIs on
-SemVer boundaries. Therefore, additions need to be managed carefully.
+N-API provides an ABI-stable API guaranteed for future Node.js versions.
+Existing N-API APIs cannot change or disappear, even in semver-major releases.
+Thus, N-API additions call for unusual care and scrutiny.
 
 This
 [guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md)

LICENSE

@@ -1371,3 +1371,48 @@ The externally maintained libraries used by Node.js are:
     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
     THE SOFTWARE.
   """
+
+- HdrHistogram, located at deps/histogram, is licensed as follows:
+  """
+    The code in this repository code was Written by Gil Tene, Michael Barker,
+    and Matt Warren, and released to the public domain, as explained at
+    http://creativecommons.org/publicdomain/zero/1.0/
+
+    For users of this code who wish to consume it under the "BSD" license
+    rather than under the public domain or CC0 contribution text mentioned
+    above, the code found under this directory is *also* provided under the
+    following license (commonly referred to as the BSD 2-Clause License). This
+    license does not detract from the above stated release of the code into
+    the public domain, and simply represents an additional license granted by
+    the Author.
+
+    -----------------------------------------------------------------------------
+    ** Beginning of "BSD 2-Clause License" text. **
+
+     Copyright (c) 2012, 2013, 2014 Gil Tene
+     Copyright (c) 2014 Michael Barker
+     Copyright (c) 2014 Matt Warren
+     All rights reserved.
+
+     Redistribution and use in source and binary forms, with or without
+     modification, are permitted provided that the following conditions are met:
+
+     1. Redistributions of source code must retain the above copyright notice,
+        this list of conditions and the following disclaimer.
+
+     2. Redistributions in binary form must reproduce the above copyright notice,
+        this list of conditions and the following disclaimer in the documentation
+        and/or other materials provided with the distribution.
+
+     THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+     AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+     IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+     ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+     LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+     CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+     SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+     INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+     CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+     ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+     THE POSSIBILITY OF SUCH DAMAGE.
+  """

Makefile

@@ -215,7 +215,7 @@ coverage-build: all
 coverage-build-js:
 	mkdir -p node_modules
 	if [ ! -d node_modules/c8 ]; then \
-		$(NODE) ./deps/npm install c8@next --no-save --no-package-lock;\
+		$(NODE) ./deps/npm install c8 --no-save --no-package-lock;\
 	fi
 
 .PHONY: coverage-test
@@ -240,12 +240,17 @@ coverage-test: coverage-build
 	@grep -A3 Lines coverage/cxxcoverage.html | grep style  \
 		| sed 's/<[^>]*>//g'| sed 's/ //g'
 
+COV_REPORT_OPTIONS = --reporter=html \
+	--temp-directory=out/$(BUILDTYPE)/.coverage --omit-relative=false \
+	--resolve=./lib --exclude="benchmark/" --exclude="deps/" --exclude="test/" --exclude="tools/" \
+	--wrapper-length=0
+ifdef COV_ENFORCE_THRESHOLD
+  COV_REPORT_OPTIONS += --check-coverage --lines=$(COV_ENFORCE_THRESHOLD)
+endif
+
 .PHONY: coverage-report-js
 coverage-report-js:
-	$(NODE) ./node_modules/.bin/c8 report --reporter=html \
-		--temp-directory=out/$(BUILDTYPE)/.coverage --omit-relative=false \
-		--resolve=./lib --exclude="deps/" --exclude="test/" --exclude="tools/" \
-		--wrapper-length=0
+	$(NODE) ./node_modules/.bin/c8 report $(COV_REPORT_OPTIONS)
 
 .PHONY: cctest
 # Runs the C++ tests using the built `cctest` executable.
@@ -455,12 +460,16 @@ test-build-js-native-api: all build-js-native-api-tests
 test-build-node-api: all build-node-api-tests
 
 .PHONY: test-all
-test-all: test-build ## Run everything in test/.
+test-all: test-build ## Run default tests with both Debug and Release builds.
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release
 
 test-all-valgrind: test-build
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind
 
+.PHONY: test-all-suites
+test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites.
+	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*
+
 CI_NATIVE_SUITES ?= addons js-native-api node-api
 CI_JS_SUITES ?= default
 CI_DOC := doctool

benchmark/.eslintrc.yaml

@@ -0,0 +1,10 @@
+## Benchmark-specific linter rules
+
+rules:
+  comma-dangle:
+    - error
+    - arrays: 'always-multiline'
+      objects: 'only-multiline'
+      imports: 'only-multiline'
+      exports: 'only-multiline'
+  prefer-arrow-callback: error

benchmark/_cli.js

@@ -6,10 +6,8 @@ const path = require('path');
 // Create an object of all benchmark scripts
 const benchmarks = {};
 fs.readdirSync(__dirname)
-  .filter(function(name) {
-    return fs.statSync(path.resolve(__dirname, name)).isDirectory();
-  })
-  .forEach(function(category) {
+  .filter((name) => fs.statSync(path.resolve(__dirname, name)).isDirectory())
+  .forEach((category) => {
     benchmarks[category] = fs.readdirSync(path.resolve(__dirname, category))
       .filter((filename) => filename[0] !== '.' && filename[0] !== '_');
   });
@@ -72,7 +70,6 @@ function CLI(usage, settings) {
     } else {
       // Bad case, abort
       this.abort(usage);
-      return;
     }
   }
 }

benchmark/_http-benchmarkers.js

@@ -25,8 +25,11 @@ class AutocannonBenchmarker {
       '-c', options.connections,
       '-j',
       '-n',
-      `http://127.0.0.1:${options.port}${options.path}`
     ];
+    for (const field in options.headers) {
+      args.push('-H', `${field}=${options.headers[field]}`);
+    }
+    args.push(`http://127.0.0.1:${options.port}${options.path}`);
     const child = child_process.spawn(this.executable, args);
     return child;
   }
@@ -59,7 +62,7 @@ class WrkBenchmarker {
       '-d', options.duration,
       '-c', options.connections,
       '-t', 8,
-      `http://127.0.0.1:${options.port}${options.path}`
+      `http://127.0.0.1:${options.port}${options.path}`,
     ];
     const child = child_process.spawn(this.executable, args);
     return child;
@@ -170,7 +173,7 @@ const http_benchmarkers = [
   new AutocannonBenchmarker(),
   new TestDoubleBenchmarker('http'),
   new TestDoubleBenchmarker('http2'),
-  new H2LoadBenchmarker()
+  new H2LoadBenchmarker(),
 ];
 
 const benchmarkers = {};
@@ -188,7 +191,7 @@ exports.run = function(options, callback) {
     path: '/',
     connections: 100,
     duration: 5,
-    benchmarker: exports.default_http_benchmarker
+    benchmarker: exports.default_http_benchmarker,
   }, options);
   if (!options.benchmarker) {
     callback(new Error('Could not locate required http benchmarker. See ' +
@@ -216,7 +219,7 @@ exports.run = function(options, callback) {
   let stdout = '';
   child.stdout.on('data', (chunk) => stdout += chunk.toString());
 
-  child.once('close', function(code) {
+  child.once('close', (code) => {
     const elapsed = process.hrtime(benchmarker_start);
     if (code) {
       let error_message = `${options.benchmarker} failed with ${code}.`;

benchmark/assert/deepequal-buffer.js

@@ -6,10 +6,7 @@ const bench = common.createBenchmark(main, {
   n: [2e4],
   len: [1e2, 1e3],
   strict: [0, 1],
-  method: [
-    'deepEqual',
-    'notDeepEqual'
-  ]
+  method: [ 'deepEqual', 'notDeepEqual' ],
 });
 
 function main({ len, n, method, strict }) {

benchmark/assert/deepequal-map.js

@@ -14,8 +14,8 @@ const bench = common.createBenchmark(main, {
     'deepEqual_mixed',
     'notDeepEqual_primitiveOnly',
     'notDeepEqual_objectOnly',
-    'notDeepEqual_mixed'
-  ]
+    'notDeepEqual_mixed',
+  ],
 });
 
 function benchmark(method, n, values, values2) {

benchmark/assert/deepequal-object.js

@@ -7,10 +7,7 @@ const bench = common.createBenchmark(main, {
   n: [5e3],
   size: [1e2, 1e3, 5e4],
   strict: [0, 1],
-  method: [
-    'deepEqual',
-    'notDeepEqual'
-  ]
+  method: [ 'deepEqual', 'notDeepEqual' ],
 });
 
 function createObj(source, add = '') {
@@ -21,8 +18,8 @@ function createObj(source, add = '') {
       a: [1, 2, 3],
       baz: n,
       c: {},
-      b: []
-    }
+      b: [],
+    },
   }));
 }