v11.11.0 proposal

.eslintrc.js

@@ -60,9 +60,9 @@ module.exports = {
     'brace-style': ['error', '1tbs', { allowSingleLine: true }],
     'capitalized-comments': ['error', 'always', {
       line: {
-        // Ignore all lines that have less characters than 50 and all lines that
+        // Ignore all lines that have less characters than 40 and all lines that
         // start with something that looks like a variable name or code.
-        ignorePattern: '^.{0,50}$|^ [a-z]+ ?[0-9A-Z_.(/=:[#-]',
+        ignorePattern: '^.{0,40}$|^ [a-z]+ ?[0-9A-Z_.(/=:[#-]|^ std',
         ignoreInlineComments: true,
         ignoreConsecutiveComments: true,
       },

.gitignore

@@ -22,9 +22,7 @@ vgcore.*
 v8*.log
 perf.data
 perf.data.old
-.waf*
 tags
-.lock-wscript
 *.pyc
 doc/api.xml
 tmp/
@@ -34,9 +32,7 @@ iojs_g
 node
 node_g
 *.swp
-.benchmark_reports
 icu_config.gypi
-.eslintcache
 node_trace.*.log
 coverage/
 !**/node_modules/**/coverage
@@ -64,8 +60,6 @@ ipch/
 *.opensdf
 *.VC.db
 *.VC.opendb
-.vs/
-.vscode/
 /*.exe
 
 /config.mk
@@ -86,7 +80,6 @@ deps/icu*.tgz
 deps/icu-tmp
 ./node_modules
 android-toolchain/
-.svn/
 
 # generated by gyp on Windows
 deps/openssl/openssl.props

.mailmap

@@ -223,6 +223,7 @@ Leeseean Chiu <leeseean@qq.com>
 Luke Bayes <lbayes@patternpark.com>
 Lydia Kats <llkats@gmail.com> Lydia Katsamberis <llkats@gmail.com>
 Maciej Małecki <maciej.malecki@notimplemented.org> <me@mmalecki.com>
+MaleDong <maledong_github@outlook.com> <maledong_private@qq.com>
 Malte-Thorben Bruns <skenqbx@gmail.com> <skenqbx@googlemail.com>
 Malte-Thorben Bruns <skenqbx@gmail.com> skenqbx <skenqbx@gmail.com>
 Mandeep Singh <mandeep25894@gmail.com> <mandeep.singh@zomato.com>

AUTHORS

@@ -2249,7 +2249,6 @@ Sam Ruby <rubys@intertwingly.net>
 Haroon Khan <aitchkhan@gmail.com>
 Developer Davo <DeveloperDavo@users.noreply.github.com>
 Jacek Pospychała <jacek.pospychala@currency-one.com>
-MaleDong <maledong_private@qq.com>
 iwko <iwoczerniawski@gmail.com>
 Sohail Rajdev <sohailrajdev97@gmail.com>
 Niicck <niicck@users.noreply.github.com>

BUILDING.md

@@ -80,34 +80,25 @@ platforms. This is true regardless of entries in the table below.
 | GNU/Linux    | Tier 1       | kernel >= 2.6.32, glibc >= 2.12 | x64, arm         |                               |
 | GNU/Linux    | Tier 1       | kernel >= 3.10, glibc >= 2.17   | arm64            |                               |
 | macOS/OS X   | Tier 1       | >= 10.11                        | x64              |                               |
-| Windows      | Tier 1       | >= Windows 7/2008 R2/2012 R2    | x86, x64         | [2](#fn2),[3](#fn3),[4](#fn4) |
-| SmartOS      | Tier 2       | >= 15 < 16.4                    | x86, x64         | [1](#fn1)                     |
+| Windows      | Tier 1       | >= Windows 7/2008 R2/2012 R2    | x86, x64         | [1](#fn1),[2](#fn2),[3](#fn3) |
+| SmartOS      | Tier 2       | >= 16                           | x64              |                               |
 | FreeBSD      | Tier 2       | >= 11                           | x64              |                               |
 | GNU/Linux    | Tier 2       | kernel >= 3.13.0, glibc >= 2.19 | ppc64le >=power8 |                               |
 | AIX          | Tier 2       | >= 7.1 TL04                     | ppc64be >=power7 |                               |
 | GNU/Linux    | Tier 2       | kernel >= 3.10, glibc >= 2.17   | s390x            |                               |
 | GNU/Linux    | Experimental | kernel >= 2.6.32, glibc >= 2.12 | x86              | limited CI                    |
 | Linux (musl) | Experimental | musl >= 1.0                     | x64              |                               |
 
-<em id="fn1">1</em>: The gcc4.8-libs package needs to be installed, because node
-  binaries have been built with GCC 4.8, for which runtime libraries are not
-  installed by default. For these node versions, the recommended binaries
-  are the ones available in pkgsrc, not the one available from nodejs.org.
-  Note that the binaries downloaded from the pkgsrc repositories are not
-  officially supported by the Node.js project, and instead are supported
-  by Joyent. SmartOS images >= 16.4 are not supported because
-  GCC 4.8 runtime libraries are not available in their pkgsrc repository
-
-<em id="fn2">2</em>: Tier 1 support for building on Windows is only on 64-bit
+<em id="fn1">1</em>: Tier 1 support for building on Windows is only on 64-bit
   hosts. Support is experimental for 32-bit hosts.
 
-<em id="fn3">3</em>: On Windows, running Node.js in Windows terminal emulators
+<em id="fn2">2</em>: On Windows, running Node.js in Windows terminal emulators
   like `mintty` requires the usage of [winpty](https://github.com/rprichard/winpty)
   for the tty channels to work correctly (e.g. `winpty node.exe script.js`).
   In "Git bash" if you call the node shell alias (`node` without the `.exe`
   extension), `winpty` is used automatically.
 
-<em id="fn4">4</em>: The Windows Subsystem for Linux (WSL) is not directly
+<em id="fn3">3</em>: The Windows Subsystem for Linux (WSL) is not directly
   supported, but the GNU/Linux build process and binaries should work. The
   community will only address issues that reproduce on native GNU/Linux
   systems. Issues that only reproduce on WSL should be reported in the

CHANGELOG.md

@@ -28,7 +28,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V11.md#11.10.1">11.10.1</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V11.md#11.11.0">11.11.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V11.md#11.10.1">11.10.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V11.md#11.10.0">11.10.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V11.md#11.9.0">11.9.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V11.md#11.8.0">11.8.0</a><br/>

COLLABORATOR_GUIDE.md

@@ -312,58 +312,46 @@ For pull requests introducing new core modules:
 
 ### Additions to N-API
 
-N-API provides an ABI-stable API guaranteed for future Node.js versions.
-Existing N-API APIs cannot change or disappear, even in semver-major releases.
-Thus, N-API additions call for unusual care and scrutiny.
-
-This
-[guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md)
-outlines the requirements and principles that we should follow when
-approving and landing new N-API APIs (any additions to `node_api.h` and
-`node_api_types.h`).
+N-API provides an ABI-stable API guaranteed for future Node.js versions. N-API
+additions call for unusual care and scrutiny. If a change adds to `node_api.h`
+or `node_api_types.h`, consult [the relevant
+guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md).
 
 ### Deprecations
 
-[_Deprecation_][] is "the discouragement of use of some … feature … or practice,
-typically because it has been superseded or is no longer considered efficient or
-safe, without completely removing it or prohibiting its use. It can also imply
-that a feature, design, or practice will be removed or discontinued entirely in
-the future."
-
-Node.js uses three Deprecation levels:
-
-* *Documentation-Only Deprecation*: A deprecation notice is added to the API
-  documentation but no functional changes are implemented in the code. By
-  default, there will be no warnings emitted for such deprecations at
-  runtime. Documentation-only deprecations may trigger a runtime warning when
-  Node.js is started with the [`--pending-deprecation`][] flag or the
-  `NODE_PENDING_DEPRECATION=1` environment variable is set.
-
-* *Runtime Deprecation*: A warning is emitted at runtime the first time that a
-  deprecated API is used. The [`--throw-deprecation`][] flag can be used to
-  escalate such warnings into runtime errors that will cause the Node.js process
-  to exit. As with Documentation-Only Deprecation, the documentation for the API
-  must be updated to clearly indicate the deprecated status.
-
-* *End-of-life*: The API is no longer subject to the semantic versioning rules.
-  Backward-incompatible changes including complete removal of such APIs may
-  occur at any time.
-
-Documentation-Only Deprecations may be handled as semver-minor or semver-major
-changes. Such deprecations have no impact on the successful operation of running
-code and therefore should not be viewed as breaking changes.
-
-Runtime Deprecations and End-of-life APIs (internal or public) must be
-handled as semver-major changes unless there is TSC consensus to land the
-deprecation as a semver-minor.
-
-All Documentation-Only and Runtime deprecations will be assigned a unique
-identifier that can be used to persistently refer to the deprecation in
-documentation, emitted process warnings, or errors thrown. Documentation for
-these identifiers will be included in the Node.js API documentation and will
-be immutable once assigned. Even if End-of-Life code is removed from Node.js,
-the documentation for the assigned deprecation identifier must remain in the
-Node.js API documentation.
+Node.js uses three [Deprecation][] levels. For all deprecated APIs, the API
+documentation must state the deprecation status.
+
+* Documentation-Only Deprecation
+  * A deprecation notice appears in the API documentation.
+  * There are no functional changes.
+  * By default, there will be no warnings emitted for such deprecations at
+    runtime.
+  * May cause a runtime warning with the [`--pending-deprecation`][] flag or
+    `NODE_PENDING_DEPRECATION` environment variable.
+
+* Runtime Deprecation
+  * Emits a warning at runtime on first use of the deprecated API.
+  * If used with the [`--throw-deprecation`][] flag, will throw a runtime error.
+
+* End-of-life
+  * The API is no longer subject to the semantic versioning rules.
+  * Backward-incompatible changes including complete removal of such APIs may
+    occur at any time.
+
+Apply the `notable change` label to all pull requests that introduce
+Documentation-Only Deprecations. Such deprecations have no impact on code
+execution. Thus, they are not breaking changes (`semver-major`).
+
+Runtime Deprecations and End-of-life APIs (internal or public) are breaking
+changes (`semver-major`). The TSC may make exceptions, deciding that one of
+these deprecations is not a breaking change.
+
+All deprecations receive a unique and immutable identifier. Documentation,
+warnings, and errors use the identifier when referring to the deprecation. The
+documentation for the assigned deprecation identifier must always remain in the
+API documentation. This is true even if the deprecation is no longer in use (for
+example, due to removal of an End-of-Life deprecated API).
 
 <a id="deprecation-cycle"></a>
 A _Deprecation cycle_ is a major release during which an API has been in one of
@@ -800,9 +788,9 @@ When things need extra attention, are controversial, or `semver-major`:
 If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.
 
 ["Merge Pull Request"]: https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-on-github
+[Deprecation]: https://en.wikipedia.org/wiki/Deprecation
 [Stability Index]: doc/api/documentation.md#stability-index
 [TSC]: https://github.com/nodejs/TSC
-[_Deprecation_]: https://en.wikipedia.org/wiki/Deprecation
 [`--pending-deprecation`]: doc/api/cli.md#--pending-deprecation
 [`--throw-deprecation`]: doc/api/cli.md#--throw-deprecation
 [`node-core-utils`]: https://github.com/nodejs/node-core-utils

Makefile

@@ -1184,8 +1184,12 @@ lint-js-fix:
 # Note that on the CI `lint-js-ci` is run instead.
 # Lints the JavaScript code with eslint.
 lint-js:
-	@echo "Running JS linter..."
-	@$(call available-node,$(run-lint-js))
+	@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
+		echo "Skipping $@ (no crypto)"; \
+	else \
+		echo "Running JS linter..."; \
+		$(call available-node,$(run-lint-js)) \
+	fi
 
 jslint: lint-js
 	@echo "Please use lint-js instead of jslint"
@@ -1262,11 +1266,8 @@ else
 	@echo "To install (requires internet access) run: $ make format-cpp-build"
 endif
 
-ifeq ($(V),1)
-  CPPLINT_QUIET =
-else
-  CPPLINT_QUIET = --quiet
-endif
+CPPLINT_QUIET = --quiet
+
 .PHONY: lint-cpp
 # Lints the C++ code with cpplint.py and check-imports.py.
 lint-cpp: tools/.cpplintstamp

README.md

@@ -184,8 +184,6 @@ For information about the governance of the Node.js project, see
 **Jeremiah Senkpiel** <fishrock123@rocketmail.com>
 * [gabrielschulhof](https://github.com/gabrielschulhof) -
 **Gabriel Schulhof** <gabriel.schulhof@intel.com>
-* [jasnell](https://github.com/jasnell) -
-**James M Snell** <jasnell@gmail.com> (he/him)
 * [joyeecheung](https://github.com/joyeecheung) -
 **Joyee Cheung** <joyeec9h3@gmail.com> (she/her)
 * [mcollina](https://github.com/mcollina) -
@@ -219,6 +217,8 @@ For information about the governance of the Node.js project, see
 **Fedor Indutny** <fedor.indutny@gmail.com>
 * [isaacs](https://github.com/isaacs) -
 **Isaac Z. Schlueter** <i@izs.me>
+* [jasnell](https://github.com/jasnell) -
+**James M Snell** <jasnell@gmail.com> (he/him)
 * [joshgav](https://github.com/joshgav) -
 **Josh Gavant** <josh.gavant@outlook.com>
 * [mscdex](https://github.com/mscdex) -

benchmark/_cli.js

@@ -28,7 +28,7 @@ function CLI(usage, settings) {
   }
 
   let currentOptional = null;
-  let mode = 'both'; // possible states are: [both, option, item]
+  let mode = 'both'; // Possible states are: [both, option, item]
 
   for (const arg of process.argv.slice(2)) {
     if (arg === '--') {
@@ -59,7 +59,7 @@ function CLI(usage, settings) {
         this.optional[currentOptional] = arg;
       }
 
-      // the next value can be either an option or an item
+      // The next value can be either an option or an item
       mode = 'both';
     } else if (['both', 'item'].includes(mode)) {
       // item arguments

benchmark/crypto/cipher-stream.js

@@ -15,7 +15,7 @@ function main({ api, cipher, type, len, writes }) {
     cipher = 'AES192';
   if (api === 'stream' && /^v0\.[0-8]\./.test(process.version)) {
     console.error('Crypto streams not available until v0.10');
-    // use the legacy, just so that we can compare them.
+    // Use the legacy, just so that we can compare them.
     api = 'legacy';
   }
 

benchmark/crypto/hash-stream-creation.js

@@ -16,7 +16,7 @@ const bench = common.createBenchmark(main, {
 function main({ api, type, len, out, writes, algo }) {
   if (api === 'stream' && /^v0\.[0-8]\./.test(process.version)) {
     console.error('Crypto streams not available until v0.10');
-    // use the legacy, just so that we can compare them.
+    // Use the legacy, just so that we can compare them.
     api = 'legacy';
   }
 
@@ -54,7 +54,7 @@ function legacyWrite(algo, message, encoding, writes, len, outEnc) {
     h.update(message, encoding);
     var res = h.digest(outEnc);
 
-    // include buffer creation costs for older versions
+    // Include buffer creation costs for older versions
     if (outEnc === 'buffer' && typeof res === 'string')
       res = Buffer.from(res, 'binary');
   }

benchmark/crypto/hash-stream-throughput.js

@@ -15,7 +15,7 @@ const bench = common.createBenchmark(main, {
 function main({ api, type, len, algo, writes }) {
   if (api === 'stream' && /^v0\.[0-8]\./.test(process.version)) {
     console.error('Crypto streams not available until v0.10');
-    // use the legacy, just so that we can compare them.
+    // Use the legacy, just so that we can compare them.
     api = 'legacy';
   }
 

benchmark/crypto/rsa-encrypt-decrypt-throughput.js

@@ -1,5 +1,5 @@
 'use strict';
-// throughput benchmark in signing and verifying
+// Throughput benchmark in signing and verifying
 const common = require('../common.js');
 const crypto = require('crypto');
 const fs = require('fs');

benchmark/crypto/rsa-sign-verify-throughput.js

@@ -1,5 +1,5 @@
 'use strict';
-// throughput benchmark in signing and verifying
+// Throughput benchmark in signing and verifying
 const common = require('../common.js');
 const crypto = require('crypto');
 const fs = require('fs');

benchmark/fs/read-stream-throughput.js

@@ -1,4 +1,4 @@
-// test the throughput of the fs.WriteStream class.
+// Test the throughput of the fs.WriteStream class.
 'use strict';
 
 const path = require('path');

benchmark/fs/write-stream-throughput.js

@@ -1,4 +1,4 @@
-// test the throughput of the fs.WriteStream class.
+// Test the throughput of the fs.WriteStream class.
 'use strict';
 
 const path = require('path');