Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: only destroy socket once error is sent #26356

Closed
wants to merge 1 commit into from
Closed

http: only destroy socket once error is sent #26356

wants to merge 1 commit into from

Commits on Feb 28, 2019

  1. http: only destroy socket once error is sent 

    This patch fixes a race condition: sometimes the socket is
destroyed before the data is sent. If node is proxied by, for
example, an AWS ELB, a 504 error would be returned instead
of the expected 400.
    @yannh
    yannh committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    1d39742 View commit details
    Browse the repository at this point in the history