Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

napi: Improve performance creating strings #26439

Closed
wants to merge 4 commits into from
Closed

napi: Improve performance creating strings #26439

wants to merge 4 commits into from

Commits on Mar 4, 2019

  1. Improve performance creating strings using N-API by ensuring that the… 

    … strings

are not internalized (see Node issue #26437).
    @anthony-tuininga
    anthony-tuininga committed Mar 4, 2019
    Copy the full SHA
    ca9ea3a View commit details
    Browse the repository at this point in the history

  2. Add missing check.

    @anthony-tuininga
    anthony-tuininga committed Mar 4, 2019
    Copy the full SHA
    b94b312 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. Add checks on length to other two string creation methods.

    @anthony-tuininga
    anthony-tuininga committed Mar 5, 2019
    Copy the full SHA
    64171a9 View commit details
    Browse the repository at this point in the history

  2. Added test cases for verifying additional checks on latin-1 and utf-1… 

    …6 string

sizes.
    @anthony-tuininga
    anthony-tuininga committed Mar 5, 2019
    Copy the full SHA
    ed195b6 View commit details
    Browse the repository at this point in the history