Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] tls: fix legacy SecurePair clienthello race window #26452

Closed
wants to merge 2 commits into from
Closed

[8.x] tls: fix legacy SecurePair clienthello race window #26452

wants to merge 2 commits into from

Commits on Mar 5, 2019

  1. tls: fix legacy SecurePair session resumption 

    This seems to have been broken ever since its introduction 5 years ago
in commit 75ea11f ("tls: introduce asynchronous `newSession`") and
no one complained but that's not going to stop me from fixing it anyway
because otherwise I can't write a regression test for issue nodejs#26428.

Refs: nodejs#26428
    @bnoordhuis
    bnoordhuis committed Mar 5, 2019
    Copy the full SHA
    a061190 View commit details
    Browse the repository at this point in the history

  2. tls: fix legacy SecurePair clienthello race window 

    There is a time window between the first and the last step of processing
the clienthello event and the SecurePair may have been destroyed during
that interval.

Fixes: nodejs#26428
    @bnoordhuis
    bnoordhuis committed Mar 5, 2019
    Copy the full SHA
    8ec39b8 View commit details
    Browse the repository at this point in the history