Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix skipping of flaky tests on Travis #26968

Closed
wants to merge 1 commit into from
Closed

build: fix skipping of flaky tests on Travis #26968

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Mar 28, 2019 •
edited

PARALLEL_ARGS is overwritten in the Makefile if JOBS is set.

node/Makefile

Lines 20 to 24 in 2c73868

ifdef JOBS
PARALLEL_ARGS = -j $(JOBS)
else
PARALLEL_ARGS = -J
endif

Use CI_JS_SUITES instead.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau
build: fix skipping of flaky tests on Travis
724fc8d 
`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use
`CI_JS_SUITES` instead.
@nodejs-github-bot
Copy link
Collaborator

@richardlau Sadly, an error occurred when I tried to trigger a build. :(

@richardlau richardlau mentioned this pull request Mar 28, 2019
Open
@richardlau
Copy link
Member Author

Travis tests are currently failing because of a flaky test (test-worker-prof.js, #26401) which it shouldn't be running. This PR should hopefully get Travis green again.

@richardlau
Copy link
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3089/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2019
@richardlau richardlau mentioned this pull request Mar 28, 2019
Merged
4 tasks
@richardlau richardlau mentioned this pull request Mar 30, 2019
Closed
2 tasks
@richardlau
Copy link
Member Author

Closing in favour of #27002 which includes the commit from this PR.

@richardlau richardlau closed this Mar 30, 2019
@richardlau richardlau deleted the travis-skip-flaky-tests branch March 30, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardlau @nodejs-github-bot @Trott @BridgeAR