Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] assert: fix backport regression #27202

Closed
wants to merge 1 commit into from
Closed

[v8.x] assert: fix backport regression #27202

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This fixes a regression for an error case with assert.rejects and
assert.doesNotReject.

Fixes: #27185

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
assert: fix backport regression
7ce9361 
This fixes a regression for an error case with `assert.rejects` and
`assert.doesNotReject`.

Fixes: nodejs#27185
@BridgeAR BridgeAR added the v8.x label Apr 12, 2019
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3236

@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Apr 12, 2019
@BridgeAR BridgeAR mentioned this pull request Apr 12, 2019
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22390/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22425/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22454/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22460/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22472/

MylesBorins pushed a commit that referenced this pull request Apr 16, 2019
@BridgeAR @MylesBorins
assert: fix backport regression
705935d 
This fixes a regression for an error case with `assert.rejects` and
`assert.doesNotReject`.

Fixes: #27185

PR-URL: #27202
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@MylesBorins
Copy link
Member

landed in 705935d

@BridgeAR BridgeAR deleted the fix-assert-error-v8 branch January 20, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BridgeAR @nodejs-github-bot @MylesBorins @lpinca @BethGriggs