Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] deps: V8: backport d520ebb #27358

Closed
wants to merge 1 commit into from
Closed

[v8.x] deps: V8: backport d520ebb #27358

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 23, 2019

Original commit message:

[turbofan] Fix NumberFloor typing.

Bug: chromium:841117
Change-Id: I1e83dfc82f87d0b49d3cca96290ae1d738e37d20
Reviewed-on: https://chromium-review.googlesource.com/1051228
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53083}

Refs: v8/v8@d520ebb
Fixes: #22810

@targos
deps: V8: backport d520ebb
f2b7e47 
Original commit message:

    [turbofan] Fix NumberFloor typing.

    Bug: chromium:841117
    Change-Id: I1e83dfc82f87d0b49d3cca96290ae1d738e37d20
    Reviewed-on: https://chromium-review.googlesource.com/1051228
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53083}

Refs: v8/v8@d520ebb
Fixes: nodejs#22810
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3333

@nodejs-github-bot nodejs-github-bot added v8 engine Issues and PRs related to the V8 dependency. v8.x labels Apr 23, 2019
@targos targos changed the title deps: V8: backport d520ebb [v8.x] deps: V8: backport d520ebb Apr 23, 2019
@targos targos mentioned this pull request Apr 23, 2019
Closed
@targos
Copy link
Member Author

targos commented Apr 23, 2019

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2249/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23463/

@sam-github sam-github closed this Jun 5, 2019
@targos
Copy link
Member Author

targos commented Jun 5, 2019

@sam-github why did you close this?

@BridgeAR BridgeAR reopened this Jun 5, 2019
@sam-github
Copy link
Contributor

@targos I closed it by mistake, sorry!

@targos
Copy link
Member Author

targos commented Jun 11, 2019

@nodejs/backporters

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25541/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25544/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 19, 2019 •
edited by BethGriggs

CI: https://ci.nodejs.org/job/node-test-pull-request/25571/ ✅

BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
@targos @BethGriggs
deps: V8: backport d520ebb
37e24b1 
Original commit message:

    [turbofan] Fix NumberFloor typing.

    Bug: chromium:841117
    Change-Id: I1e83dfc82f87d0b49d3cca96290ae1d738e37d20
    Reviewed-on: https://chromium-review.googlesource.com/1051228
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53083}

Refs: v8/v8@d520ebb
Fixes: #22810

PR-URL: #27358
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs
Copy link
Member

Landed on v8.x-staging

@BethGriggs BethGriggs closed this Sep 19, 2019
@targos targos deleted the fix-22810 branch September 19, 2019 13:47
@BethGriggs BethGriggs mentioned this pull request Sep 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@refack refack refack approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@targos @nodejs-github-bot @sam-github @BethGriggs @apapirovski @refack @cjihrig @BridgeAR