v12.3.0 proposal #27799
Merged
v12.3.0 proposal #27799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the error message visible in the error stack created when using `assert.fail()` without any arguments or the message set to `undefined` or `null` as only argument. That was masked before due to other changes. PR-URL: #27525 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This makes sure that the error message is more appropriate than before by checking closer what operator is used and which is not. It also increases the total number of lines printed to the user. PR-URL: #27525 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This reduces the total amount of reads when using `assert.ok()` with a falsy value. That increases the read performance significantly. Also remove a comment that can not be addressed. PR-URL: #27525 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
`socket.destroy()` can destory the stream before the chunk to write with `socket.end()` is actually sent. Furthermore `socket.destroy()` destroys `p` and not the actual raw socket. As a result it is possible that the connection is left open. Remove `socket.destroy()` to ensure that the chunk is sent. Also use `common.mustCall()` to ensure that the `'secureConnection'` and `'secureConnect'` events are emitted exactly once. PR-URL: #27478 Fixes: #26938 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Applications should never attempt to use the deciphered message if authentication fails. In reality, this is usually not a problem since OpenSSL does not disclose the plaintext in this case, but it is still a design mistake and can lead to critical security problems in other cipher modes and implementations. PR-URL: #27396 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Update the documentation for test execution for tests in a single file PR-URL: #27561 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The following error is emitted in a nondeterministic way on the server
side socket on macOS:
```
events.js:173
throw er; // Unhandled 'error' event
^
Error: read ECONNRESET
at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at processTicksAndRejections (internal/process/task_queues.js:84:9)
```
Prevent the error from being emitted by moving the `socket.end()` call
to the client. Also, run tests in parallel and use `common.mustCall()`.
PR-URL: #27569
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
PR-URL: #27553 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
When running the REPL as standalone program it's now possible to use
`process.on('uncaughtException', listener)`. It is going to use those
listeners from now on and the regular error output is suppressed.
It also fixes the issue that REPL instances started inside of an
application would silence all application errors. It is now prohibited
to add the exception listener in such REPL instances. Trying to add
such listeners throws an `ERR_INVALID_REPL_INPUT` error.
Fixes: #19998
PR-URL: #27151
Fixes: #19998
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #27580 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Voted on async in the TSC repo. This adds him to the TSC list in the README. Fixes: nodejs/TSC#687 PR-URL: #27606 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
1. Do not rely on a string comparison to identify when the frontend is ready to run and override a callback instead. 2. Remove unused boolean flag. PR-URL: #27591 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Node.js compiles them, their existence is indicated by OpenSSL header defines, but they can't be linked to on Windows because their symbols are not exported. Export them. Fixes: #27494 PR-URL: #27586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #27498 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Alexis confirmed in email that that they should be moved to the Emeriti list. PR-URL: #27626 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Minqi Pan confirmed in email that they were fine with being moved to Collaborator Emeritus. PR-URL: #27602 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
AnnaMag hasn't authored/landed/reviewed code in quite some time. I sent them an email asking about becoming Emeritus but did not get a response. It's easy enough to re-onboard someone back to active status if they become active again, so I think this is a pretty safe change to make. I'll specifically request a review of this change from them so they get notified and can comment/review/block/approve/etc. this. PR-URL: #27603 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Use camelcasing in tools/doc/apilinks.js. PR-URL: #27607 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #27607 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #27633 Refs: nodejs/create-node-meeting-artifacts#63 Refs: nodejs/email#142 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #27562 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
In node_worker.cc there are few instances where v8 namespaced entitites are used inline. Elevate them with `using` semantics. PR-URL: #27568 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #27616 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
test/wpt/test-timers.js does not appear to need the `--expose-internals` flag. Remove it. PR-URL: #27608 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue. PR-URL: #27615 Refs: v8/v8@7.4.288.21...7.4.288.27 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: v8/v8@7.4.288.21...7.4.288.27 PR-URL: #27615 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ERR_INVALID_OPT_VALUE cannot be constructed without new. PR-URL: #27614 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #27614 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit adds input validation to require.resolve()'s paths option. Prior to this change, passing in a non-array value lead to a misleading 'module not found' error. Refs: #27583 PR-URL: #27613 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #27760 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Within tls.md, the documentation for the response of tlsSocket.getPeerCertificate() included subjectaltname documented as an array of values. However these values are actually returned as a single string of concatenated values. The documentation has been updated to reflect this. PR-URL: #27757 Fixes: #27721 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This comment has been minimized.
This comment has been minimized.
|
/cc @nodejs/collaborators @nodejs/tsc @nodejs/releasers |
|
@BridgeAR don't forget the PR-URL in the commit description |
|
#27659 is probably a notable change. I just added the semver-minor label |
BridgeAR
force-pushed
the
v12.3.0-proposal
branch
from
e0afe0e
to
20c11be
Compare
|
@targos I updated the release notes accordingly. PTAL |
targos
approved these changes
May 21, 2019
Notable changes:
* esm:
* Added the `--experimental-wasm-modules` flag to support
WebAssembly modules (Myles Borins & Guy Bedford)
#27659
* process:
* Log errors using `util.inspect` in case of fatal exceptions
(Ruben Bridgewater) #27243
* repl:
* Add `process.on('uncaughtException')` support (Ruben Bridgewater)
#27151
* stream:
* Implemented `Readable.from` async iterator utility (Guy Bedford)
#27660
* tls:
* Expose built-in root certificates (Ben Noordhuis)
#26415
* Support `net.Server` options (Luigi Pinca)
#27665
* Expose `keylog` event on TLSSocket (Alba Mendez)
#27654
* worker:
* Added the ability to unshift messages from the `MessagePort`
(Anna Henningsen) #27294
PR-URL: #27799
|
I stopped CITGM (AIX has trouble running the tests and everything was done besides AIX timing out on every module) and I am not sure if something might be related to the changes here or not. I do not know anything about the following failures: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1854/nodes=fedora-latest-x64/testReport/junit/(root)/citgm/binary_split/ Ping @targos |
|
New CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1855/ (without AIX) |
ZYSzys
approved these changes
May 21, 2019
BridgeAR
added a commit
that referenced
this pull request
May 21, 2019
Notable changes:
* esm:
* Added the `--experimental-wasm-modules` flag to support
WebAssembly modules (Myles Borins & Guy Bedford)
#27659
* process:
* Log errors using `util.inspect` in case of fatal exceptions
(Ruben Bridgewater) #27243
* repl:
* Add `process.on('uncaughtException')` support (Ruben Bridgewater)
#27151
* stream:
* Implemented `Readable.from` async iterator utility (Guy Bedford)
#27660
* tls:
* Expose built-in root certificates (Ben Noordhuis)
#26415
* Support `net.Server` options (Luigi Pinca)
#27665
* Expose `keylog` event on TLSSocket (Alba Mendez)
#27654
* worker:
* Added the ability to unshift messages from the `MessagePort`
(Anna Henningsen) #27294
PR-URL: #27799
BridgeAR
added a commit
to BridgeAR/nodejs.org
that referenced
this pull request
May 21, 2019
BridgeAR
added a commit
to nodejs/nodejs.org
that referenced
this pull request
May 21, 2019
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes
--experimental-wasm-modulesflag to support WebAssembly modules (Myles Borins & Guy Bedford) #27659util.inspectin case of fatal exceptions (Ruben Bridgewater) #27243process.on('uncaughtException')support (Ruben Bridgewater) #27151Readable.fromasync iterator utility (Guy Bedford) #27660net.Serveroptions (Luigi Pinca) #27665keylogevent on TLSSocket (Alba Mendez) #27654MessagePort(Anna Henningsen) #27294Commits
7cc21d8afa] - assert: remove unused code (Ruben Bridgewater) #276766983a0c336] - assert: add compatibility for older Node.js versions (Ruben Bridgewater) #27672493ead144d] - assert: loose deep equal should not compare symbol properties (Ruben Bridgewater) #27653ec642f18cc] - assert: use less read operations (Ruben Bridgewater) #275253367bad080] - assert: refine assertion message (Ruben Bridgewater) #27525e573c99bfd] - assert: fixassert.fail()stack (Ruben Bridgewater) #275256070e8872d] - async_hooks: don't reuse resource in HttpAgent (Gerhard Stoebich) #27581e74e661044] - async_hooks: only disable promise hook if wanted (Anna Henningsen) #27590026bebfcbc] - bootstrap: --frozen-intrinsics unfreeze console (Guy Bedford) #27663e0589006a8] - build: add arm64 to vcbuild.bat help message (Jon Kunkee) #27683766a731137] - build: export OpenSSL UI symbols (Sam Roberts) #275862bc177aa4f] - child_process: setup stdio on error when possible (cjihrig) #27696b380c0f311] - child_process: refactor stdioStringToArray function (zero1five) #27657da102cda54] - console: don't attach unnecessary error handlers (cjihrig) #2769183f243038f] - deps: V8: cherry-pick cca9ae3c9a (Benedikt Meurer) #27729750556dcfd] - deps: update OpenSSL configs' timestamps (Jon Kunkee) #27544314fdda0c3] - deps: regenerate OpenSSL configs with fixed tooling (Jon Kunkee) #27544c7e5fca32c] - deps: make VC-WIN config generation deterministic (Jon Kunkee) #2754376c9e86609] - deps: patch V8 to 7.4.288.27 (Matheus Marchini) #276159f5b6900e7] - doc: corrected tlsSocket.getPeerCertificate response type (Dan Beglin) #27757d1da11765d] - doc: correct parameter type on 'subprocess.kill([signal])' (himself65) #277607e750868c6] - doc: replace createRequireFromPath() references (cjihrig) #2776255fe340dc2] - doc: improve createRequire() example (cjihrig) #27762378f44c2ed] - doc: updateutil.formatformatters documentation (Ruben Bridgewater) #27621f663e74d0b] - doc: remove stability highlight for stable functions (Michael Dawson) #27753cf516f7b6a] - doc: rewrite "About this Documentation" section (Rich Trott) #27725df01645c7c] - doc: correct entry for electron v4.0.4 (Jacob) #273941f7a527f04] - doc: clarify behavior of fs.mkdir (Gaelan) #27505d570995427] - doc: remove non-existent entry-type flag (dnalborczyk) #27678da4a3797cb] - doc: format correction for experimental loader hooks (Daniel Nalborczyk) #27537cc45080109] - doc: dns.lookup() documentation error code (jvelezpo) #276257923b4a407] - doc: add call-once note to napi_queue_async_work (Gabriel Schulhof) #275828d448be9fd] - doc: simplify test/README.md (Rich Trott) #27630172fa639a6] - doc: simplify About This Documentation text (Rich Trott) #2761966cf89f57d] - doc: move Rod Vagg to TSC emeritus (Rod Vagg) #276338a1f2d0bfc] - doc: doc deprecate the legacy http parser (cjihrig) #27498a23e86f029] - doc: add Sam Roberts to TSC (Rod Vagg) #27606c53a674be7] - doc: add example to test doc for clarity (Aditya Pratap Singh) #27561c0cdf30e6e] - doc: improve CCM example (Tobias Nießen) #27396b5498ed19b] - doc,meta: codify security release commit message (Richard Lau) #276436e2c8d0e18] - doc,n-api: update N-API version matrix for v12.x (Richard Lau) #27745767889b0a3] - doc,n-api: fixintroduced\_inmetadata (Richard Lau) #277454ed8a9ba7e] - doc,tools: updates for 6.x End-of-Life (Richard Lau) #2765880f30741bd] - esm: use correct error arguments (cjihrig) #2776347f913bedc] - (SEMVER-MINOR) esm: --experimental-wasm-modules integration support (Myles Borins) #2765989fda94b6a] - esm: fix esm load bug (ZYSzys) #254911f935f899f] - events: improve max listeners warning (Ruben Bridgewater) #276946f23816bcf] - fs: extract path conversion and validation to getValidatedPath (ZYSzys) #27656206ae31a7e] - http: always call response.write() callback (Luigi Pinca) #27709bfb9356942] - http: do not default to chunked encoding for TRACE (Luigi Pinca) #276734a9af1778d] - http: add an alias at addListener on Server connection socket (himself65) #27325a66b391d20] - http2: do no throw in writeHead if state.closed (Matteo Collina) #2768274046cee72] - http2: do not override the allowHalfOpen option (Luigi Pinca) #27623c7461567ce] - inspector: mark profile type const (gengjiawen) #2771224b26c0687] - inspector: fix typo (gengjiawen) #27712700459e008] - inspector: added NodeRuntime domain (Aleksei Koziatinskii) #27600d2d3bf8b3b] - inspector: code cleanup (Eugene Ostroukhov) #275914dbebfd464] - lib: fix typo in pre_execution.js (gengjiawen) #2764988b4d00fc6] - lib: restoreglobal.moduleafter --eval code is run (Anna Henningsen) #275873ac4a7122b] - meta: move jhamhader to Collaborator Emeriti list (Rich Trott) #277079f9871c4b2] - meta: move chrisdickinson to Collaborator Emeriti list (Rich Trott) #277032e85642f4a] - meta: move whitlockjc to Collaborator Emeriti list (Rich Trott) #27702fc8ad7731f] - meta: move estliberitas to Collaborator Emeriti list (Rich Trott) #27697ea62149212] - meta: move firedfox to Collaborator Emeriti list (Rich Trott) #276186bef4c0083] - meta: move AnnaMag to Collaborator Emeriti list (Rich Trott) #2760314d58c2f95] - meta: move pmq20 to Collaborator Emeriti list (Rich Trott) #27602876441eefb] - meta: move orangemocha to Collaborator Emeriti list (Rich Trott) #27626140b44f3ea] - module: fix createRequireFromPath() slash logic (cjihrig) #276348a96182827] - module: add missing space in error message (cjihrig) #27627c33e83497e] - module: simplify createRequire() validation (cjihrig) #27629119a590f84] - module: improve resolve paths validation (cjihrig) #276132f512e32a7] - module: handle relative paths in resolve paths (cjihrig) #2759874feb0b81e] - process: mark process.env as side-effect-free (Anna Henningsen) #276840393045198] - (SEMVER-MINOR) process: inspect error in case of a fatal exception (Ruben Bridgewater) #27243688a0bd2b8] - repl: do not run --eval code if there is none (Anna Henningsen) #27587c78de13238] - (SEMVER-MINOR) repl: handle uncaughtException properly (Ruben Bridgewater) #27151d21e066f5a] - src: update UNREACHABLE macro to take a string (Nitish Sakhawalkar) #26502ae8b64df78] - src: remove util-inl.h from header files (Sam Roberts) #27631e736e20e87] - src: declare unused priv argument (Sam Roberts) #27631d2e1efe8a3] - src: fix warnings about redefined BSWAP macros (Sam Roberts) #276313c707976da] - src: remove extra semicolons after macros (gengjiawen) #27579a18692c4df] - src: extract common macro to util.h (gengjiawen) #27512f6642e90b2] - src: elevate namespaces in node_worker.cc (Preveen Padmanabhan) #2756862fe3422fb] - src: refactor deprecated UVException usage in pipe-wrap.cc (gengjiawen) #27562b338d53916] - src: fix typos (gengjiawen) #2758032fd0ac901] - stream: use readableObjectMode public api for js stream (Anto Aravinth) #2765505c3d53ecc] - (SEMVER-MINOR) stream: implement Readable.from async iterator utility (Guy Bedford) #27660f872210ffd] - test: relax check in verify-graph (Gerhard Stoebich) #277428b4101a97f] - test: un-mark worker syntax error tests as flaky (Anna Henningsen) #277051757250997] - test: clearing require cache crashes esm loader (Antoine du HAMEL) #254917252a64a23] - test: pass null params to napi_xxx_property() (Octavian Soldea) #276289ed5882dec] - test: use common.PORT instead of an extraneous variable (Benjamin Ki) #27565f01183c29a] - test: move dgram invalid host test to internet tests (Benjamin Ki) #275658cba1affe3] - test: better assertion for async hook tests (Ali Ijaz Sheikh) #276010c7f18ebd3] - test: test error when breakOnSigint is not a boolean for evaluate (Ruwan Geeganage) #275033801859032] - test: add tests for hasItems method in FreeList (Ruwan Geeganage) #27588691866f124] - test: fix test-linux-perf flakiness (Matheus Marchini) #27615d7fcd75f62] - test: remove unneeded--expose-internals(Rich Trott) #27608815a95734e] - test: refactor test-tls-enable-trace-cli.js (cjihrig) #27553b6e540a9a2] - test: fix flaky test-tls-multiple-cas-as-string (Luigi Pinca) #27569a5dab9e85a] - test: deflake test-tls-js-stream (Luigi Pinca) #27478bdd75d0622] - (SEMVER-MINOR) tls: expose built-in root certificates (Ben Noordhuis) #26415e61823c43a] - (SEMVER-MINOR) tls: supportnet.Serveroptions (Luigi Pinca) #27665eb1f4e50c7] - (SEMVER-MINOR) tls: expose keylog event on TLSSocket (Alba Mendez) #276546624f802d9] - tls: fix createSecureContext() cipher list filter (Sam Roberts) #27614b8b02c35ee] - tls: add missing 'new' (cjihrig) #27614a8a11862e0] - tools: update markdown linter for Windows line endings (Rich Trott) #27756c3d16756f2] - tools: remove unneeded dependency files (Rich Trott) #277300db846f734] - tools: refactor js2c.py for maximal Python3 compatibility (Refael Ackermann) #255180e16b352b4] - tools: decrease code duplication for isString() in lint rules (cjihrig) #2771947184d1a0a] - tools: update capitalized-comments eslint rule (Ruben Bridgewater) #27675ea62f4a820] - tools: update dmn to 2.2.2 (Rich Trott) #27686d2dad0b4b8] - tools: DRY isRequireCall() in lint rules (cjihrig) #276801b8bc77990] - tools: add12.xto alternative docs versions (Richard Lau) #276581365683c23] - tools: allow RegExp in required-modules eslint rule (Richard Lau) #27647169ddc5097] - tools: force common be required before any other modules (ZYSzys) #27650c6ab6b279c] - tools: enable block-scoped-var eslint rule (Roman Reiss) #27616fd823ea7a8] - tools: enable camelcase linting in tools (Rich Trott) #27607217e6b5a06] - tools: switch to camelcasing in apilinks.js (Rich Trott) #2760710b4a8103d] - util: if present, fallback totoStringusing the %s formatter (Ruben Bridgewater) #276215205902762] - util: remove outdated comment (Ruben Bridgewater) #27733099c9ce1a1] - util: unify constructor inspection inutil.inspect(Ruben Bridgewater) #27733d8b48675a7] - util: simplify inspection limit handling (Ruben Bridgewater) #277336984ca1c2f] - util: reconstruct constructor in more cases (Ruben Bridgewater) #276688f48edd28f] - vm: mark global proxy as side-effect-free (Anna Henningsen) #27523c7cf8d9b74] - (SEMVER-MINOR) worker: add ability to unshift message from MessagePort (Anna Henningsen) #27294e004d427ce] - worker: use special message as MessagePort close command (Anna Henningsen) #27705b7ed4d7187] - worker: movereceiving\_messages\_field toMessagePort(Anna Henningsen) #27705Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes