Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 7.6 #28016

Closed
wants to merge 20 commits into from
Closed

deps: update V8 to 7.6 #28016

wants to merge 20 commits into from

Commits on Aug 1, 2019

  1. deps: update V8 to 7.6.303.28

    @targos
    targos committed Aug 1, 2019
    Copy the full SHA
    b0d4dab View commit details
    Browse the repository at this point in the history

  2. build: reset embedder string to "-node.0"

    @targos
    targos committed Aug 1, 2019
    Copy the full SHA
    e472188 View commit details
    Browse the repository at this point in the history

  3. src: update NODE_MODULE_VERSION to 77 

    Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 7.6.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    @targos
    targos committed Aug 1, 2019
    Copy the full SHA
    13a438a View commit details
    Browse the repository at this point in the history

  4. deps: V8: fix filename manipulation for Windows

    @refack @targos
    refack authored and targos committed Aug 1, 2019
    Copy the full SHA
    6c17853 View commit details
    Browse the repository at this point in the history

  5. deps: V8: un-cherry-pick bd019bd 

    Original commit message:

    [testrunner] delete ancient junit compatible format support

    Testrunner has ancient support for JUnit compatible XML output.

    This CL removes this old feature.

    R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
    CC=鈥媘achenbach@chromium.org

    Bug: v8:8728
    Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1430065
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Tamer Tas <tmrts@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59045}

Refs: v8/v8@bd019bd

PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @refack @targos
    refack authored and targos committed Aug 1, 2019
    Copy the full SHA
    e400da0 View commit details
    Browse the repository at this point in the history

  6. deps: V8: silence irrelevant warning 

    PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @targos
    targos committed Aug 1, 2019
    Copy the full SHA
    48714ab View commit details
    Browse the repository at this point in the history

  7. deps: V8: update postmortem metadata generation script 

    Update postmortem metadata constants for V8 7.6 in Node.js.
    @cjihrig @targos
    cjihrig authored and targos committed Aug 1, 2019
    Copy the full SHA
    73236db View commit details
    Browse the repository at this point in the history

  8. deps: V8: patch register-arm64.h 

    Fixes a compilation issue on some platforms

PR-URL: nodejs#27375
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @refack @targos
    refack authored and targos committed Aug 1, 2019
    Copy the full SHA
    86dba64 View commit details
    Browse the repository at this point in the history

  9. deps: V8: forward declaration of Rtl*FunctionTable 

    This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs#27375
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @refack @targos
    refack authored and targos committed Aug 1, 2019
    Copy the full SHA
    442b69a View commit details
    Browse the repository at this point in the history

  10. deps: V8: use ATOMIC_VAR_INIT instead of std::atomic_init 

    `std::atomic_init<size_t>` is not implemented in all platforms.

* pragma to ignore `-Wbraced-scalar-init`

PR-URL: nodejs#27375
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @refack @targos
    refack authored and targos committed Aug 1, 2019
    Copy the full SHA
    5dceb8a View commit details
    Browse the repository at this point in the history

  11. deps: V8: add workaround for MSVC optimizer bug 

    Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html
    @refack @targos
    refack authored and targos committed Aug 1, 2019
    Copy the full SHA
    e0ea924 View commit details
    Browse the repository at this point in the history

  12. deps: V8: fix BUILDING_V8_SHARED issues 

    PR-URL: nodejs#27375
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @refack @targos
    refack authored and targos committed Aug 1, 2019
    Copy the full SHA
    a7c0545 View commit details
    Browse the repository at this point in the history

  13. deps: V8: fix linking issue for MSVS

    @refack @targos
    refack authored and targos committed Aug 1, 2019
    Copy the full SHA
    8353c46 View commit details
    Browse the repository at this point in the history

  14. deps: V8: cherry-pick 3b8c624 

    Original commit message:

    GCC: explicitely instantiate JSObject::ApplyAttributesToDictionary for NumberDictionary

    elements.cc invokes ApplyAttributesToDictionary using NumberDictionary as its template
    parameter. But the declaration of the template method is in js-object.cc, so nobody
    can actually compile the version for number dictionary. This is fixed requesting
    explicit instantiation for NumberDictionary.

    This was breaking GCC build.

    Bug: chromium:819294
    Change-Id: I685ddc5b97e129d1a534dbdb04025c0932bc5ecd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649565
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Jos茅 Dapena Paz <jose.dapena@lge.com>
    Cr-Commit-Position: refs/heads/master@{#62097}

Refs: v8/v8@3b8c624
    @targos
    targos committed Aug 1, 2019
    Copy the full SHA
    e9f514a View commit details
    Browse the repository at this point in the history

  15. deps: cherry-pick 13a04aba from V8 upstream 

    Original commit message:
  fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references

  This change fixes missing symbol errors in the Windows 10 on ARM build
  of Node.js.

  When a whole class is marked for export, all of its members are marked
  as well. This can be a problem when inline members call undefined yet
  inline members of other classes: the exported function will contain a
  reference to the undefined inline function that should be satisfied at
  link time, but because the other function is inline no symbol will be
  produced that will satisfy that reference.

  Clang gets around this by masking inlined class members from export
  using /Fc:dllexportInlines-. This is why b0a2a567 worked.

  Node.js' Windows builds use MSVC and so do not have access to this
  flag. This results in unresolved symbols at link time.

  Bug: v8:9465
  Change-Id: Ief9c7ab6ba35d22f995939eb62a64d6f1992ed85
  Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696771
  Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
  Reviewed-by: Jakob Gruber <jgruber@chromium.org>
  Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#62660}

Refs: v8/v8@13a04ab
PR-URL: nodejs#28602
Reviewed-By: Jo茫o Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @jkunkee @targos
    jkunkee authored and targos committed Aug 1, 2019
    Copy the full SHA
    0ee162b View commit details
    Browse the repository at this point in the history

  16. deps: V8: cherry-pick d2ccc59 

    Original commit message:

    [snapshot] print reference stack for JSFunctions in the isolate snapshot

    This helps debugging incorrect usage of the SnapshotCreator API in
    debug mode.

    Change-Id: Ibd9db76a5f460cdf7ea6d14e865592ebaf69aeef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648240
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62095}

Refs: v8/v8@d2ccc59
    @targos
    targos committed Aug 1, 2019
    Copy the full SHA
    28a5a5f View commit details
    Browse the repository at this point in the history

  17. deps: V8: cherry-pick b33af60 

    Original commit message:

    [api] Get ScriptOrModule from CompileFunctionInContext

    Adds a new out param which allows accessing the ScriptOrModule
    of a function, which allows an embedder such as Node.js to use
    the function's i::Script lifetime.

    Refs: nodejs/node-v8#111
    Change-Id: I34346d94d76e8f9b8377c97d948673f4b95eb9d5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1699698
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62830}

Refs: v8/v8@b33af60
    @targos
    targos committed Aug 1, 2019
    Copy the full SHA
    ffcb6b7 View commit details
    Browse the repository at this point in the history

  18. tools: sync gypfiles with V8 7.6 

    Co-authored-by: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com>
    @targos @refack @ryzokuken
    3 people committed Aug 1, 2019
    Copy the full SHA
    75d6192 View commit details
    Browse the repository at this point in the history

  19. src: use non-deprecated overload of V8::SetFlagsFromString

    @targos
    targos committed Aug 1, 2019
    Copy the full SHA
    c839fb9 View commit details
    Browse the repository at this point in the history

  20. test: update postmortem metadata test for V8 7.6 

    The following metadata has changed:

- v8dbg_class_FixedTypedArrayBase__base_pointer__Object
  - Field moved from FixedTypedArrayBase to JSTypedArray.
  - Postmortem tools should use v8dbg_class_JSTypedArray__base_pointer__Object.
  - Refs: v8/v8@70bd7cf

- v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t
  - Field moved from FixedTypedArrayBase to JSTypedArray.
  - Add new constant: v8dbg_class_JSTypedArray__external_pointer__uintptr_t
  - Refs: v8/v8@70bd7cf

- v8dbg_class_Map__instance_descriptors_offset
  - Underlying constant was renamed to kInstanceDescriptorsOffset.
  - Postmortem tools should not need to update anything for this constant.
  - Refs: v8/v8@15a7e04
    @cjihrig @targos
    cjihrig authored and targos committed Aug 1, 2019
    Copy the full SHA
    efa9505 View commit details
    Browse the repository at this point in the history