v12.5.0 proposal

.eslintrc.js

@@ -114,6 +114,7 @@ module.exports = {
       tabWidth: 2,
     }],
     'new-parens': 'error',
+    'no-async-promise-executor': 'error',
     'no-class-assign': 'error',
     'no-confusing-arrow': 'error',
     'no-const-assign': 'error',
@@ -147,7 +148,7 @@ module.exports = {
     'no-octal': 'error',
     'no-path-concat': 'error',
     'no-proto': 'error',
-    'no-redeclare': 'error',
+    'no-redeclare': ['error', { 'builtinGlobals': false }],
     'no-restricted-modules': ['error', 'sys'],
     /* eslint-disable max-len */
     'no-restricted-properties': [
@@ -246,6 +247,7 @@ module.exports = {
     'no-return-await': 'error',
     'no-self-assign': 'error',
     'no-self-compare': 'error',
+    'no-shadow-restricted-names': 'error',
     'no-tabs': 'error',
     'no-template-curly-in-string': 'error',
     'no-this-before-super': 'error',

.gitignore

@@ -1,9 +1,13 @@
-# Whitelist dotfiles
+# Please take extra care not to add rules that will make tracked files ignored.
+# To test that, run `git ls-files -i --exclude-standard`.
+# To check why a specific file is ignored, run `git check-ignore -v <filepath>`.
+
+# === Rule for dotfiles ===
+# Ignore all dotfiles.
 .*
+# Exclude specific dotfiles that we want to track.
 !deps/**/.*
 !test/fixtures/**/.*
-!tools/node_modules/**/.*
-!tools/doc/node_modules/**/.*
 !.clang-format
 !.editorconfig
 !.eslintignore
@@ -19,109 +23,110 @@
 !.eslintrc.yaml
 !.cpplint
 
-core
-vgcore.*
-v8*.log
-perf.data
-perf.data.old
-tags
-*.pyc
-doc/api.xml
-tmp/
-test/tmp*/
-iojs
-iojs_g
-node
-node_g
-*.swp
-icu_config.gypi
-node_trace.*.log
-coverage/
-!**/node_modules/**/coverage
-
+# === Rules for root dir ===
+/core
+/vgcore.*
+/v8*.log
+/perf.data
+/perf.data.old
+/tags
+/doc/api.xml
+/node
+/node_g
+/*.exe
+/*.swp
 /out
+/*.txt
+
+# === Rules for artifacts of `./configure` ===
+/icu_config.gypi
+/config.gypi
+/config.status
+/config_fips.gypi
 
-# various stuff that VC++ produces/uses and is not in /out
+# === Rules for MSVS artifacts ===
 /Debug
 /Release
-!doc/blog/**
 *.sln
-!nodemsi.sln
 *.suo
-*.vcxproj
-!custom_actions.vcxproj
-*.vcxproj.user
-*.vcxproj.filters
+*.vcxproj*
 UpgradeLog*.XML
 _UpgradeReport_Files/
 *.sdf
 *.opensdf
-*.VC.db
-*.VC.opendb
-/*.exe
+*.VC.*
+*.wixobj
+/tools/msvs/genfiles/
+/npm.wxs
+# Exclude MSVS files used for .msi file generation
+!tools/msvs/msi/custom_actions.vcxproj
+!tools/msvs/msi/nodemsi.sln
 
-/config.mk
-/config.gypi
-/config.status
-/config_fips.gypi
+# === Rules for GYP artifacts ===
 *-nodegyp*
-/gyp-mac-tool
-/npm.wxs
-/tools/msvs/npm.wixobj
-/tools/msvs/genfiles/
+/gyp-*-tool
 /test/addons/??_*/
-email.md
-deps/v8-*
-deps/icu
-deps/icu*.zip
-deps/icu*.tgz
-deps/icu-tmp
-./node_modules
-android-toolchain/
+/*.mk
 
+# === Rules for other build artifacts ===
+/email.md
+/deps/v8-*
+/deps/icu
+/deps/icu*.zip
+/deps/icu*.tgz
+/deps/icu-tmp
+./node_modules
+/android-toolchain/
 # generated by gyp on Windows
-deps/openssl/openssl.props
-deps/openssl/openssl.targets
-deps/openssl/openssl.xml
-
+/deps/openssl/openssl.props
+/deps/openssl/openssl.targets
+/deps/openssl/openssl.xml
 # generated by gyp on android
 /*.target.mk
 /*.host.mk
-deps/openssl/openssl.target.mk
-deps/zlib/zlib.target.mk
-
-!deps/npm/node_modules
-# not needed and causes issues for distro packagers
-deps/npm/node_modules/.bin/
+/deps/openssl/openssl.target.mk
+/deps/zlib/zlib.target.mk
 
-# build/release artifacts
+# === Rules for release artifacts ===
 /*.tar.*
 /*.pkg
 /SHASUMS*.txt*
 
-# api docs artifacts
-tools/doc/node_modules
-
-# clang-format artifacts
-tools/clang-format/node_modules
+# === Rules for `node_modules` ===
+!**/node_modules/**
+/node_modules
+/tools/doc/node_modules
+/tools/clang-format/node_modules
 
-# test artifacts
-icu_config.gypi
-*.tap
+# === Rules for test artifacts ===
+/*.tap
 /*.xml
+/node_trace.*.log
+# coverage related
+/gcovr
+/build
 
-# Xcode workspaces and project folders
+# === Rules for XCode artifacts ===
 *.xcodeproj
 *.xcworkspace
+*.pbxproj
 
-# libuv book and GitHub template
-deps/uv/.github/
-deps/uv/docs/code/
-deps/uv/docs/src/guide/
-
-# do not override V8's .gitignore
+# === Rules for files in `/deps` ===
+# Exclude all files in the vendored `npm`.
+!/deps/npm/node_modules
+# These are not needed and causes issues for distro packagers.
+/deps/npm/node_modules/.bin/
+# Respect V8's .gitignore
 !deps/v8/**
-# ignore VS compiler output unhandled by V8's .gitignore
-deps/v8/third_party/eu-strip/
+# Ignore the libuv book and GitHub templates
+/deps/uv/.github/
+/deps/uv/docs/code/
+/deps/uv/docs/src/guide/
+# Ignore dependencies fetched by deps/v8/tools/node/fetch_deps.py
+/deps/.cipd
 
+# === Global Rules ===
+# Keep last to avoid being excluded
+*.pyc
+__pycache__
 .DS_Store

BUILDING.md

@@ -103,8 +103,8 @@ platforms. This is true regardless of entries in the table below.
 | GNU/Linux        | arm64            | kernel >= 4.5, glibc >= 2.17    | Tier 1       | e.g. Ubuntu 16.04, Debian 9, EL 7 <sup>[3](#fn3)</sup> |
 | GNU/Linux        | armv7            | kernel >= 4.14, glibc >= 2.24   | Tier 1       | e.g. Ubuntu 18.04, Debian 9       |
 | GNU/Linux        | armv6            | kernel >= 4.14, glibc >= 2.24   | Experimental | Downgraded as of Node.js 12       |
-| GNU/Linux        | ppc64le >=power8 | kernel >= 3.13.0, glibc >= 2.19 | Tier 2       | e.g. Ubuntu 16.04, EL 7           |
-| GNU/Linux        | s390x            | kernel >= 3.10.0, glibc >= 2.17 | Tier 2       | e.g. EL 7                         |
+| GNU/Linux        | ppc64le >=power8 | kernel >= 3.10.0, glibc >= 2.17 | Tier 2       | e.g. Ubuntu 16.04 <sup>[1](#fn1)</sup>, EL 7  <sup>[2](#fn2)</sup> |
+| GNU/Linux        | s390x            | kernel >= 3.10.0, glibc >= 2.17 | Tier 2       | e.g. EL 7 <sup>[2](#fn2)</sup>    |
 | Windows          | x64, x86 (WoW64) | >= Windows 7/2008 R2/2012 R2    | Tier 1       | <sup>[4](#fn4),[5](#fn5)</sup>    |
 | Windows          | x86 (native)     | >= Windows 7/2008 R2/2012 R2    | Tier 1 (running) / Experimental (compiling) <sup>[6](#fn6)</sup> | |
 | Windows          | arm64            | >= Windows 10                   | Experimental |                                   |
@@ -165,7 +165,7 @@ Binaries at <https://nodejs.org/download/release/> are produced on:
 | darwin-x64 (and .pkg) | macOS 10.11, Xcode Command Line Tools 8 with -mmacosx-version-min=10.10  |
 | linux-arm64           | CentOS 7 with devtoolset-6 / GCC 6                                       |
 | linux-armv7l          | Cross-compiled on Ubuntu 16.04 x64 with [custom GCC toolchain](https://github.com/rvagg/rpi-newer-crosstools)   |
-| linux-ppc64le         | Ubuntu 14.04 with GCC 6                                                  |
+| linux-ppc64le         | CentOS 7 with devtoolset-6 / GCC 6 <sup>[7](#fn7)</sup>                  |
 | linux-s390x           | RHEL 7 with devtoolset-6 / GCC 6 <sup>[7](#fn7)</sup>                    |
 | linux-x64             | CentOS 7 with devtoolset-6 / GCC 6 <sup>[7](#fn7)</sup>                  |
 | sunos-x64             | SmartOS 18 with GCC 7                                                    |

CHANGELOG.md

@@ -3,7 +3,7 @@
 Select a Node.js version below to view the changelog history:
 
 * [Node.js 12](doc/changelogs/CHANGELOG_V12.md) - **Current**
-* [Node.js 11](doc/changelogs/CHANGELOG_V11.md) - Current
+* [Node.js 11](doc/changelogs/CHANGELOG_V11.md) - End-of-Life
 * [Node.js 10](doc/changelogs/CHANGELOG_V10.md) — **Long Term Support**
 * [Node.js 9](doc/changelogs/CHANGELOG_V9.md) — End-of-Life
 * [Node.js 8](doc/changelogs/CHANGELOG_V8.md) — Long Term Support
@@ -23,38 +23,20 @@ release.
 <table>
 <tr>
   <th title="Current"><a href="doc/changelogs/CHANGELOG_V12.md">12</a><sup>Current</sup></th>
-  <th title="Current"><a href="doc/changelogs/CHANGELOG_V11.md">11</a><sup>Current</sup></th>
   <th title="LTS Until 2021-04"><a href="doc/changelogs/CHANGELOG_V10.md">10</a><sup>LTS</sup></th>
   <th title="LTS Until 2019-12"><a href="doc/changelogs/CHANGELOG_V8.md">8</a><sup>LTS</sup></th>
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V12.md#12.4.0">12.4.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V12.md#12.5.0">12.5.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V12.md#12.4.0">12.4.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.3.1">12.3.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.3.0">12.3.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.2.0">12.2.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.1.0">12.1.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.0.0">12.0.0</a><br/>
     </td>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V11.md#11.14.0">11.14.0</a></b><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.13.0">11.13.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.12.0">11.12.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.11.0">11.11.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.10.1">11.10.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.10.0">11.10.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.9.0">11.9.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.8.0">11.8.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.7.0">11.7.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.6.0">11.6.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.5.0">11.5.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.4.0">11.4.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.3.0">11.3.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.2.0">11.2.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.1.0">11.1.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V11.md#11.0.0">11.0.0</a><br/>
-    </td>
-    <td valign="top">
 <b><a href="doc/changelogs/CHANGELOG_V10.md#10.15.3">10.15.3</a></b><br/>
 <a href="doc/changelogs/CHANGELOG_V10.md#10.15.2">10.15.2</a><br/>
 <a href="doc/changelogs/CHANGELOG_V10.md#10.15.1">10.15.1</a><br/>

Makefile

@@ -586,8 +586,12 @@ test-hash-seed: all
 
 .PHONY: test-doc
 test-doc: doc-only ## Builds, lints, and verifies the docs.
-	$(MAKE) lint
-	$(PYTHON) tools/test.py $(PARALLEL_ARGS) $(CI_DOC)
+	@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
+		echo "Skipping test-doc (no crypto)"; \
+	else \
+		$(MAKE) lint; \
+		$(PYTHON) tools/test.py $(PARALLEL_ARGS) $(CI_DOC); \
+	fi
 
 test-known-issues: all
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) known_issues
@@ -1159,7 +1163,7 @@ lint-md-clean:
 lint-md-build:
 	$(warning "Deprecated no-op target 'lint-md-build'")
 
-LINT_MD_DOC_FILES = $(shell ls doc/*.md doc/**/*.md)
+LINT_MD_DOC_FILES = $(shell find doc -type f -name '*.md')
 run-lint-doc-md = tools/lint-md.js -q -f $(LINT_MD_DOC_FILES)
 # Lint all changed markdown files under doc/
 tools/.docmdlintstamp: $(LINT_MD_DOC_FILES)

README.md

@@ -12,7 +12,7 @@ Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine. For
 more information on using Node.js, see the [Node.js Website][].
 
 The Node.js project uses an [open governance model](./GOVERNANCE.md). The
-[Node.js Foundation][] provides support for the project.
+[OpenJS Foundation][] provides support for the project.
 
 **This project is bound by a [Code of Conduct][].**
 
@@ -580,6 +580,7 @@ Other keys used to sign some previous releases:
 
 [Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
 [Contributing to the project]: CONTRIBUTING.md
-[Node.js Foundation]: https://nodejs.org/en/foundation/
+[Node.js Website]: https://nodejs.org/
+[OpenJS Foundation]: http://openjs.foundation/
 [Working Groups]: https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md
 [Strategic Initiatives]: https://github.com/nodejs/TSC/blob/master/Strategic-Initiatives.md

benchmark/tls/secure-pair.js

@@ -6,21 +6,19 @@ const bench = common.createBenchmark(main, {
   size: [2, 1024, 1024 * 1024]
 });
 
-const fs = require('fs');
+const fixtures = require('../../test/common/fixtures');
 const tls = require('tls');
 const net = require('net');
-const path = require('path');
 
-const cert_dir = path.resolve(__dirname, '../../test/fixtures');
 const REDIRECT_PORT = 28347;
 
 function main({ dur, size, securing }) {
   const chunk = Buffer.alloc(size, 'b');
 
   const options = {
-    key: fs.readFileSync(`${cert_dir}/test_key.pem`),
-    cert: fs.readFileSync(`${cert_dir}/test_cert.pem`),
-    ca: [ fs.readFileSync(`${cert_dir}/test_ca.pem`) ],
+    key: fixtures.readKey('rsa_private.pem'),
+    cert: fixtures.readKey('rsa_cert.crt'),
+    ca: fixtures.readKey('rsa_ca.crt'),
     ciphers: 'AES256-GCM-SHA384',
     isServer: true,
     requestCert: true,

benchmark/tls/throughput.js

@@ -6,9 +6,7 @@ const bench = common.createBenchmark(main, {
   size: [2, 1024, 1024 * 1024]
 });
 
-const path = require('path');
-const fs = require('fs');
-const cert_dir = path.resolve(__dirname, '../../test/fixtures');
+const fixtures = require('../../test/common/fixtures');
 var options;
 const tls = require('tls');
 
@@ -32,9 +30,9 @@ function main({ dur, type, size }) {
   }
 
   options = {
-    key: fs.readFileSync(`${cert_dir}/test_key.pem`),
-    cert: fs.readFileSync(`${cert_dir}/test_cert.pem`),
-    ca: [ fs.readFileSync(`${cert_dir}/test_ca.pem`) ],
+    key: fixtures.readKey('rsa_private.pem'),
+    cert: fixtures.readKey('rsa_cert.crt'),
+    ca: fixtures.readKey('rsa_ca.crt'),
     ciphers: 'AES256-GCM-SHA384'
   };