Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make multipleResolves docs less opinionated #28314

Merged
merged 1 commit into from Jun 22, 2019
Merged

doc: make multipleResolves docs less opinionated #28314

merged 1 commit into from Jun 22, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 20, 2019 •
edited

Currently, the 'multipleResolves' event does not necessarily indicate an error. This commit makes the documentation less opinionated, and includes potential caveats.

Refs: #24321

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Jun 20, 2019
@devsnek devsnek added the promises Issues and PRs related to ECMAScript promises. label Jun 20, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 21, 2019

Green Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3698/

@cjihrig
doc: make multipleResolves docs less opinionated
05359dd 
The 'multipleResolves' event does not necessarily indicate an
error. This commit makes the documentation less opinionated, and
includes potential caveats.

PR-URL: nodejs#28314
Refs: nodejs#24321
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig merged commit 05359dd into nodejs:master Jun 22, 2019
@cjihrig cjihrig deleted the multi-res branch June 22, 2019 16:05
targos pushed a commit that referenced this pull request Jul 2, 2019
@cjihrig @targos
doc: make multipleResolves docs less opinionated
632fc1f 
The 'multipleResolves' event does not necessarily indicate an
error. This commit makes the documentation less opinionated, and
includes potential caveats.

PR-URL: #28314
Refs: #24321
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. promises Issues and PRs related to ECMAScript promises.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cjihrig @jasnell @Trott @addaleax @targos @devsnek @nodejs-github-bot