test: reset validity dates of expired certs #28473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-github
added
the
fast-track
|
👍 to fast track |
sam-github
commented
Jun 28, 2019
sam-github
force-pushed
the
update-cert-validity-dates
branch
from
14fef0a
to
31f4b90
Compare
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Jun 28, 2019
Trott
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
Jun 28, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in 334bac7 |
sam-github
added a commit
that referenced
this pull request
Jun 28, 2019
PR-URL: #28473 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Yeah, not happy to land this with AIX failures, but given the cert expiry is failing every PR on every platform, and the AIX troubles we're having predate this, and are only failing AIX, it just doesn't seem right to make everyone suffer while we try to figure out #28469 |
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28473 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28473 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be fast-tracked.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes