Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: refactor agent.destroy() #28596

Closed
wants to merge 3 commits into from
Closed

http: refactor agent.destroy() #28596

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ad2ff2
http: refactor agent.destroy()
starkwang Jul 8, 2019
3d0ec30
[squash] use const
starkwang Jul 9, 2019
73da794
[squash] use Object.values()
starkwang Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 9 additions & 10 deletions lib/_http_agent.js
View file
Open in desktop
Expand Up @@ -336,18 +336,17 @@ Agent.prototype.reuseSocket = function reuseSocket(socket, req) {
};

Agent.prototype.destroy = function destroy() {
const sets = [this.freeSockets, this.sockets];
for (var s = 0; s < sets.length; s++) {
var set = sets[s];
var keys = Object.keys(set);
for (var v = 0; v < keys.length; v++) {
var setName = set[keys[v]];
for (var n = 0; n < setName.length; n++) {
setName[n].destroy();
}
destroySockets(this.freeSockets);
destroySockets(this.sockets);
};

function destroySockets(sockets) {
for (const set of Object.values(sockets)) {
for (const socket of set) {
socket.destroy();
}
}
};
}

function handleSocketCreation(agent, request, informRequest) {
return function handleSocketCreation_Inner(err, socket) {
Expand Down