Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x backport] test: remove util.inherits() usage #28795

Closed
wants to merge 1 commit into from
Closed

[v10.x backport] test: remove util.inherits() usage #28795

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Jul 21, 2019

PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Anna Henningsen anna@addaleax.net

Backport of #25245

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@ZYSzys
test: remove util.inherits() usage
488c981 
PR-URL: nodejs#25245
Refs: nodejs#24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v10.x labels Jul 21, 2019
@lpinca
Copy link
Member

lpinca commented Jul 21, 2019 •
edited

I don't think this should be backported. #24755 was semver-major. The _super property is no longer available.

@lpinca
Copy link
Member

lpinca commented Jul 21, 2019

Oh nvm it seems the change only affects tests.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24631/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24640/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24651/

@Trott

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 25, 2019 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/24692/ ✔️

BethGriggs pushed a commit that referenced this pull request Jul 26, 2019
@ZYSzys @BethGriggs
test: remove util.inherits() usage
f332265 
Backport-PR-URL: #28795
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs
Copy link
Member

Landed on v10.x-staging

@BethGriggs BethGriggs closed this Jul 26, 2019
@ZYSzys ZYSzys deleted the backport-25245-to-v10.x branch July 26, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZYSzys @lpinca @nodejs-github-bot @Trott @BethGriggs