http: remove listeners from free sockets #29259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
http-free-listener
branch
2 times, most recently
from
81282c4
to
94a1aa9
Compare
ronag
force-pushed
the
http-free-listener
branch
from
94a1aa9
to
da31643
Compare
addaleax
approved these changes
Aug 25, 2019
ronag
force-pushed
the
http-free-listener
branch
from
da31643
to
f9ba882
Compare
|
Rebased |
addaleax
added
the
author ready
mcollina
reviewed
Sep 8, 2019
Trott
removed
the
author ready
|
rebased |
ronag
force-pushed
the
http-free-listener
branch
2 times, most recently
from
05988bf
to
f9486be
Compare
Reduced memory usage by ensuring free sockets don't have extra listeners while in the pool.
ronag
force-pushed
the
http-free-listener
branch
from
e67d546
to
5c6b99f
Compare
mcollina
added
baking-for-lts
|
@Trott: Can this land? |
jasnell
approved these changes
Dec 30, 2019
Trott
approved these changes
Dec 30, 2019
addaleax
added
the
author ready
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Jan 1, 2020
This comment has been minimized.
This comment has been minimized.
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Reduced memory usage by ensuring free sockets don't have extra listeners while in the pool. PR-URL: #29259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 7c70dbb 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Reduced memory usage by ensuring free sockets don't have extra listeners while in the pool. PR-URL: #29259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Reduced memory usage by ensuring free sockets don't have extra listeners while in the pool. PR-URL: #29259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Reduced memory usage by ensuring free sockets don't have extra listeners while in the pool. PR-URL: #29259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Reduced memory usage by ensuring free sockets don't have extra listeners while in the pool. PR-URL: #29259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
removed
the
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation on #29245 made in a separate PR to make #29245 easier to fast track if desired.
Some more listener cleanup when sockets are detached from the request object and moved into the socket pool.
I'm not sure, but this looks like it might actually be a bug?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes