Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches to help build node as a shared library for Android #29388

Closed
wants to merge 2 commits into from
Closed

Patches to help build node as a shared library for Android #29388

wants to merge 2 commits into from

Commits on Oct 22, 2019

  1. build: fix library version and compile flags on Android 

    Compiling a library with -fPIE won't do, and on Android libraries
are not versioned.
    @gcampax
    gcampax committed Oct 22, 2019
    Copy the full SHA
    77c2273 View commit details
    Browse the repository at this point in the history

  2. build: on Android, use android log library to print stack traces 

    And other errors like lost promises
    @gcampax
    gcampax committed Oct 22, 2019
    Copy the full SHA
    f18b9da View commit details
    Browse the repository at this point in the history