Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.10.0 proposal #29429

Merged
merged 84 commits into from Sep 4, 2019
Merged

v12.10.0 proposal #29429

merged 84 commits into from Sep 4, 2019

Commits on Sep 3, 2019

  1. fs: add *timeNs properties to BigInt Stats objects

    - Extend the aliased buffer for stats objects to contain
      the entire time spec (seconds and nanoseconds) for the time
      values instead of calculating the milliseconds in C++ and
      lose precision there.
    - Calculate the nanosecond-precision time values in JS and expose
      them in BigInt Stats objects as `*timeNs`. The
      millisecond-precision values are now calculated from the
      nanosecond-precision values.
    
    PR-URL: #21387
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    joyeecheung authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    365e062 View commit details
    Browse the repository at this point in the history
  2. fs: document the Date conversion in Stats objects

    Document why the dates are calculated with the timestamp
    in Numbers + 0.5.
    
    The comment was previously lost in a revert.
    
    Refs: ae6c704
    
    PR-URL: #28224
    Refs: ae6c704
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joyeecheung authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    e6353bd View commit details
    Browse the repository at this point in the history
  3. fs: fix (temporary) for esm package

    Fix to unblock CITGM. See,
    standard-things/esm#821.
    
    PR-URL: #28957
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    ronag authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    6ff803d View commit details
    Browse the repository at this point in the history
  4. esm: support loading data URLs

    Co-Authored-By: Jan Olaf Krems <jan.krems@gmail.com>
    
    PR-URL: #28614
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    bmeck authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    a7c8322 View commit details
    Browse the repository at this point in the history
  5. bootstrap: run preload prior to frozen-intrinsics

    This is used to allow people to run polyfills.
    
    Co-Authored-By: Anna Henningsen <github@addaleax.net>
    
    PR-URL: #28940
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bmeck authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    293c9f0 View commit details
    Browse the repository at this point in the history
  6. stream: do not emit drain if stream ended

    PR-URL: #29086
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ronag authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    b36a6e9 View commit details
    Browse the repository at this point in the history
  7. gyp: futurize imput.py to prepare for Python 3

    PR-URL: #29140
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cclauss authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    10bae2e View commit details
    Browse the repository at this point in the history
  8. src: add large page support for macOS

    Proposal to bring the support for this platform.
    We assume the pse36 cpu flag is present for 2MB
    large page support present in recent years
    in mac line (not to be backported to 10.x anyway).
    Recommended better for mac production servers rather
    than casual mac books.
    
    PR-URL: #28977
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    devnexen authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    4d4583e View commit details
    Browse the repository at this point in the history
  9. deps: update npm to 6.10.3

    BUGFIXES
    
    * [`27cccfbda`](npm/cli@27cccfb)
      [#223](npm/cli#223) vulns → vulnerabilities in
      npm audit output ([@sapegin](https://github.com/sapegin))
    * [`d5e865eb7`](npm/cli@d5e865e)
      [#222](npm/cli#222)
      [#226](npm/cli#226) install, doctor: don't crash
      if registry unset ([@dmitrydvorkin](https://github.com/dmitrydvorkin),
      [@isaacs](https://github.com/isaacs))
    * [`5b3890226`](npm/cli@5b38902)
      [#227](npm/cli#227)
      [npm.community#9167](https://npm.community/t/npm-err-cb-never-called-permission-denied/9167/5)
      Handle unhandledRejections, tell user what to do when encountering an
      `EACCES` error in the cache.  ([@isaacs](https://github.com/isaacs))
    
    DEPENDENCIES
    
    * [`77516df6e`](npm/cli@77516df)
      `licensee@7.0.3` ([@isaacs](https://github.com/isaacs))
    * [`ceb993590`](npm/cli@ceb9935)
      `query-string@6.8.2` ([@isaacs](https://github.com/isaacs))
    * [`4050b9189`](npm/cli@4050b91)
      `hosted-git-info@2.8.2`
        * [#46](npm/hosted-git-info#46)
          [#43](npm/hosted-git-info#43)
          [#47](npm/hosted-git-info#47)
          [#44](npm/hosted-git-info#44) Add support for
          GitLab subgroups ([@mterrel](https://github.com/mterrel),
          [@isaacs](https://github.com/isaacs),
          [@ybiquitous](https://github.com/ybiquitous))
        * [`3b1d629`](npm/hosted-git-info@3b1d629)
          [#48](npm/hosted-git-info#48) fix http
          protocol using sshurl by default
          ([@fengmk2](https://github.com/fengmk2))
        * [`5d4a8d7`](npm/hosted-git-info@5d4a8d7)
          ignore noCommittish on tarball url generation
          ([@isaacs](https://github.com/isaacs))
        * [`1692435`](npm/hosted-git-info@1692435)
          use gist tarball url that works for anonymous gists
          ([@isaacs](https://github.com/isaacs))
        * [`d5cf830`](npm/hosted-git-info@d5cf830)
          Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
        * [`e518222`](npm/hosted-git-info@e518222)
          Use LRU cache to prevent unbounded memory consumption
          ([@iarna](https://github.com/iarna))
    
    PR-URL: #29023
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    isaacs authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    219c195 View commit details
    Browse the repository at this point in the history
  10. crypto: simplify DSA validation in FIPS mode

    PR-URL: #29195
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    tniessen authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    e0537e6 View commit details
    Browse the repository at this point in the history
  11. build: add Python 3 tests to Travis CI

    These tests are run in allow_failures mode on Python 3.7.1 and they
    bypasses the Python version checks in ./configure by directly running
    ./configure.py.
    
    PR-URL: #29196
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    cclauss authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    aeafb91 View commit details
    Browse the repository at this point in the history
  12. tools: fix Python 3 issues in gyp/generator/make.py

    PR-URL: #29214
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cclauss authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    eceebd3 View commit details
    Browse the repository at this point in the history
  13. tools: fix Python 3 issues in tools/icu/icutrim.py

    PR-URL: #29213
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cclauss authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    a123a20 View commit details
    Browse the repository at this point in the history
  14. buffer: improve equals() performance

    PR-URL: #29199
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mscdex authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    35bca31 View commit details
    Browse the repository at this point in the history
  15. tools: fix mixup with bytes.decode() and str.encode()

    We want to read a bytes file and decode the contents as utf-8 so we can
    compare against a utf-8 pattern.
    
    PR-URL: #29208
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    cclauss authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    925141f View commit details
    Browse the repository at this point in the history
  16. buffer: correct concat() error message

    PR-URL: #29198
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mscdex authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    0544075 View commit details
    Browse the repository at this point in the history
  17. build: move tooltest to before jstest target

    This commit moves the tooltest target to come before the jstest target
    to make the console output consistent with it was before I introduced
    the tooltest target.
    
    Currently the output looks like this which is might give the impression
    that only one test was run:
    /Applications/Xcode.app/Contents/Developer/usr/bin/make -s tooltest
    .
    ----------------------------------------------------------------------
    Ran 1 test in 0.000s
    
    Compared to the usual:
    [03:58|% 100|+ 2739|-   0]: Done
    
    PR-URL: #29220
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danbev authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    feafc01 View commit details
    Browse the repository at this point in the history
  18. gyp: remove semicolons (Python != JavaScript)

    PR-URL: #29228
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    MattIPv4 authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    12cbb3f View commit details
    Browse the repository at this point in the history
  19. fs: allow passing true to emitClose option

    Allow passing true for emitClose option for fs
    streams.
    
    Fixes: #29177
    
    PR-URL: #29212
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    gntem authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    8f47ff1 View commit details
    Browse the repository at this point in the history
  20. test: add emitClose: true tests for fs streams

    PR-URL: #29212
    Fixes: #29177
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    1f88ca3 View commit details
    Browse the repository at this point in the history
  21. doc: add emitClose option for fs streams

    PR-URL: #29212
    Fixes: #29177
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    65de900 View commit details
    Browse the repository at this point in the history
  22. module: avoid passing unnecessary loop reference

    It's a sync request, which doesn't require the loop parameter to be set.
    
    PR-URL: #29275
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    saghul authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    eb2d96f View commit details
    Browse the repository at this point in the history
  23. stream: async iterator destroy compat

    async iterator should not depend on internal API for better compat
    with streamlike objects.
    
    PR-URL: #29176
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    e939a87 View commit details
    Browse the repository at this point in the history
  24. doc: indicate that Http2ServerResponse extends Stream

    Also removes the redundant statement explained by "extends Stream".
    
    PR-URL: #29254
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    trivikr authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    b2f169e View commit details
    Browse the repository at this point in the history
  25. doc: indicate that Http2ServerRequest extends Readable

    PR-URL: #29253
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    trivikr authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    1d649e3 View commit details
    Browse the repository at this point in the history
  26. doc: add missing extends Http2Session

    Adds missing extends Http2Session for ClientHttp2Session
    and ServerHttp2Session.
    
    PR-URL: #29252
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    trivikr authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    6a4f156 View commit details
    Browse the repository at this point in the history
  27. fs: add recursive option to rmdir()

    This commit adds a recursive option to fs.rmdir(),
    fs.rmdirSync(), and fs.promises.rmdir(). The implementation
    is a port of the npm module rimraf.
    
    PR-URL: #29168
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    cjihrig authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    ed2293e View commit details
    Browse the repository at this point in the history
  28. doc: fix nits in esm.md

    * ```mjs -> ```js as our linting of doc code fragments
      does not recognize this tag, IIRC.
    
    * Add semicolons to a code fragment.
    
    * Fix ASCII sorting in bottom references.
    
    PR-URL: #29242
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    vsemozhetbyt authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    2fafd63 View commit details
    Browse the repository at this point in the history
  29. net: allow reading data into a static buffer

    Co-Authored-By: Anna Henningsen <anna@addaleax.net>
    
    PR-URL: #25436
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    mscdex authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    dfc0ef5 View commit details
    Browse the repository at this point in the history
  30. doc,tls: add extends for derived classes

    PR-URL: #29257
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    trivikr authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    ba29be6 View commit details
    Browse the repository at this point in the history
  31. doc: add https.Server extends tls.Server

    PR-URL: #29256
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    trivikr authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    8599052 View commit details
    Browse the repository at this point in the history
  32. doc,http: add extends for derived classes

    Also removed redundant statments as extends is self-explanatory.
    
    PR-URL: #29255
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    trivikr authored and BridgeAR committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    8a93b63 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. lib: consolidate lazyErrmapGet()

    There are currently two implementations of this function.
    This commit removes the redundancy, and removes "lazy" from
    the name.
    
    PR-URL: #29285
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cjihrig authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    6e585fb View commit details
    Browse the repository at this point in the history
  2. doc: add dco to github pr template

    Our project relies on the Developer Certificate of Origin as a passive
    alternative to a Contributor License Agreement. The PR template seems
    like a great place to surface the text to help new contributors be
    aware of the DCO and it's implications.
    
    PR-URL: #24023
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    MylesBorins authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    ef76c7d View commit details
    Browse the repository at this point in the history
  3. src: expose MaybeInitializeContext to allow existing contexts

    Splits the node.js specific tweak intialization of NewContext into a new
    helper MaybeInitializeContext so that embedders with existing contexts
    can still use them in a Node.js Environment now that primordials are
    initialized and required so early.
    
    Update MaybeInitializeContext to return MaybeLocal,
    
    PR-URL: #28544
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MarshallOfSound authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    db6e4ce View commit details
    Browse the repository at this point in the history
  4. doc,errors: add extends to derived classes

    PR-URL: #29303
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    trivikr authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    a2c7047 View commit details
    Browse the repository at this point in the history
  5. doc,fs: add extends for derived classes

    PR-URL: #29304
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    trivikr authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    395245f View commit details
    Browse the repository at this point in the history
  6. test: use print() function in both Python 2 and 3

    PR-URL: #29298
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cclauss authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    9a15002 View commit details
    Browse the repository at this point in the history
  7. tools: fix Python 3 issues in inspector_protocol

    PR-URL: #29296
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cclauss authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    783c8ee View commit details
    Browse the repository at this point in the history
  8. build: test Python 3.6 and 3.7 on Travis CI

    PR-URL: #29291
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    cclauss authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    def5c3e View commit details
    Browse the repository at this point in the history
  9. build: make --without-snapshot imply --without-node-snapshot

    PR-URL: #29294
    Fixes: #29243
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    6a914ed View commit details
    Browse the repository at this point in the history
  10. events: improve once() performance

    PR-URL: #29307
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    mscdex authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    3bc16f9 View commit details
    Browse the repository at this point in the history
  11. errors: provide defaults for unmapped uv errors

    libuv does not map 100% of errors. When an unmapped error is
    encountered, the Map returns undefined, which is then
    unsuccessfully destructured, causing an exception. This commit
    adds a default value in the event of an unmapped error.
    
    PR-URL: #29288
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cjihrig authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    30b80e5 View commit details
    Browse the repository at this point in the history
  12. src: allow --interpreted-frames-native-stack in NODE_OPTIONS

    PR-URL: #27744
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mmarchini authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    8c6896e View commit details
    Browse the repository at this point in the history
  13. process: improve nextTick performance

    PR-URL: #25461
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    mscdex authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    f4f8827 View commit details
    Browse the repository at this point in the history
  14. test: fix flaky test-http-server-keepalive-req-gc

    Use `server` to keep the event loop open until the `ongc` listener runs.
    
    PR-URL: #29347
    Fixes: #29344
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Trott authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    bd1e8ea View commit details
    Browse the repository at this point in the history
  15. querystring: improve performance

    PR-URL: #29306
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    mscdex authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    0e1ccca View commit details
    Browse the repository at this point in the history
  16. tools: update babel-eslint to 10.0.3

    PR-URL: #29320
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    cjihrig authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    2df8475 View commit details
    Browse the repository at this point in the history
  17. tools: update ESLint to 6.2.2

    Update ESLint to 6.2.2
    
    PR-URL: #29320
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    cjihrig authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    3802da7 View commit details
    Browse the repository at this point in the history
  18. test: fix test-benchmark-net

    Fix test-benchmark-net to accommodate recent benchmark additions.
    
    PR-URL: #29359
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    83fb133 View commit details
    Browse the repository at this point in the history
  19. buffer: consolidate encoding parsing

    PR-URL: #29217
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    mscdex authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    c900762 View commit details
    Browse the repository at this point in the history
  20. buffer: correct indexOf() error message

    PR-URL: #29217
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    mscdex authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    71aaf59 View commit details
    Browse the repository at this point in the history
  21. util: do not throw when inspecting detached ArrayBuffer

    PR-URL: #29318
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    addaleax authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    5abbd51 View commit details
    Browse the repository at this point in the history
  22. build: integrate DragonFlyBSD into gyp build

    PR-URL: #29313
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    devnexen authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    d6b6a05 View commit details
    Browse the repository at this point in the history
  23. crypto: don't expose openssl internals

    PR-URL: #29325
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    codebytere authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    5c3e49d View commit details
    Browse the repository at this point in the history
  24. doc: heading levels should only increment by one

    These are flagged by Markdownlint MD001 rule.
    
    PR-URL: #29331
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nschonni authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    bb72217 View commit details
    Browse the repository at this point in the history
  25. doc: inconsistent indentation for list items

    Items at same level should have consistent indentation level.
    Addresses Markdownlint MD005 errors.
    
    PR-URL: #29330
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nschonni authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    43797d9 View commit details
    Browse the repository at this point in the history
  26. doc: add devnexen to collaborators

    PR-URL: #29370
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    devnexen authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    a94afed View commit details
    Browse the repository at this point in the history
  27. doc,crypto: add extends for derived classes

    PR-URL: #29302
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    trivikr authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    ae810cc View commit details
    Browse the repository at this point in the history
  28. deps: V8: cherry-pick 597f885

    Original commit message:
    
        [coverage] Deterministically sort collected shared function infos
    
        Prior to this CL, collected shared function infos with identical
        source ranges were sorted non-deterministically during coverage
        collection. This lead to non-deterministically incorrectly-reported
        coverage due to an optimization which depended on the sort order later
        on.
    
        With this CL, we now sort shared function infos by the source range
        *and* call count.
    
        Bug: v8:6000,v8:9212
        Change-Id: If8bf900727591e71dbd0df621e472a4303f3a353
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771776
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Commit-Queue: Jakob Gruber <jgruber@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#63411}
    
    Refs: v8/v8@597f885
    
    PR-URL: #29367
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    bcoe authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    28ffc9f View commit details
    Browse the repository at this point in the history
  29. test: remove Windows skipping of http keepalive request GC test

    Remove code to skip Windows in test-http-server-keepalive-req-gc. The
    test now works reliably on Windows (I think).
    
    PR-URL: #29354
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Trott authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    0ccf90b View commit details
    Browse the repository at this point in the history
  30. build: hard code doctool in test-doc target

    This commit removes the usage of the CI_DOC variable in the test-doc
    recipe and specifies the doctool argument to tools/test.py explicitly.
    
    The motivation for this is that the build is taking longer time and
    this is mostly due to tests being run twice as the CI_DOC
    variable will be empty in most cases (when not using --without-ssl).
    
    This change was introduced with/after Commit
    9039af8 ("build: skip test-ci doc
    targets if no crypto") and while I though it might make sense to change
    the setting of CI_DOC I not sure about the implications that might have
    to our CI environment. It currently looks like this:
    
    ifeq ($(node_use_openssl), false)
            CI_DOC := doctool
    else
            CI_DOC =
    endif
    
    Which is setting CI_DOC to doctool if there is no crypto support which
    not available. But perhaps this should be be the other way around,
    changing the order or updating condition to be true.
    
    PR-URL: #29375
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    danbev authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    0c4df35 View commit details
    Browse the repository at this point in the history
  31. stream: improve read() performance

    PR-URL: #29337
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    mscdex authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    2efd72f View commit details
    Browse the repository at this point in the history
  32. http: simplify timeout handling

    Avoids allocating and registering extra listeners for 'timeout'.
    
    PR-URL: #29200
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ronag authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    e5a9a85 View commit details
    Browse the repository at this point in the history
  33. doc: remove multiple consecutive blank lines

    These are rendered as single breaks.
    Addresses Markdownlint MD012 rule.
    
    PR-URL: #29352
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    6734782 View commit details
    Browse the repository at this point in the history
  34. doc: format http2 anchor link and reference

    Some links were flagged as empty links by Markdownlint MD042.
    The HttpServerResponse anchor link was also not defined.
    
    PR-URL: #29362
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    187d08b View commit details
    Browse the repository at this point in the history
  35. doc: add blanks around code fences

    Addresses Markdownlint MD031 rule warnings
    
    PR-URL: #29366
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    nschonni authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    3fc29b8 View commit details
    Browse the repository at this point in the history
  36. doc: add extends for derived classes

    PR-URL: #29290
    Reviewed-By: James M Snell <jasnell@gmail.com>
    trivikr authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    5a16449 View commit details
    Browse the repository at this point in the history
  37. build: add full Python 3 tests to Travis CI

    PR-URL: #29360
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    cclauss authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    256da1f View commit details
    Browse the repository at this point in the history
  38. doc: escape elements swallowed as HTML in markdown

    Addresses Markdownlint MD033 issues.
    Altering changlog should usually be avoided, but they don't render
    currently.
    
    PR-URL: #29374
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    4a7c4b7 View commit details
    Browse the repository at this point in the history
  39. src: inline SLICE_START_END() in node_buffer.cc

    This macro is only used once, so it doesn’t need to be a macro.
    
    PR-URL: #29357
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    addaleax authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    2666e00 View commit details
    Browse the repository at this point in the history
  40. src: turn GET_OFFSET() into an inline function

    There’s no need for this to be a macro.
    
    PR-URL: #29357
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    addaleax authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    b964bdd View commit details
    Browse the repository at this point in the history
  41. src: do not crash when accessing empty WeakRefs

    Making `.incRef()` and `.decRef()` fail silently leads to better error
    messages when trying to access the underlying value (as opposed to
    crashing inside these methods).
    
    Refs: #25461 (comment)
    
    PR-URL: #29289
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Gus Caplan <me@gus.host>
    addaleax authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    f8f3af0 View commit details
    Browse the repository at this point in the history
  42. console: use getStringWidth() for character width calculation

    This is more accurate for displayed full-width characters
    (e.g. CJK ones) and makes the calculations match the ones we
    use in the readline module.
    
    Fixes: #29299
    
    PR-URL: #29300
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    2489682 View commit details
    Browse the repository at this point in the history
  43. tools: fix mksnapshot blob wrong freeing operator

    PR-URL: #29384
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    devnexen authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    3f68be1 View commit details
    Browse the repository at this point in the history
  44. stream: don't deadlock on aborted stream

    Not all streams (e.g. http.ClientRequest) will always emit
    'close' after 'aborted'.
    
    PR-URL: #29376
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ronag authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    7809adf View commit details
    Browse the repository at this point in the history
  45. Revert "build: add full Python 3 tests to Travis CI"

    Reverted for breaking the Travis CI builds with the following error:
    
        $ cp ${PYTHON2_CACHE}/node out/Release/node
    
        cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
        or directory
    
        The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
        exited with 1 during .
    
    This reverts commit c602b0a.
    
    Refs: #29360
    
    PR-URL: #29406
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    bnoordhuis authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    449f1fd View commit details
    Browse the repository at this point in the history
  46. tools: use 'from io import StringIO' in ninja.py

    PR-URL: #29371
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cclauss authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    350975e View commit details
    Browse the repository at this point in the history
  47. lib: add ASCII fast path to getStringWidth()

    A lot of strings that are going to be passed to `getStringWidth()`
    are ASCII strings, for which the calculation is rather easy and
    calling into C++ can be skipped.
    
                                                           confidence improvement accuracy (*)    (**)   (***)
         misc/getstringwidth.js n=100000 type='ascii'            ***    328.99 %      ±21.73% ±29.25% ±38.77%
         misc/getstringwidth.js n=100000 type='emojiseq'                  2.94 %       ±7.66% ±10.19% ±13.26%
         misc/getstringwidth.js n=100000 type='fullwidth'                 4.70 %       ±5.64%  ±7.50%  ±9.76%
    
    PR-URL: #29301
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    87b8f02 View commit details
    Browse the repository at this point in the history
  48. build,win: find Python in paths with spaces

    When looking for Python in the registry, as specified in PEP514,
    this was not able to handle installations in a path with spaces,
    like Program Files. This ensures the whole path is used, fixing the
    issue.
    
    PR-URL: #29236
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joaocgreis authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    dce5649 View commit details
    Browse the repository at this point in the history
  49. build,win: accept Python 3 if 2 is not available

    If there is no Python 2 available, use Python 3. This allows to test
    running configure with Python 3.
    
    PR-URL: #29236
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joaocgreis authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    bb6e3b5 View commit details
    Browse the repository at this point in the history
  50. tools: update ESLint to 6.3.0

    Update ESLint to 6.3.0
    
    PR-URL: #29382
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    cjihrig authored and BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    cd70fd2 View commit details
    Browse the repository at this point in the history
  51. 2019-09-04, Version 12.10.0 (Current)

    Notable changes:
    
    * deps:
      * Update npm to 6.10.3 (isaacs)
        #29023
    * fs:
      * Add recursive option to rmdir() (cjihrig)
        #29168
      * Allow passing true to emitClose option (Giorgos Ntemiris)
        #29212
      * Add \*timeNs properties to BigInt Stats objects (Joyee Cheung)
        #21387
    * net:
      * Allow reading data into a static buffer (Brian White)
        #25436
    
    PR-URL: #29429
    BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    3a2e75d View commit details
    Browse the repository at this point in the history
  52. Working on v12.10.1

    PR-URL: #29429
    BridgeAR committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    b143a87 View commit details
    Browse the repository at this point in the history