build: allow clang 10+ in configure.py #29541
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected on NetBSD/amd64. Fixes: nodejs#29536
nodejs-github-bot
added
the
build
bnoordhuis
approved these changes
Sep 13, 2019
lpinca
approved these changes
Sep 13, 2019
devnexen
approved these changes
Sep 13, 2019
gengjiawen
approved these changes
Sep 13, 2019
cjihrig
approved these changes
Sep 13, 2019
richardlau
approved these changes
Sep 13, 2019
richardlau
added
the
author ready
pstef
approved these changes
Sep 13, 2019
|
Landed in 233cdb6 |
Trott
pushed a commit
that referenced
this pull request
Sep 15, 2019
Detected on NetBSD/amd64. Fixes: #29536 PR-URL: #29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Detected on NetBSD/amd64. Fixes: #29536 PR-URL: #29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
Detected on NetBSD/amd64. Fixes: #29536 PR-URL: #29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Sep 25, 2019
|
@nodejs/lts Please cherry-pick this onto v10.x so it can build with clang 10 and later. |
richardlau
pushed a commit
to richardlau/node-1
that referenced
this pull request
Apr 17, 2020
Detected on NetBSD/amd64. Fixes: nodejs#29536 PR-URL: nodejs#29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
I've cherry-picked it across to v10.x-staging. |
BethGriggs
pushed a commit
that referenced
this pull request
Jun 2, 2020
Detected on NetBSD/amd64. Fixes: #29536 PR-URL: #29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected on NetBSD/amd64.
Fixes: #29536
Checklist
make -j4 test(NetBSD), orpassesvcbuild test(Windows)