Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 35c6d4d #29585

Closed

Commits on Sep 16, 2019

  1. doc: update experimental loader hooks example code

    It fix 2 issues in provided Loader hooks examples:
    1. Original ``new URL(`${process.cwd()}/`, 'file://');``
    is not cross-platform, it gives wrong URL on windows
    2. Based on `CHECK` in ModuleWrap::Resolve (node 12.9.1,
    https://github.com/nodejs/node/blob/v12.9.1/src/module_wrap.cc#L1132)
    the 2nd parameter should be a `string`, not an `URL` object
    
    PR-URL: nodejs#29373
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    zaverden authored and devnexen committed Sep 16, 2019
    Copy the full SHA
    1ecc406 View commit details
    Browse the repository at this point in the history
  2. deps: V8: cherry-pick 35c6d4d

    Original commit message:
    
        Make code generator python3.7 compatible (async keyword).
    
        Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109
    
    Fixes: nodejs#29548
    Refs:
    - nodejs#29548 (comment)
    - nodejs#29520
    - nodejs#29340
    - https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
    - https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a
    sam-github committed Sep 16, 2019
    Copy the full SHA
    a150d99 View commit details
    Browse the repository at this point in the history