Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] backport HTTP/2 security release fixups #29619

Closed
wants to merge 2 commits into from
Closed

[v10.x] backport HTTP/2 security release fixups #29619

wants to merge 2 commits into from

Commits on Sep 19, 2019

  1. http2: do not crash on stream listener removal w/ destroyed session 

    Do not crash when the session is no longer available.

Fixes: nodejs#29457

PR-URL: nodejs#29459
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @addaleax
    addaleax committed Sep 19, 2019
    Copy the full SHA
    2f878d2 View commit details
    Browse the repository at this point in the history

  2. http2: do not start reading after write if new write is on wire 

    Don’t start reading more input data if we’re still busy writing output.
This was overlooked in 8a4a193.

Fixes: nodejs#29353
Fixes: nodejs#29393

PR-URL: nodejs#29399
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @addaleax
    addaleax committed Sep 19, 2019
    Copy the full SHA
    f1359fd View commit details
    Browse the repository at this point in the history