Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x] stream: eof & pipeline compat #29724

Closed
wants to merge 5 commits into from
Closed

[x] stream: eof & pipeline compat #29724

wants to merge 5 commits into from

Commits on Jan 18, 2020

  1. stream: make finished call the callback if the stream is closed 

    Make stream.finished callback invoked if stream is already
closed/destroyed.
    @ronag
    ronag committed Jan 18, 2020
    Copy the full SHA
    250bb00 View commit details
    Browse the repository at this point in the history

  2. fixup: isReadable & isWritable

    @ronag
    ronag committed Jan 18, 2020
    Copy the full SHA
    4eebd39 View commit details
    Browse the repository at this point in the history

  3. stream: remove ambiguous code 

    PR-URL: nodejs#29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @ronag
    ronag committed Jan 18, 2020
    Copy the full SHA
    ba74fd8 View commit details
    Browse the repository at this point in the history

  4. stream: eof & pipeline compat 

    Some broken streams might emit 'close' before 'end' or 'finish'.
However, if they have actually been ended or finished, this
should not result in a premature close error.

Fixes: nodejs#29699
    @ronag
    ronag committed Jan 18, 2020
    Copy the full SHA
    fa1239e View commit details
    Browse the repository at this point in the history

  5. fixup

    @ronag
    ronag committed Jan 18, 2020
    Copy the full SHA
    f730a54 View commit details
    Browse the repository at this point in the history