Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 53e62af #29898

Closed
wants to merge 1 commit into from
Closed

Commits on Oct 9, 2019

  1. deps: V8: cherry-pick 53e62af

    Original commit message:
    
        [build] Include string in v8.h
    
        Explicitly #include<string> in v8.h, since std::string is referenced
        in it. In the C++ STL shipped with Visual Studio 2019, none of the
        headers included in v8.h ends up including the C++ string header, which
        caused a compile error.
    
        Bug: v8:9793
        Change-Id: I84a133dd10dd6dcc7b70287af393e82cf0dc97df
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834321
        Reviewed-by: Adam Klein <adamk@chromium.org>
        Commit-Queue: Adam Klein <adamk@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64074}
    
    Refs: v8/v8@53e62af
    targos committed Oct 9, 2019
    Copy the full SHA
    4acf313 View commit details
    Browse the repository at this point in the history